Variable stop_report_cnt is being set or incremented but is never
being used for anything meaningful. The variable and code relating
to it's use is redundant and can be removed.
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
index 8043d819fb85..a182cdeb58e2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
@@ -997,7 +997,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
struct rtl_priv *rtlpriv = rtl_priv(hw);
u16 read_point, write_point;
bool ret = false;
- static u8 stop_report_cnt;
struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue];
{
@@ -1038,13 +1037,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
rtlpriv->psc.rfoff_reason > RF_CHANGE_BY_PS)
ret = true;
- if (hw_queue < BEACON_QUEUE) {
- if (!ret)
- stop_report_cnt++;
- else
- stop_report_cnt = 0;
- }
-
return ret;
}
--
2.37.3
> -----Original Message-----
> From: Colin Ian King <[email protected]>
> Sent: Monday, October 31, 2022 11:57 PM
> To: Ping-Ke Shih <[email protected]>; Kalle Valo <[email protected]>; David S . Miller
> <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>; [email protected]; [email protected]
> Cc: [email protected]; [email protected]
> Subject: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
>
> Variable stop_report_cnt is being set or incremented but is never
> being used for anything meaningful. The variable and code relating
> to it's use is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Ping-Ke Shih <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> index 8043d819fb85..a182cdeb58e2 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> @@ -997,7 +997,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> u16 read_point, write_point;
> bool ret = false;
> - static u8 stop_report_cnt;
> struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue];
>
> {
> @@ -1038,13 +1037,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
> rtlpriv->psc.rfoff_reason > RF_CHANGE_BY_PS)
> ret = true;
>
> - if (hw_queue < BEACON_QUEUE) {
> - if (!ret)
> - stop_report_cnt++;
> - else
> - stop_report_cnt = 0;
> - }
> -
> return ret;
> }
>
> --
> 2.37.3
>
>
> ------Please consider the environment before printing this e-mail.
> -----Original Message-----
> From: Ping-Ke Shih
> Sent: Tuesday, November 1, 2022 8:22 AM
> To: 'Colin Ian King' <[email protected]>; Kalle Valo <[email protected]>; David S . Miller
> <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>; [email protected]; [email protected]
> Cc: [email protected]; [email protected]
> Subject: RE: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
>
>
> > -----Original Message-----
> > From: Colin Ian King <[email protected]>
> > Sent: Monday, October 31, 2022 11:57 PM
> > To: Ping-Ke Shih <[email protected]>; Kalle Valo <[email protected]>; David S . Miller
> > <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> > <[email protected]>; [email protected]; [email protected]
> > Cc: [email protected]; [email protected]
> > Subject: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
Subject prefix should be "wifi: rtlwifi: ..."
I'm not sure if Kalle can help this, or you can send v2 to add prefix.
> >
> > Variable stop_report_cnt is being set or incremented but is never
> > being used for anything meaningful. The variable and code relating
> > to it's use is redundant and can be removed.
> >
> > Signed-off-by: Colin Ian King <[email protected]>
>
> Acked-by: Ping-Ke Shih <[email protected]>
>
> > ---
> > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> > b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> > index 8043d819fb85..a182cdeb58e2 100644
> > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> > @@ -997,7 +997,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
> > struct rtl_priv *rtlpriv = rtl_priv(hw);
> > u16 read_point, write_point;
> > bool ret = false;
> > - static u8 stop_report_cnt;
> > struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue];
> >
> > {
> > @@ -1038,13 +1037,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
> > rtlpriv->psc.rfoff_reason > RF_CHANGE_BY_PS)
> > ret = true;
> >
> > - if (hw_queue < BEACON_QUEUE) {
> > - if (!ret)
> > - stop_report_cnt++;
> > - else
> > - stop_report_cnt = 0;
> > - }
> > -
> > return ret;
> > }
> >
> > --
> > 2.37.3
> >
> >
> > ------Please consider the environment before printing this e-mail.
Ping-Ke Shih <[email protected]> writes:
>> -----Original Message-----
>> From: Ping-Ke Shih
>> Sent: Tuesday, November 1, 2022 8:22 AM
>> To: 'Colin Ian King' <[email protected]>; Kalle Valo
>> <[email protected]>; David S . Miller
>> <[email protected]>; Eric Dumazet <[email protected]>; Jakub
>> Kicinski <[email protected]>; Paolo Abeni
>> <[email protected]>; [email protected]; [email protected]
>> Cc: [email protected]; [email protected]
>> Subject: RE: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
>>
>>
>> > -----Original Message-----
>> > From: Colin Ian King <[email protected]>
>> > Sent: Monday, October 31, 2022 11:57 PM
>> > To: Ping-Ke Shih <[email protected]>; Kalle Valo
>> > <[email protected]>; David S . Miller
>> > <[email protected]>; Eric Dumazet <[email protected]>; Jakub
>> > Kicinski <[email protected]>; Paolo Abeni
>> > <[email protected]>; [email protected]; [email protected]
>> > Cc: [email protected]; [email protected]
>> > Subject: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
>
> Subject prefix should be "wifi: rtlwifi: ..."
>
> I'm not sure if Kalle can help this, or you can send v2 to add prefix.
Yeah, I can fix that during commit.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Colin Ian King <[email protected]> wrote:
> Variable stop_report_cnt is being set or incremented but is never
> being used for anything meaningful. The variable and code relating
> to it's use is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>
> Acked-by: Ping-Ke Shih <[email protected]>
Patch applied to wireless-next.git, thanks.
cdeee8540952 wifi: rtlwifi: rtl8192ee: remove static variable stop_report_cnt
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches