2010-01-27 15:51:08

by Joerg

[permalink] [raw]
Subject: AW: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'

John,
thanks for the quick response. The patch works fine for me. Feel free to add a

Tested-by: "Joerg Pommnitz" <[email protected]>

--
Regards
? ? ???Joerg


--- John W. Linville <[email protected]> schrieb am Mi, 27.1.2010:

> Von: John W. Linville <[email protected]>
> Betreff: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'
> An: [email protected]
> CC: "Joerg Pommnitz" <[email protected]>, "John W. Linville" <[email protected]>
> Datum: Mittwoch, 27. Januar 2010, 15:44
> Signed-off-by: John W. Linville
> <[email protected]>
> ---
> Haven't had a chance to test yet, but I suspect this fixes
> the issue...?
>
>? net/wireless/wext-compat.c |? ? 2 +-
>? 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/wireless/wext-compat.c
> b/net/wireless/wext-compat.c
> index 966d2f0..b17eeae 100644
> --- a/net/wireless/wext-compat.c
> +++ b/net/wireless/wext-compat.c
> @@ -1214,7 +1214,7 @@ int cfg80211_wext_siwrate(struct
> net_device *dev,
>?
>? ??? memset(&mask, 0, sizeof(mask));
>? ??? fixed = 0;
> -??? maxrate = 0;
> +??? maxrate = (u32)-1;
>?
>? ??? if (rate->value < 0) {
>? ??? ??? /* nothing */
> --
> 1.6.2.5
>
>


__________________________________________________
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verf?gt ?ber einen herausragenden Schutz gegen Massenmails.
http://mail.yahoo.com


2010-01-27 16:30:34

by John W. Linville

[permalink] [raw]
Subject: Re: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'

On Wed, Jan 27, 2010 at 07:51:06AM -0800, Joerg Pommnitz wrote:
> John,
> thanks for the quick response. The patch works fine for me. Feel free to add a
>
> Tested-by: "Joerg Pommnitz" <[email protected]>

Joerg,

I still haven't had time for a reboot. :-( I wonder if you tested
to make sure that using "fixed" or just a rate by itself still works
properly too?

Thanks!

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2010-01-28 08:35:00

by Joerg

[permalink] [raw]
Subject: Re: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'

John,
I switched between a fixed data rate and automatic selection. Selecting a
fixed data rate seems to work fine. I can't be 100% sure, because the
RC algorithm might have decided to pick exactly this rate, but this would
be very unlikely. Switching back to auto looks good, too.

--
Regards
Joerg


--- John W. Linville <[email protected]> schrieb am Mi, 27.1.2010:

> Von: John W. Linville <[email protected]>
> Betreff: Re: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'
> An: "Joerg Pommnitz" <[email protected]>
> CC: [email protected]
> Datum: Mittwoch, 27. Januar 2010, 17:17
> On Wed, Jan 27, 2010 at 07:51:06AM
> -0800, Joerg Pommnitz wrote:
> > John,
> > thanks for the quick response. The patch works fine
> for me. Feel free to add a
> >
> > Tested-by: "Joerg Pommnitz" <[email protected]>
>
> Joerg,
>
> I still haven't had time for a reboot. :-(? I wonder
> if you tested
> to make sure that using "fixed" or just a rate by itself
> still works
> properly too?
>
> Thanks!
>
> John
> --
> John W. Linville??? ???
> Someday the world will need a hero, and you
> [email protected]???
> ??? ??? might be all we
> have.? Be ready.
>

__________________________________________________
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verf?gt ?ber einen herausragenden Schutz gegen Massenmails.
http://mail.yahoo.com