2017-10-14 09:46:16

by Christos Gkekas

Subject: [PATCH] ath9k: debug: Remove redundant check

Variable val is unsigned, so checking whether it is less than zero is
redundant.

Signed-off-by: Christos Gkekas <[email protected]>
---
drivers/net/wireless/ath/ath9k/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c
index 01fa301..4f5f141 100644
--- a/drivers/net/wireless/ath/ath9k/debug.c
+++ b/drivers/net/wireless/ath/ath9k/debug.c
@@ -1167,7 +1167,7 @@ static ssize_t write_file_tpc(struct file *file, const char __user *user_buf,
if (kstrtoul(buf, 0, &val))
return -EINVAL;

- if (val < 0 || val > 1)
+ if (val > 1)
return -EINVAL;

tpc_enabled = !!val;
--
2.7.4

2017-10-27 13:50:51

by Kalle Valo

Subject: Re: ath9k: debug: Remove redundant check

Christos Gkekas <[email protected]> wrote:

> Variable val is unsigned, so checking whether it is less than zero is
> redundant.
>
> Signed-off-by: Christos Gkekas <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

9d414949a306 ath9k: debug: Remove redundant check

--
https://patchwork.kernel.org/patch/10006341/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches