2011-05-17 04:46:32

by Daniel Halperin

Subject: [PATCH] iwlwifi: remove unused parameter from iwl_hcmd_queue_reclaim

cmd_index is never used.

Signed-off-by: Daniel Halperin <[email protected]>
---
drivers/net/wireless/iwlwifi/iwl-tx.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
index 54a935f..686e176 100644
--- a/drivers/net/wireless/iwlwifi/iwl-tx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
@@ -746,8 +746,7 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
* need to be reclaimed. As result, some free space forms. If there is
* enough free space (> low mark), wake the stack that feeds us.
*/
-static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id,
- int idx, int cmd_idx)
+static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id, int idx)
{
struct iwl_tx_queue *txq = &priv->txq[txq_id];
struct iwl_queue *q = &txq->q;
@@ -819,7 +818,7 @@ void iwl_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)

spin_lock_irqsave(&priv->hcmd_lock, flags);

- iwl_hcmd_queue_reclaim(priv, txq_id, index, cmd_index);
+ iwl_hcmd_queue_reclaim(priv, txq_id, index);

if (!(meta->flags & CMD_ASYNC)) {
clear_bit(STATUS_HCMD_ACTIVE, &priv->status);
--
1.7.0.4

2011-05-17 14:49:47

by Wey-Yi Guy

Subject: Re: [PATCH] iwlwifi: remove unused parameter from iwl_hcmd_queue_reclaim

On Mon, 2011-05-16 at 21:46 -0700, Daniel Halperin wrote:
> cmd_index is never used.
>
> Signed-off-by: Daniel Halperin <[email protected]>
> ---
> drivers/net/wireless/iwlwifi/iwl-tx.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
> index 54a935f..686e176 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-tx.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
> @@ -746,8 +746,7 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
> * need to be reclaimed. As result, some free space forms. If there is
> * enough free space (> low mark), wake the stack that feeds us.
> */
> -static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id,
> - int idx, int cmd_idx)
> +static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id, int idx)
> {
> struct iwl_tx_queue *txq = &priv->txq[txq_id];
> struct iwl_queue *q = &txq->q;
> @@ -819,7 +818,7 @@ void iwl_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
>
> spin_lock_irqsave(&priv->hcmd_lock, flags);
>
> - iwl_hcmd_queue_reclaim(priv, txq_id, index, cmd_index);
> + iwl_hcmd_queue_reclaim(priv, txq_id, index);
>
> if (!(meta->flags & CMD_ASYNC)) {
> clear_bit(STATUS_HCMD_ACTIVE, &priv->status);
Thanks
Wey