2017-12-07 09:33:25

by Wright Feng

[permalink] [raw]
Subject: [PATCH] brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

From: Double Lo <[email protected]>

This patch will add 43455 into the save-restore(SR) capable chip list, so
the SR engine will be enabled with 43455 FW which built-in the -sr
function.

Signed-off-by: Double Lo <[email protected]>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
index c5d1a1c..f7b30ce 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
@@ -1338,6 +1338,7 @@ bool brcmf_chip_sr_capable(struct brcmf_chip *pub)
switch (pub->chip) {
case BRCM_CC_4354_CHIP_ID:
case BRCM_CC_4356_CHIP_ID:
+ case BRCM_CC_4345_CHIP_ID:
/* explicitly check SR engine enable bit */
pmu_cc3_mask = BIT(2);
/* fall-through */
--
1.9.1


2017-12-18 02:04:15

by Wright Feng

[permalink] [raw]
Subject: Re: brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr



On 2017/12/14 下午 08:39, Kalle Valo wrote:
> Wright Feng <[email protected]> wrote:
>
>> From: Double Lo <[email protected]>
>>
>> This patch will add 43455 into the save-restore(SR) capable chip list, so
>> the SR engine will be enabled with 43455 FW which built-in the -sr
>> function.
>>
>> Signed-off-by: Double Lo <[email protected]>
Signed-off-by: Wright Feng <[email protected]>
>
> Wright's s-o-b is missing:
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing
>
Kalle,
Thanks for reminding, please let me know if I have to send [Patch v2]
for this.

2017-12-18 13:39:48

by Kalle Valo

[permalink] [raw]
Subject: Re: brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

Wright Feng <[email protected]> writes:

> On 2017/12/14 =E4=B8=8B=E5=8D=88 08:39, Kalle Valo wrote:
>> Wright Feng <[email protected]> wrote:
>>
>>> From: Double Lo <[email protected]>
>>>
>>> This patch will add 43455 into the save-restore(SR) capable chip list, =
so
>>> the SR engine will be enabled with 43455 FW which built-in the -sr
>>> function.
>>>
>>> Signed-off-by: Double Lo <[email protected]>
> Signed-off-by: Wright Feng <[email protected]>
>>
>> Wright's s-o-b is missing:
>>
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingp=
atches#signed-off-by_missing
>>
> Kalle,
> Thanks for reminding, please let me know if I have to send [Patch v2]
> for this.

Yes, please send v2.

To save my time you can actually check this from patchwork:

https://patchwork.kernel.org/patch/10097897/

If the state is "Changes Requested" it means that I'm expecting the
author to submit a new version. More info:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes#checking_state_of_patches_from_patchwork

--=20
Kalle Valo

2017-12-14 12:39:44

by Kalle Valo

[permalink] [raw]
Subject: Re: brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

Wright Feng <[email protected]> wrote:

> From: Double Lo <[email protected]>
>
> This patch will add 43455 into the save-restore(SR) capable chip list, so
> the SR engine will be enabled with 43455 FW which built-in the -sr
> function.
>
> Signed-off-by: Double Lo <[email protected]>

Wright's s-o-b is missing:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing

--
https://patchwork.kernel.org/patch/10097897/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches