On 9/4/23 18:23, Rand Deeb wrote:
> In ssb_calc_clock_rate(), there is a potential issue where the value of
> m1 could be zero due to initialization using clkfactor_f6_resolv(). This
> situation raised concerns about the possibility of a division by zero
> error.
>
> We fixed it by following the suggestions provided by Larry Finger
> <[email protected]> and Michael Büsch <[email protected]>. The fix
> involves returning a value of 1 instead of 0 in clkfactor_f6_resolv().
> This modification ensures the proper functioning of the code and
> eliminates the risk of division by zero errors.
>
> Signed-off-by: Rand Deeb <[email protected]>
> ---
> drivers/ssb/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index 0a26984acb2c..9e54bc7eec66 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -835,7 +835,7 @@ static u32 clkfactor_f6_resolve(u32 v)
> case SSB_CHIPCO_CLK_F6_7:
> return 7;
> }
> - return 0;
> + return 1;
> }
Acked-by: Larry Finger <[email protected]>
Larry
>
> /* Calculate the speed the backplane would run at a given set of clockcontrol values */