2024-03-12 12:17:43

by Bitterblue Smith

[permalink] [raw]
Subject: [PATCH] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power

Different channels have different TX power settings. rtl8192de is using
the TX power setting from the wrong channel in the 5 GHz band because
_rtl92c_phy_get_rightchnlplace expects an array which includes 2.4 GHz
and 5 GHz channel numbers, but it's using an array which includes only
the 5 GHz channel numbers.

Use the array channel_all (defined in rtl8192de/phy.c) instead of
the incorrect channel5g (defined in core.c).

Tested only with rtl8192du, which will use the same TX power code.

Signed-off-by: Bitterblue Smith <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
index d835a27429f0..56b5cd032a9a 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
@@ -892,8 +892,8 @@ static u8 _rtl92c_phy_get_rightchnlplace(u8 chnl)
u8 place = chnl;

if (chnl > 14) {
- for (place = 14; place < ARRAY_SIZE(channel5g); place++) {
- if (channel5g[place] == chnl) {
+ for (place = 14; place < ARRAY_SIZE(channel_all); place++) {
+ if (channel_all[place] == chnl) {
place++;
break;
}
--
2.43.2


2024-03-13 01:55:46

by Ping-Ke Shih

[permalink] [raw]
Subject: RE: [PATCH] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power



> -----Original Message-----
> From: Bitterblue Smith <[email protected]>
> Sent: Tuesday, March 12, 2024 8:17 PM
> To: [email protected]
> Cc: Ping-Ke Shih <[email protected]>; Larry Finger <[email protected]>
> Subject: [PATCH] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power
>
> Different channels have different TX power settings. rtl8192de is using
> the TX power setting from the wrong channel in the 5 GHz band because
> _rtl92c_phy_get_rightchnlplace expects an array which includes 2.4 GHz
> and 5 GHz channel numbers, but it's using an array which includes only
> the 5 GHz channel numbers.
>
> Use the array channel_all (defined in rtl8192de/phy.c) instead of
> the incorrect channel5g (defined in core.c).
>
> Tested only with rtl8192du, which will use the same TX power code.
> Signed-off-by: Bitterblue Smith <[email protected]>

Acked-by: Ping-Ke Shih <[email protected]>

2024-03-13 02:00:43

by Ping-Ke Shih

[permalink] [raw]
Subject: RE: [PATCH] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power



> -----Original Message-----
> From: Ping-Ke Shih <[email protected]>
> Sent: Wednesday, March 13, 2024 9:55 AM
> To: Bitterblue Smith <[email protected]>; [email protected]
> Cc: Larry Finger <[email protected]>
> Subject: RE: [PATCH] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power
>
> > Tested only with rtl8192du, which will use the same TX power code.

Because another patchset adding rtl8192du is based on this patch, I suggest
to send them as single one patchset.

Ping-Ke

2024-03-13 22:35:37

by Bitterblue Smith

[permalink] [raw]
Subject: Re: [PATCH] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power

On 13/03/2024 04:00, Ping-Ke Shih wrote:
>
>
>> -----Original Message-----
>> From: Ping-Ke Shih <[email protected]>
>> Sent: Wednesday, March 13, 2024 9:55 AM
>> To: Bitterblue Smith <[email protected]>; [email protected]
>> Cc: Larry Finger <[email protected]>
>> Subject: RE: [PATCH] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power
>>
>>> Tested only with rtl8192du, which will use the same TX power code.
>
> Because another patchset adding rtl8192du is based on this patch, I suggest
> to send them as single one patchset.
>
> Ping-Ke
>

I can do that, but Kalle will probably apply this patch long
before v2 of that patchset is ready.

2024-03-14 00:25:51

by Ping-Ke Shih

[permalink] [raw]
Subject: Re: [PATCH] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power

On Thu, 2024-03-14 at 00:34 +0200, Bitterblue Smith wrote:
>
> On 13/03/2024 04:00, Ping-Ke Shih wrote:
> >
> > > -----Original Message-----
> > > From: Ping-Ke Shih <[email protected]>
> > > Sent: Wednesday, March 13, 2024 9:55 AM
> > > To: Bitterblue Smith <[email protected]>; [email protected]
> > > Cc: Larry Finger <[email protected]>
> > > Subject: RE: [PATCH] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power
> > >
> > > > Tested only with rtl8192du, which will use the same TX power code.
> >
> > Because another patchset adding rtl8192du is based on this patch, I suggest
> > to send them as single one patchset.
> >
>
> I can do that, but Kalle will probably apply this patch long
> before v2 of that patchset is ready.

Right. But next time you can send mutual dependent patches in a patchset, or
describe their dependency in cover letter. And, I prefer them in a patchset.