2023-11-27 16:24:25

by Gustavo A. R. Silva

[permalink] [raw]
Subject: Re: [PATCH 2/4] wifi: ath10k: Use DECLARE_FLEX_ARRAY() for ath10k_htc_record



On 11/27/23 10:14, Jeff Johnson wrote:
> Transform the zero-length arrays in ath10k_htc_record into proper
> flexible arrays via the DECLARE_FLEX_ARRAY() macro. This helps with
> ongoing efforts to globally enable -Warray-bounds.
>
> Signed-off-by: Jeff Johnson <[email protected]>

Reviewed-by: Gustavo A. R. Silva <[email protected]>

Thanks
--
Gustavo

> ---
> drivers/net/wireless/ath/ath10k/htc.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h
> index 9cbb901d35e5..c6c392f8630c 100644
> --- a/drivers/net/wireless/ath/ath10k/htc.h
> +++ b/drivers/net/wireless/ath/ath10k/htc.h
> @@ -246,9 +246,9 @@ struct ath10k_htc_lookahead_bundle {
> struct ath10k_htc_record {
> struct ath10k_ath10k_htc_record_hdr hdr;
> union {
> - struct ath10k_htc_credit_report credit_report[0];
> - struct ath10k_htc_lookahead_report lookahead_report[0];
> - struct ath10k_htc_lookahead_bundle lookahead_bundle[0];
> + DECLARE_FLEX_ARRAY(struct ath10k_htc_credit_report, credit_report);
> + DECLARE_FLEX_ARRAY(struct ath10k_htc_lookahead_report, lookahead_report);
> + DECLARE_FLEX_ARRAY(struct ath10k_htc_lookahead_bundle, lookahead_bundle);
> };
> } __packed __aligned(4);
>
>