2020-05-15 06:21:10

by Tony Chuang

Subject: RE: [PATCH] rtw88: no need to set registers for SDIO

Kevin Lo <[email protected]> writes:
> Subject: [PATCH] rtw88: no need to set registers for SDIO
>
> There's no need to set SDIO related registers when powering up/down the chip.
>
> Signed-off-by: Kevin Lo <[email protected]>
> ---
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.c
> b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
> index b517af417e0e..5e0b7999bc8a 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8723d.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
> @@ -2092,16 +2092,6 @@ static const struct rtw_pwr_seq_cmd
> trans_carddis_to_cardemu_8723d[] = {
> RTW_PWR_INTF_ALL_MSK,
> RTW_PWR_ADDR_MAC,
> RTW_PWR_CMD_WRITE, BIT(3) | BIT(7), 0},
> - {0x0086,
> - RTW_PWR_CUT_ALL_MSK,
> - RTW_PWR_INTF_SDIO_MSK,
> - RTW_PWR_ADDR_SDIO,
> - RTW_PWR_CMD_WRITE, BIT(0), 0},
> - {0x0086,
> - RTW_PWR_CUT_ALL_MSK,
> - RTW_PWR_INTF_SDIO_MSK,
> - RTW_PWR_ADDR_SDIO,
> - RTW_PWR_CMD_POLLING, BIT(1), BIT(1)},
> {0x004A,
> RTW_PWR_CUT_ALL_MSK,
> RTW_PWR_INTF_USB_MSK,

I don't think we should remove SDIO part in the power sequence.
The power sequence parse will recognize the HCI interface. So the
SDIO settings will not be applied at all. We can keep them here until
the SDIO module is added and supported.

Yen-Hsuan

2020-05-16 14:55:05

by Kevin Lo

Subject: Re: [PATCH] rtw88: no need to set registers for SDIO

On Fri, May 15, 2020 at 06:16:55AM +0000, Tony Chuang wrote:
>
> Kevin Lo <[email protected]> writes:
> > Subject: [PATCH] rtw88: no need to set registers for SDIO
> >
> > There's no need to set SDIO related registers when powering up/down the chip.
> >
> > Signed-off-by: Kevin Lo <[email protected]>
> > ---
> > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.c
> > b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
> > index b517af417e0e..5e0b7999bc8a 100644
> > --- a/drivers/net/wireless/realtek/rtw88/rtw8723d.c
> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
> > @@ -2092,16 +2092,6 @@ static const struct rtw_pwr_seq_cmd
> > trans_carddis_to_cardemu_8723d[] = {
> > RTW_PWR_INTF_ALL_MSK,
> > RTW_PWR_ADDR_MAC,
> > RTW_PWR_CMD_WRITE, BIT(3) | BIT(7), 0},
> > - {0x0086,
> > - RTW_PWR_CUT_ALL_MSK,
> > - RTW_PWR_INTF_SDIO_MSK,
> > - RTW_PWR_ADDR_SDIO,
> > - RTW_PWR_CMD_WRITE, BIT(0), 0},
> > - {0x0086,
> > - RTW_PWR_CUT_ALL_MSK,
> > - RTW_PWR_INTF_SDIO_MSK,
> > - RTW_PWR_ADDR_SDIO,
> > - RTW_PWR_CMD_POLLING, BIT(1), BIT(1)},
> > {0x004A,
> > RTW_PWR_CUT_ALL_MSK,
> > RTW_PWR_INTF_USB_MSK,
>
> I don't think we should remove SDIO part in the power sequence.
> The power sequence parse will recognize the HCI interface. So the
> SDIO settings will not be applied at all. We can keep them here until
> the SDIO module is added and supported.

Well, I thought only usb devices will be supported by rtw88.
I'm happy to see rtw88 SDIO support, thanks.

> Yen-Hsuan