2022-01-30 19:05:38

by Kalle Valo

Subject: Re: [PATCH] dvm: use struct_size over open coded arithmetic

[email protected] writes:

> From: Minghao Chi (CGEL ZTE) <[email protected]>
>
> Replace zero-length array with flexible-array member and make use
> of the struct_size() helper in kmalloc(). For example:
>
> struct iwl_wipan_noa_data {
> ...
> u8 data[];
> };
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi (CGEL ZTE) <[email protected]>
> ---
> drivers/net/wireless/intel/iwlwifi/dvm/rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

The prefix should be "iwlwifi: dvm:".

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-01-30 20:48:23

by CGEL

Subject: [PATCH v2] iwlwifi: dvm: use struct_size over open coded arithmetic

From: Minghao Chi (CGEL ZTE) <[email protected]>

Replace zero-length array with flexible-array member and make use
of the struct_size() helper in kmalloc(). For example:

struct iwl_wipan_noa_data {
...
u8 data[];
}

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi (CGEL ZTE) <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/dvm/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rx.c b/drivers/net/wireless/intel/iwlwifi/dvm/rx.c
index db0c41bbeb0e..d0d842b25b86 100644
--- a/drivers/net/wireless/intel/iwlwifi/dvm/rx.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/rx.c
@@ -915,7 +915,7 @@ static void iwlagn_rx_noa_notification(struct iwl_priv *priv,
len += 1 + 2;
copylen += 1 + 2;

- new_data = kmalloc(sizeof(*new_data) + len, GFP_ATOMIC);
+ new_data = kmalloc(struct_size(*new_data, data, len), GFP_ATOMIC);
if (new_data) {
new_data->length = len;
new_data->data[0] = WLAN_EID_VENDOR_SPECIFIC;
--
2.25.1

2022-01-31 10:59:45

by Luciano Coelho

Subject: Re: [PATCH v2] iwlwifi: dvm: use struct_size over open coded arithmetic

On Fri, 2022-01-28 at 09:31 +0000, [email protected] wrote:
> From: Minghao Chi (CGEL ZTE) <[email protected]>
>
> Replace zero-length array with flexible-array member and make use
> of the struct_size() helper in kmalloc(). For example:

You're not replacing zero-length arrays in this patch, so this is not
correct. Probably a copy/paste from a different patch?

--
Cheers,
Luca.