2022-01-26 11:48:49

by Zzy Wysm

[permalink] [raw]
Subject: Fix fell on the floor for rcu violation in net/wireless/scan.c

On 2021-07-30 syzbot reported the following bug in net/wireless/scan.c:

https://lore.kernel.org/all/[email protected]/

Hillf Danton proposed a patch, which I can’t find on lore but is available here:

https://groups.google.com/g/syzkaller-bugs/c/fhfh_VqZQkI

As you can see at the end of that thread, syzkaller has automatically closed this bug because it hasn’t seen it in a while. However, the proposed patch appears to be a valid bug fix. Can you re-evaluate it for consideration?

Thanks,
zzy


2022-01-26 18:37:41

by Kalle Valo

[permalink] [raw]
Subject: Re: Fix fell on the floor for rcu violation in net/wireless/scan.c

Zzy Wysm <[email protected]> writes:

> On 2021-07-30 syzbot reported the following bug in net/wireless/scan.c:
>
> https://lore.kernel.org/all/[email protected]/
>
> Hillf Danton proposed a patch, which I can’t find on lore but is available here:
>
> https://groups.google.com/g/syzkaller-bugs/c/fhfh_VqZQkI
>
> As you can see at the end of that thread, syzkaller has automatically
> closed this bug because it hasn’t seen it in a while. However, the
> proposed patch appears to be a valid bug fix. Can you re-evaluate it
> for consideration?

That's not a proper way to submit patches, see the wiki link below how
to submit wireless patches.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-01-26 20:42:30

by Johannes Berg

[permalink] [raw]
Subject: Re: Fix fell on the floor for rcu violation in net/wireless/scan.c

On Tue, 2022-01-25 at 17:47 -0500, Zzy Wysm wrote:
>
> However, the proposed patch appears to be a valid bug fix.

It didn't really look like that to me. Explain why you think so?

johannes