2011-03-03 05:47:45

by Justin P. Mattock

[permalink] [raw]
Subject: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

not sure what this is..(below)


[ 33.951046] CE: hpet increased min_delta_ns to 20113 nsec
[ 35.567319] EXT4-fs (sda3): re-mounted. Opts:
errors=panic,user_xattr,debug,acl,commit=600
[ 36.350144] wlan0: authenticate with 00:0b:86:32:f8:60 (try 1)
[ 36.352284] wlan0: authenticated
[ 36.352396] wlan0: associate with 00:0b:86:32:f8:60 (try 1)
[ 36.356854] wlan0: RX AssocResp from 00:0b:86:32:f8:60 (capab=0x421
status=0 aid=2)
[ 36.356862] wlan0: associated
[ 41.370318] ath: DMA failed to stop in 10 ms AR_CR=0x00000024
AR_DIAG_SW=0x42000020
[ 41.370324] ath: Could not stop RX, we could be confusing the DMA
engine when we start RX up
[ 41.370328] ------------[ cut here ]------------
[ 41.370345] WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536
ath_stoprecv+0xc8/0xda [ath9k]()
[ 41.370349] Hardware name: MacBookPro2,2
[ 41.370351] Modules linked in: hidp xfrm4_mode_transport xcbc
rmd160 sha512_generic rfcomm sco bnep l2cap ipt_REJECT xt_tcpudp
ipt_LOG iptable_nat nf_nat xt_state nf_conntrack_ftp nf_conntrack_ipv4
nf_conntrack nf_defrag_ipv4 iptable_filter ip_tables x_tables btusb
bluetooth evdev psmouse thermal fan container button ac battery video
ath9k ath9k_common ath9k_hw ath ttm drm aes_x86_64 lzo zlib ipcomp
xfrm_ipcomp crypto_null sha256_generic cbc des_generic cast5 blowfish
serpent camellia twofish_generic twofish_x86_64 twofish_common ctr ah4
esp4 authenc firewire_ohci firewire_core uhci_hcd ehci_hcd coretemp
acpi_cpufreq processor mperf appletouch applesmc
[ 41.370430] Pid: 766, comm: kworker/u:4 Not tainted
2.6.38-rc6-00116-g2821f46 #5
[ 41.370434] Call Trace:
[ 41.370444] [<ffffffff810612c0>] ? warn_slowpath_common+0x80/0x98
[ 41.370450] [<ffffffff810612ed>] ? warn_slowpath_null+0x15/0x17
[ 41.370458] [<ffffffffa01c6438>] ? ath_stoprecv+0xc8/0xda [ath9k]
[ 41.370467] [<ffffffffa01c3a62>] ? ath_set_channel+0xb0/0x217 [ath9k]
[ 41.370475] [<ffffffffa01c3f89>] ? ath9k_config+0x3c0/0x4c3 [ath9k]
[ 41.370482] [<ffffffff8140fe8a>] ? ieee80211_hw_config+0x120/0x129
[ 41.370487] [<ffffffff81413902>] ? ieee80211_scan_work+0x2f8/0x496
[ 41.370495] [<ffffffffa01c7934>] ?
ath_tx_complete_poll_work+0xf3/0x102 [ath9k]
[ 41.370501] [<ffffffff8141360a>] ? ieee80211_scan_work+0x0/0x496
[ 41.370506] [<ffffffff810769c7>] ? process_one_work+0x266/0x3d7
[ 41.370511] [<ffffffff81076e9f>] ? worker_thread+0x1d6/0x350
[ 41.370515] [<ffffffff81076cc9>] ? worker_thread+0x0/0x350
[ 41.370521] [<ffffffff8107bdcf>] ? kthread+0x7d/0x85
[ 41.370528] [<ffffffff8102e064>] ? kernel_thread_helper+0x4/0x10
[ 41.370533] [<ffffffff8107bd52>] ? kthread+0x0/0x85
[ 41.370537] [<ffffffff8102e060>] ? kernel_thread_helper+0x0/0x10
[ 41.370541] ---[ end trace 062f507148a6fa8e ]---


from what I remember I was at a local college(caltech) trying to
connect to their public wifi
in the public area. with no luck, then this popped up.
full dmesg here:

http://fpaste.org/SKU4/


--
Justin P. Mattock


2011-03-04 00:55:14

by Justin P. Mattock

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On Thu, Mar 3, 2011 at 5:59 AM, John W. Linville <[email protected]> wrote:
> On Wed, Mar 02, 2011 at 09:47:43PM -0800, Justin Mattock wrote:
>> not sure what this is..(below)
>>
>>
>> [ ? 33.951046] CE: hpet increased min_delta_ns to 20113 nsec
>> [ ? 35.567319] EXT4-fs (sda3): re-mounted. Opts:
>> errors=panic,user_xattr,debug,acl,commit=600
>> [ ? 36.350144] wlan0: authenticate with 00:0b:86:32:f8:60 (try 1)
>> [ ? 36.352284] wlan0: authenticated
>> [ ? 36.352396] wlan0: associate with 00:0b:86:32:f8:60 (try 1)
>> [ ? 36.356854] wlan0: RX AssocResp from 00:0b:86:32:f8:60 (capab=0x421
>> status=0 aid=2)
>> [ ? 36.356862] wlan0: associated
>> [ ? 41.370318] ath: DMA failed to stop in 10 ms AR_CR=0x00000024
>> AR_DIAG_SW=0x42000020
>> [ ? 41.370324] ath: Could not stop RX, we could be confusing the DMA
>> engine when we start RX up
>> [ ? 41.370328] ------------[ cut here ]------------
>> [ ? 41.370345] WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536
>> ath_stoprecv+0xc8/0xda [ath9k]()
>> [ ? 41.370349] Hardware name: MacBookPro2,2
>> [ ? 41.370351] Modules linked in: hidp xfrm4_mode_transport xcbc
>> rmd160 sha512_generic rfcomm sco bnep l2cap ipt_REJECT xt_tcpudp
>> ipt_LOG iptable_nat nf_nat xt_state nf_conntrack_ftp nf_conntrack_ipv4
>> nf_conntrack nf_defrag_ipv4 iptable_filter ip_tables x_tables btusb
>> bluetooth evdev psmouse thermal fan container button ac battery video
>> ath9k ath9k_common ath9k_hw ath ttm drm aes_x86_64 lzo zlib ipcomp
>> xfrm_ipcomp crypto_null sha256_generic cbc des_generic cast5 blowfish
>> serpent camellia twofish_generic twofish_x86_64 twofish_common ctr ah4
>> esp4 authenc firewire_ohci firewire_core uhci_hcd ehci_hcd coretemp
>> acpi_cpufreq processor mperf appletouch applesmc
>> [ ? 41.370430] Pid: 766, comm: kworker/u:4 Not tainted
>> 2.6.38-rc6-00116-g2821f46 #5
>> [ ? 41.370434] Call Trace:
>> [ ? 41.370444] ?[<ffffffff810612c0>] ? warn_slowpath_common+0x80/0x98
>> [ ? 41.370450] ?[<ffffffff810612ed>] ? warn_slowpath_null+0x15/0x17
>> [ ? 41.370458] ?[<ffffffffa01c6438>] ? ath_stoprecv+0xc8/0xda [ath9k]
>> [ ? 41.370467] ?[<ffffffffa01c3a62>] ? ath_set_channel+0xb0/0x217 [ath9k]
>> [ ? 41.370475] ?[<ffffffffa01c3f89>] ? ath9k_config+0x3c0/0x4c3 [ath9k]
>> [ ? 41.370482] ?[<ffffffff8140fe8a>] ? ieee80211_hw_config+0x120/0x129
>> [ ? 41.370487] ?[<ffffffff81413902>] ? ieee80211_scan_work+0x2f8/0x496
>> [ ? 41.370495] ?[<ffffffffa01c7934>] ?
>> ath_tx_complete_poll_work+0xf3/0x102 [ath9k]
>> [ ? 41.370501] ?[<ffffffff8141360a>] ? ieee80211_scan_work+0x0/0x496
>> [ ? 41.370506] ?[<ffffffff810769c7>] ? process_one_work+0x266/0x3d7
>> [ ? 41.370511] ?[<ffffffff81076e9f>] ? worker_thread+0x1d6/0x350
>> [ ? 41.370515] ?[<ffffffff81076cc9>] ? worker_thread+0x0/0x350
>> [ ? 41.370521] ?[<ffffffff8107bdcf>] ? kthread+0x7d/0x85
>> [ ? 41.370528] ?[<ffffffff8102e064>] ? kernel_thread_helper+0x4/0x10
>> [ ? 41.370533] ?[<ffffffff8107bd52>] ? kthread+0x0/0x85
>> [ ? 41.370537] ?[<ffffffff8102e060>] ? kernel_thread_helper+0x0/0x10
>> [ ? 41.370541] ---[ end trace 062f507148a6fa8e ]---
>>
>>
>> from what I remember I was at a local college(caltech) trying to
>> connect to their public wifi
>> in the public area. with no luck, then this popped up.
>> full dmesg here:
>>
>> http://fpaste.org/SKU4/
>
> In ath_stoprecv:
>
> ? ? ? ?if (!(ah->ah_flags & AH_UNPLUGGED) &&
> ? ? ? ? ? ?unlikely(!stopped)) {
> ? ? ? ? ? ? ? ?ath_err(ath9k_hw_common(sc->sc_ah),
> ? ? ? ? ? ? ? ? ? ? ? ?"Could not stop RX, we could be "
> ? ? ? ? ? ? ? ? ? ? ? ?"confusing the DMA engine when we start RX up\n");
> ? ? ? ? ? ? ? ?ATH_DBG_WARN_ON_ONCE(!stopped);
> ? ? ? ?}
>
> The Atheros guys will have to comment.
>
> John
> --
> John W. Linville ? ? ? ? ? ? ? ?Someday the world will need a hero, and you
> [email protected] ? ? ? ? ? ? ? ? ?might be all we have. ?Be ready.
>

cool, thanks for the reply.
yeah this is strange, seems to have happened in that location and not others.
(if I have time wouldn't mind testing out other kernel versions and
maybe a bisect to
grab this)

--
Justin P. Mattock

2011-03-08 20:00:08

by Ben Greear

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On 03/08/2011 11:45 AM, Brian Prodoehl wrote:
> On Tue, Mar 8, 2011 at 2:27 PM, Ben Greear<[email protected]> wrote:
>> On 03/08/2011 10:49 AM, Justin P. Mattock wrote:
>>>
>>> On 03/07/2011 07:22 AM, Mohammed Shafi wrote:
>>>>
>>>> On Mon, Mar 7, 2011 at 8:42 PM, John W.
>>>> Linville<[email protected]> wrote:
>>>>>
>>>>> On Sun, Mar 06, 2011 at 12:47:05AM -0800, Justin Mattock wrote:
>>>>>
>>>>>> full dmesg here:
>>>>>> http://fpaste.org/5JQp/
>>>>>> let me know if I need to supply any info(also I can try a bisect, but
>>>>>> am in the middle of changing residencies, so it might not be right
>>>>>> away)
>>>>>
>>>>> One of the Atheros guys suggested that you change a DMA timeout value.
>>>>> Did you try that?
>>>>
>>>> John it looks like increasing the timeout also does not seems to help.
>>>> A user reported this issue in ath9k developer list and he told that
>>>> increasing the timeout did not fix this issue.
>>>>
>>>>>
>>>>> John
>>>>> --
>>>>> John W. Linville Someday the world will need a hero, and you
>>>>> [email protected] might be all we have. Be ready.
>>>>> --
>>>>> To unsubscribe from this list: send the line "unsubscribe
>>>>> linux-wireless" in
>>>>> the body of a message to [email protected]
>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>
>>>>
>>>
>>> at barnes and noble, and I see this has fired off again. will see if I
>>> can reproduce and bisect.
>>
>> This problem goes way back, and the driver has had lots of fixes in the
>> last few months, so I'm not sure if bisecting is going to
>> do you any good.
>>
>> Thanks,
>> Ben
>
> The warnings have been around since you added the check for the
> problem, right? I remember initially it was a WARN_ON, and I'd get a
> steady flood of backtraces, and then it was switched to a
> WARN_ON_ONCE. I see these on every platform I have (x86_64, IXP425
> and AR71xx) with AR9002 and AR9003.

I don't think I added the original check, but either way, it's
an old problem and bisecting it is unlikely to help.

I can't believe that the Atheros guys really are unable reproduce
this, but I can believe that it might be very difficult to
actually understand and fix.

At least in my testing, I see it quite often, but it doesn't
seem to cause any serious harm. We do occasionally see crashes,
especially on module unload for a heavily utilized system, or
one that is constantly trying and failing to associate,
so it could be related to this.

Also, my patches to decrease scan and work_work related channel changes
made this harder to hit for our test cases.

Thanks,
Ben

--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com


2011-03-08 19:45:03

by Brian Prodoehl

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On Tue, Mar 8, 2011 at 2:27 PM, Ben Greear <[email protected]> wrote:
> On 03/08/2011 10:49 AM, Justin P. Mattock wrote:
>>
>> On 03/07/2011 07:22 AM, Mohammed Shafi wrote:
>>>
>>> On Mon, Mar 7, 2011 at 8:42 PM, John W.
>>> Linville<[email protected]> wrote:
>>>>
>>>> On Sun, Mar 06, 2011 at 12:47:05AM -0800, Justin Mattock wrote:
>>>>
>>>>> full dmesg here:
>>>>> http://fpaste.org/5JQp/
>>>>> let me know if I need to supply any info(also I can try a bisect, but
>>>>> am in the middle of changing residencies, so it might not be right
>>>>> away)
>>>>
>>>> One of the Atheros guys suggested that you change a DMA timeout value.
>>>> Did you try that?
>>>
>>> John it looks like increasing the timeout also does not seems to help.
>>> A user reported this issue in ath9k developer list and he told that
>>> increasing the timeout did not fix this issue.
>>>
>>>>
>>>> John
>>>> --
>>>> John W. Linville Someday the world will need a hero, and you
>>>> [email protected] might be all we have. Be ready.
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe
>>>> linux-wireless" in
>>>> the body of a message to [email protected]
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>
>>>
>>
>> at barnes and noble, and I see this has fired off again. will see if I
>> can reproduce and bisect.
>
> This problem goes way back, and the driver has had lots of fixes in the
> last few months, so I'm not sure if bisecting is going to
> do you any good.
>
> Thanks,
> Ben

The warnings have been around since you added the check for the
problem, right? I remember initially it was a WARN_ON, and I'd get a
steady flood of backtraces, and then it was switched to a
WARN_ON_ONCE. I see these on every platform I have (x86_64, IXP425
and AR71xx) with AR9002 and AR9003.

-Brian

2011-03-08 21:04:05

by Justin P. Mattock

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On 03/08/2011 11:59 AM, Ben Greear wrote:
> On 03/08/2011 11:45 AM, Brian Prodoehl wrote:
>> On Tue, Mar 8, 2011 at 2:27 PM, Ben Greear<[email protected]>
>> wrote:
>>> On 03/08/2011 10:49 AM, Justin P. Mattock wrote:
>>>>
>>>> On 03/07/2011 07:22 AM, Mohammed Shafi wrote:
>>>>>
>>>>> On Mon, Mar 7, 2011 at 8:42 PM, John W.
>>>>> Linville<[email protected]> wrote:
>>>>>>
>>>>>> On Sun, Mar 06, 2011 at 12:47:05AM -0800, Justin Mattock wrote:
>>>>>>
>>>>>>> full dmesg here:
>>>>>>> http://fpaste.org/5JQp/
>>>>>>> let me know if I need to supply any info(also I can try a bisect,
>>>>>>> but
>>>>>>> am in the middle of changing residencies, so it might not be right
>>>>>>> away)
>>>>>>
>>>>>> One of the Atheros guys suggested that you change a DMA timeout
>>>>>> value.
>>>>>> Did you try that?
>>>>>
>>>>> John it looks like increasing the timeout also does not seems to help.
>>>>> A user reported this issue in ath9k developer list and he told that
>>>>> increasing the timeout did not fix this issue.
>>>>>
>>>>>>
>>>>>> John
>>>>>> --
>>>>>> John W. Linville Someday the world will need a hero, and you
>>>>>> [email protected] might be all we have. Be ready.
>>>>>> --
>>>>>> To unsubscribe from this list: send the line "unsubscribe
>>>>>> linux-wireless" in
>>>>>> the body of a message to [email protected]
>>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>>
>>>>>
>>>>
>>>> at barnes and noble, and I see this has fired off again. will see if I
>>>> can reproduce and bisect.
>>>
>>> This problem goes way back, and the driver has had lots of fixes in the
>>> last few months, so I'm not sure if bisecting is going to
>>> do you any good.
>>>
>>> Thanks,
>>> Ben
>>
>> The warnings have been around since you added the check for the
>> problem, right? I remember initially it was a WARN_ON, and I'd get a
>> steady flood of backtraces, and then it was switched to a
>> WARN_ON_ONCE. I see these on every platform I have (x86_64, IXP425
>> and AR71xx) with AR9002 and AR9003.
>
> I don't think I added the original check, but either way, it's
> an old problem and bisecting it is unlikely to help.
>
> I can't believe that the Atheros guys really are unable reproduce
> this, but I can believe that it might be very difficult to
> actually understand and fix.
>
> At least in my testing, I see it quite often, but it doesn't
> seem to cause any serious harm. We do occasionally see crashes,
> especially on module unload for a heavily utilized system, or
> one that is constantly trying and failing to associate,
> so it could be related to this.
>
> Also, my patches to decrease scan and work_work related channel changes
> made this harder to hit for our test cases.
>
> Thanks,
> Ben
>


well I would do the bisect if I can easily reproduce this, but if this
has been back since 2.6.2* or the initial release of ath9k then doing
the bisect wont work.

as for the warning message itself, seems the system is fine after this
hits(just fires of on certain locations).

Justin P. Mattock

2011-03-06 08:47:09

by Justin P. Mattock

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On Thu, Mar 3, 2011 at 5:59 AM, John W. Linville <[email protected]> wrote:
> On Wed, Mar 02, 2011 at 09:47:43PM -0800, Justin Mattock wrote:
>> not sure what this is..(below)
>>
>>
>> [ ? 33.951046] CE: hpet increased min_delta_ns to 20113 nsec
>> [ ? 35.567319] EXT4-fs (sda3): re-mounted. Opts:
>> errors=panic,user_xattr,debug,acl,commit=600
>> [ ? 36.350144] wlan0: authenticate with 00:0b:86:32:f8:60 (try 1)
>> [ ? 36.352284] wlan0: authenticated
>> [ ? 36.352396] wlan0: associate with 00:0b:86:32:f8:60 (try 1)
>> [ ? 36.356854] wlan0: RX AssocResp from 00:0b:86:32:f8:60 (capab=0x421
>> status=0 aid=2)
>> [ ? 36.356862] wlan0: associated
>> [ ? 41.370318] ath: DMA failed to stop in 10 ms AR_CR=0x00000024
>> AR_DIAG_SW=0x42000020
>> [ ? 41.370324] ath: Could not stop RX, we could be confusing the DMA
>> engine when we start RX up
>> [ ? 41.370328] ------------[ cut here ]------------
>> [ ? 41.370345] WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536
>> ath_stoprecv+0xc8/0xda [ath9k]()
>> [ ? 41.370349] Hardware name: MacBookPro2,2
>> [ ? 41.370351] Modules linked in: hidp xfrm4_mode_transport xcbc
>> rmd160 sha512_generic rfcomm sco bnep l2cap ipt_REJECT xt_tcpudp
>> ipt_LOG iptable_nat nf_nat xt_state nf_conntrack_ftp nf_conntrack_ipv4
>> nf_conntrack nf_defrag_ipv4 iptable_filter ip_tables x_tables btusb
>> bluetooth evdev psmouse thermal fan container button ac battery video
>> ath9k ath9k_common ath9k_hw ath ttm drm aes_x86_64 lzo zlib ipcomp
>> xfrm_ipcomp crypto_null sha256_generic cbc des_generic cast5 blowfish
>> serpent camellia twofish_generic twofish_x86_64 twofish_common ctr ah4
>> esp4 authenc firewire_ohci firewire_core uhci_hcd ehci_hcd coretemp
>> acpi_cpufreq processor mperf appletouch applesmc
>> [ ? 41.370430] Pid: 766, comm: kworker/u:4 Not tainted
>> 2.6.38-rc6-00116-g2821f46 #5
>> [ ? 41.370434] Call Trace:
>> [ ? 41.370444] ?[<ffffffff810612c0>] ? warn_slowpath_common+0x80/0x98
>> [ ? 41.370450] ?[<ffffffff810612ed>] ? warn_slowpath_null+0x15/0x17
>> [ ? 41.370458] ?[<ffffffffa01c6438>] ? ath_stoprecv+0xc8/0xda [ath9k]
>> [ ? 41.370467] ?[<ffffffffa01c3a62>] ? ath_set_channel+0xb0/0x217 [ath9k]
>> [ ? 41.370475] ?[<ffffffffa01c3f89>] ? ath9k_config+0x3c0/0x4c3 [ath9k]
>> [ ? 41.370482] ?[<ffffffff8140fe8a>] ? ieee80211_hw_config+0x120/0x129
>> [ ? 41.370487] ?[<ffffffff81413902>] ? ieee80211_scan_work+0x2f8/0x496
>> [ ? 41.370495] ?[<ffffffffa01c7934>] ?
>> ath_tx_complete_poll_work+0xf3/0x102 [ath9k]
>> [ ? 41.370501] ?[<ffffffff8141360a>] ? ieee80211_scan_work+0x0/0x496
>> [ ? 41.370506] ?[<ffffffff810769c7>] ? process_one_work+0x266/0x3d7
>> [ ? 41.370511] ?[<ffffffff81076e9f>] ? worker_thread+0x1d6/0x350
>> [ ? 41.370515] ?[<ffffffff81076cc9>] ? worker_thread+0x0/0x350
>> [ ? 41.370521] ?[<ffffffff8107bdcf>] ? kthread+0x7d/0x85
>> [ ? 41.370528] ?[<ffffffff8102e064>] ? kernel_thread_helper+0x4/0x10
>> [ ? 41.370533] ?[<ffffffff8107bd52>] ? kthread+0x0/0x85
>> [ ? 41.370537] ?[<ffffffff8102e060>] ? kernel_thread_helper+0x0/0x10
>> [ ? 41.370541] ---[ end trace 062f507148a6fa8e ]---
>>
>>
>> from what I remember I was at a local college(caltech) trying to
>> connect to their public wifi
>> in the public area. with no luck, then this popped up.
>> full dmesg here:
>>
>> http://fpaste.org/SKU4/
>
> In ath_stoprecv:
>
> ? ? ? ?if (!(ah->ah_flags & AH_UNPLUGGED) &&
> ? ? ? ? ? ?unlikely(!stopped)) {
> ? ? ? ? ? ? ? ?ath_err(ath9k_hw_common(sc->sc_ah),
> ? ? ? ? ? ? ? ? ? ? ? ?"Could not stop RX, we could be "
> ? ? ? ? ? ? ? ? ? ? ? ?"confusing the DMA engine when we start RX up\n");
> ? ? ? ? ? ? ? ?ATH_DBG_WARN_ON_ONCE(!stopped);
> ? ? ? ?}
>
> The Atheros guys will have to comment.
>
> John
> --
> John W. Linville ? ? ? ? ? ? ? ?Someday the world will need a hero, and you
> [email protected] ? ? ? ? ? ? ? ? ?might be all we have. ?Be ready.
>

well even at home this seems to be firing off. was watching movies,music, etc..

[21471.152404] ------------[ cut here ]------------
[21471.152426] WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536
ath_stoprecv+0xc8/0xda [ath9k]()
[21471.152429] Hardware name: MacBookPro2,2
[21471.152431] Modules linked in: hidp xfrm4_mode_transport xcbc
rmd160 sha512_generic rfcomm sco bnep l2cap ipt_REJECT xt_tcpudp
ipt_LOG iptable_nat nf_nat xt_state nf_conntrack_ftp nf_conntrack_ipv4
nf_conntrack nf_defrag_ipv4 iptable_filter ip_tables x_tables btusb
bluetooth evdev psmouse thermal fan container button ac battery video
ath9k ath9k_common ath9k_hw ath ttm drm aes_x86_64 lzo zlib ipcomp
xfrm_ipcomp crypto_null sha256_generic cbc des_generic cast5 blowfish
serpent camellia twofish_generic twofish_x86_64 twofish_common ctr ah4
esp4 authenc firewire_ohci firewire_core uhci_hcd ehci_hcd coretemp
acpi_cpufreq processor mperf appletouch applesmc
[21471.152492] Pid: 4637, comm: kworker/u:2 Not tainted
2.6.38-rc7-00143-gd1b152c #7
[21471.152495] Call Trace:
[21471.152504] [<ffffffff810612c0>] ? warn_slowpath_common+0x80/0x98
[21471.152508] [<ffffffff810612ed>] ? warn_slowpath_null+0x15/0x17
[21471.152514] [<ffffffffa01c6438>] ? ath_stoprecv+0xc8/0xda [ath9k]
[21471.152520] [<ffffffffa01c3a62>] ? ath_set_channel+0xb0/0x217 [ath9k]
[21471.152526] [<ffffffffa01c3f89>] ? ath9k_config+0x3c0/0x4c3 [ath9k]
[21471.152532] [<ffffffff814101fe>] ? ieee80211_hw_config+0x120/0x129
[21471.152536] [<ffffffff81413c76>] ? ieee80211_scan_work+0x2f8/0x496
[21471.152541] [<ffffffff8141dccc>] ? ieee80211_iface_work+0x28d/0x2a6
[21471.152547] [<ffffffffa01c7934>] ?
ath_tx_complete_poll_work+0xf3/0x102 [ath9k]
[21471.152550] [<ffffffff8141397e>] ? ieee80211_scan_work+0x0/0x496
[21471.152555] [<ffffffff8107697f>] ? process_one_work+0x266/0x3d7
[21471.152558] [<ffffffff81076e57>] ? worker_thread+0x1d6/0x350
[21471.152561] [<ffffffff81076c81>] ? worker_thread+0x0/0x350
[21471.152566] [<ffffffff8107bd87>] ? kthread+0x7d/0x85
[21471.152572] [<ffffffff8102e064>] ? kernel_thread_helper+0x4/0x10
[21471.152575] [<ffffffff8107bd0a>] ? kthread+0x0/0x85
[21471.152578] [<ffffffff8102e060>] ? kernel_thread_helper+0x0/0x10
[21471.152581] ---[ end trace 11eeb73d205c9b43 ]---

full dmesg here:
http://fpaste.org/5JQp/
let me know if I need to supply any info(also I can try a bisect, but
am in the middle of changing residencies, so it might not be right
away)


--
Justin P. Mattock

2011-03-04 10:06:22

by Mohammed Shafi

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On Fri, Mar 4, 2011 at 6:25 AM, Justin Mattock <[email protected]> wrote:
> On Thu, Mar 3, 2011 at 5:59 AM, John W. Linville <[email protected]> wrote:
>> On Wed, Mar 02, 2011 at 09:47:43PM -0800, Justin Mattock wrote:
>>> not sure what this is..(below)
>>>
>>>
>>> [ ? 33.951046] CE: hpet increased min_delta_ns to 20113 nsec
>>> [ ? 35.567319] EXT4-fs (sda3): re-mounted. Opts:
>>> errors=panic,user_xattr,debug,acl,commit=600
>>> [ ? 36.350144] wlan0: authenticate with 00:0b:86:32:f8:60 (try 1)
>>> [ ? 36.352284] wlan0: authenticated
>>> [ ? 36.352396] wlan0: associate with 00:0b:86:32:f8:60 (try 1)
>>> [ ? 36.356854] wlan0: RX AssocResp from 00:0b:86:32:f8:60 (capab=0x421
>>> status=0 aid=2)
>>> [ ? 36.356862] wlan0: associated
>>> [ ? 41.370318] ath: DMA failed to stop in 10 ms AR_CR=0x00000024
>>> AR_DIAG_SW=0x42000020
>>> [ ? 41.370324] ath: Could not stop RX, we could be confusing the DMA
>>> engine when we start RX up
>>> [ ? 41.370328] ------------[ cut here ]------------
>>> [ ? 41.370345] WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536
>>> ath_stoprecv+0xc8/0xda [ath9k]()
>>> [ ? 41.370349] Hardware name: MacBookPro2,2
>>> [ ? 41.370351] Modules linked in: hidp xfrm4_mode_transport xcbc
>>> rmd160 sha512_generic rfcomm sco bnep l2cap ipt_REJECT xt_tcpudp
>>> ipt_LOG iptable_nat nf_nat xt_state nf_conntrack_ftp nf_conntrack_ipv4
>>> nf_conntrack nf_defrag_ipv4 iptable_filter ip_tables x_tables btusb
>>> bluetooth evdev psmouse thermal fan container button ac battery video
>>> ath9k ath9k_common ath9k_hw ath ttm drm aes_x86_64 lzo zlib ipcomp
>>> xfrm_ipcomp crypto_null sha256_generic cbc des_generic cast5 blowfish
>>> serpent camellia twofish_generic twofish_x86_64 twofish_common ctr ah4
>>> esp4 authenc firewire_ohci firewire_core uhci_hcd ehci_hcd coretemp
>>> acpi_cpufreq processor mperf appletouch applesmc
>>> [ ? 41.370430] Pid: 766, comm: kworker/u:4 Not tainted
>>> 2.6.38-rc6-00116-g2821f46 #5
>>> [ ? 41.370434] Call Trace:
>>> [ ? 41.370444] ?[<ffffffff810612c0>] ? warn_slowpath_common+0x80/0x98
>>> [ ? 41.370450] ?[<ffffffff810612ed>] ? warn_slowpath_null+0x15/0x17
>>> [ ? 41.370458] ?[<ffffffffa01c6438>] ? ath_stoprecv+0xc8/0xda [ath9k]
>>> [ ? 41.370467] ?[<ffffffffa01c3a62>] ? ath_set_channel+0xb0/0x217 [ath9k]
>>> [ ? 41.370475] ?[<ffffffffa01c3f89>] ? ath9k_config+0x3c0/0x4c3 [ath9k]
>>> [ ? 41.370482] ?[<ffffffff8140fe8a>] ? ieee80211_hw_config+0x120/0x129
>>> [ ? 41.370487] ?[<ffffffff81413902>] ? ieee80211_scan_work+0x2f8/0x496
>>> [ ? 41.370495] ?[<ffffffffa01c7934>] ?
>>> ath_tx_complete_poll_work+0xf3/0x102 [ath9k]
>>> [ ? 41.370501] ?[<ffffffff8141360a>] ? ieee80211_scan_work+0x0/0x496
>>> [ ? 41.370506] ?[<ffffffff810769c7>] ? process_one_work+0x266/0x3d7
>>> [ ? 41.370511] ?[<ffffffff81076e9f>] ? worker_thread+0x1d6/0x350
>>> [ ? 41.370515] ?[<ffffffff81076cc9>] ? worker_thread+0x0/0x350
>>> [ ? 41.370521] ?[<ffffffff8107bdcf>] ? kthread+0x7d/0x85
>>> [ ? 41.370528] ?[<ffffffff8102e064>] ? kernel_thread_helper+0x4/0x10
>>> [ ? 41.370533] ?[<ffffffff8107bd52>] ? kthread+0x0/0x85
>>> [ ? 41.370537] ?[<ffffffff8102e060>] ? kernel_thread_helper+0x0/0x10
>>> [ ? 41.370541] ---[ end trace 062f507148a6fa8e ]---
>>>
>>>
>>> from what I remember I was at a local college(caltech) trying to
>>> connect to their public wifi
>>> in the public area. with no luck, then this popped up.
>>> full dmesg here:
>>>
>>> http://fpaste.org/SKU4/
>>
>> In ath_stoprecv:
>>
>> ? ? ? ?if (!(ah->ah_flags & AH_UNPLUGGED) &&
>> ? ? ? ? ? ?unlikely(!stopped)) {
>> ? ? ? ? ? ? ? ?ath_err(ath9k_hw_common(sc->sc_ah),
>> ? ? ? ? ? ? ? ? ? ? ? ?"Could not stop RX, we could be "
>> ? ? ? ? ? ? ? ? ? ? ? ?"confusing the DMA engine when we start RX up\n");
>> ? ? ? ? ? ? ? ?ATH_DBG_WARN_ON_ONCE(!stopped);
>> ? ? ? ?}
>>
>> The Atheros guys will have to comment.
>>
>> John
>> --
>> John W. Linville ? ? ? ? ? ? ? ?Someday the world will need a hero, and you
>> [email protected] ? ? ? ? ? ? ? ? ?might be all we have. ?Be ready.
>>
>
> cool, thanks for the reply.
> yeah this is strange, seems to have happened in that location and not others.
> (if I have time wouldn't mind testing out other kernel versions and
> maybe a bisect to
> grab this)

Hi,
Can you please try the obvious way of increasing the timeout for
stopping the DMA ?
in mac.c

148 #define ATH9K_TX_STOP_DMA_TIMEOUT 4000 /* usec */
increase it to 10000 usec

and
781#define AH_RX_STOP_DMA_TIMEOUT 10000 /* usec */
increase it to 20,000 usec
>
> --
> Justin P. Mattock
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>

2011-03-09 22:10:03

by Justin P. Mattock

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On 03/08/2011 05:03 PM, Felix Fietkau wrote:
> On 2011-03-08 10:03 PM, Justin P. Mattock wrote:
>> On 03/08/2011 11:59 AM, Ben Greear wrote:
>>> On 03/08/2011 11:45 AM, Brian Prodoehl wrote:
>>>> On Tue, Mar 8, 2011 at 2:27 PM, Ben Greear<[email protected]>
>>>> wrote:
>>>>> On 03/08/2011 10:49 AM, Justin P. Mattock wrote:
>>>>>>
>>>>>> On 03/07/2011 07:22 AM, Mohammed Shafi wrote:
>>>>>>>
>>>>>>> On Mon, Mar 7, 2011 at 8:42 PM, John W.
>>>>>>> Linville<[email protected]> wrote:
>>>>>>>>
>>>>>>>> On Sun, Mar 06, 2011 at 12:47:05AM -0800, Justin Mattock wrote:
>>>>>>>>
>>>>>>>>> full dmesg here:
>>>>>>>>> http://fpaste.org/5JQp/
>>>>>>>>> let me know if I need to supply any info(also I can try a bisect,
>>>>>>>>> but
>>>>>>>>> am in the middle of changing residencies, so it might not be right
>>>>>>>>> away)
>>>>>>>>
>>>>>>>> One of the Atheros guys suggested that you change a DMA timeout
>>>>>>>> value.
>>>>>>>> Did you try that?
>>>>>>>
>>>>>>> John it looks like increasing the timeout also does not seems to help.
>>>>>>> A user reported this issue in ath9k developer list and he told that
>>>>>>> increasing the timeout did not fix this issue.
>>>>>>>
>>>>>>>>
>>>>>>>> John
>>>>>>>> --
>>>>>>>> John W. Linville Someday the world will need a hero, and you
>>>>>>>> [email protected] might be all we have. Be ready.
>>>>>>>> --
>>>>>>>> To unsubscribe from this list: send the line "unsubscribe
>>>>>>>> linux-wireless" in
>>>>>>>> the body of a message to [email protected]
>>>>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>> at barnes and noble, and I see this has fired off again. will see if I
>>>>>> can reproduce and bisect.
>>>>>
>>>>> This problem goes way back, and the driver has had lots of fixes in the
>>>>> last few months, so I'm not sure if bisecting is going to
>>>>> do you any good.
>>>>>
>>>>> Thanks,
>>>>> Ben
>>>>
>>>> The warnings have been around since you added the check for the
>>>> problem, right? I remember initially it was a WARN_ON, and I'd get a
>>>> steady flood of backtraces, and then it was switched to a
>>>> WARN_ON_ONCE. I see these on every platform I have (x86_64, IXP425
>>>> and AR71xx) with AR9002 and AR9003.
>>>
>>> I don't think I added the original check, but either way, it's
>>> an old problem and bisecting it is unlikely to help.
>>>
>>> I can't believe that the Atheros guys really are unable reproduce
>>> this, but I can believe that it might be very difficult to
>>> actually understand and fix.
>>>
>>> At least in my testing, I see it quite often, but it doesn't
>>> seem to cause any serious harm. We do occasionally see crashes,
>>> especially on module unload for a heavily utilized system, or
>>> one that is constantly trying and failing to associate,
>>> so it could be related to this.
>>>
>>> Also, my patches to decrease scan and work_work related channel changes
>>> made this harder to hit for our test cases.
>>>
>>> Thanks,
>>> Ben
>>>
>>
>>
>> well I would do the bisect if I can easily reproduce this, but if this
>> has been back since 2.6.2* or the initial release of ath9k then doing
>> the bisect wont work.
>>
>> as for the warning message itself, seems the system is fine after this
>> hits(just fires of on certain locations).
>>
>> Justin P. Mattock
> Please try this patch (posted to linux-wireless@) and see if it fixes
> this issue in your tests.
>
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> index cb559e3..a9c3f46 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -413,9 +413,7 @@ u32 ath_calcrxfilter(struct ath_softc *sc)
> * mode interface or when in monitor mode. AP mode does not need this
> * since it receives all in-BSS frames anyway.
> */
> - if (((sc->sc_ah->opmode != NL80211_IFTYPE_AP)&&
> - (sc->rx.rxfilter& FIF_PROMISC_IN_BSS)) ||
> - (sc->sc_ah->is_monitoring))
> + if (sc->sc_ah->is_monitoring)
> rfilt |= ATH9K_RX_FILTER_PROM;
>
> if (sc->rx.rxfilter& FIF_CONTROL)
>
>


patch applied: here is what I am seeing:

[ 1532.142246] FIREWALL:INPUT IN=wlan0 OUT=
MAC=01:00:5e:00:00:01:00:1e:e5:7a:64:79:08:00 SRC=192.168.180.1
DST=224.0.0.1 LEN=28 TOS=0x00 PREC=0x00 TTL=1 ID=0 DF PROTO=2
[ 1534.089408] FIREWALL:INPUT IN=wlan0 OUT=
MAC=ff:ff:ff:ff:ff:ff:00:18:de:9c:0f:ef:08:00 SRC=192.168.180.213
DST=192.168.180.255 LEN=229 TOS=0x00 PREC=0x00 TTL=128 ID=10897
PROTO=UDP SPT=138 DPT=138 LEN=209
[ 1575.870714] FIREWALL:INPUT IN=wlan0 OUT=
MAC=ff:ff:ff:ff:ff:ff:40:a6:d9:b8:58:7c:08:00 SRC=0.0.0.0
DST=255.255.255.255 LEN=328 TOS=0x00 PREC=0x00 TTL=255 ID=64945
PROTO=UDP SPT=68 DPT=67 LEN=308
[ 1579.323946] ath: Timeout while waiting for nf to load:
AR_PHY_AGC_CONTROL=0x41d1a
[ 1658.504988] FIREWALL:INPUT IN=wlan0 OUT=
MAC=01:00:5e:00:00:01:00:1e:e5:7a:64:79:08:00 SRC=192.168.180.1
DST=224.0.0.1 LEN=28 TOS=0x00 PREC=0x00 TTL=1 ID=0 DF PROTO=2
[ 1681.342000] FIREWALL:INPUT IN=wlan0 OUT=
MAC=ff:ff:ff:ff:ff:ff:00:c0:a8:db:bd:af:08:00 SRC=192.168.180.54
DST=192.168.180.255 LEN=240 TOS=0x00 PREC=0x00 TTL=64 ID=19778 PROTO=UDP
SPT=138 DPT=138 LEN=220

full dmesg is here:
http://fpaste.org/jwTK/

Justin P. Mattock



2011-03-03 14:00:41

by John W. Linville

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On Wed, Mar 02, 2011 at 09:47:43PM -0800, Justin Mattock wrote:
> not sure what this is..(below)
>
>
> [ 33.951046] CE: hpet increased min_delta_ns to 20113 nsec
> [ 35.567319] EXT4-fs (sda3): re-mounted. Opts:
> errors=panic,user_xattr,debug,acl,commit=600
> [ 36.350144] wlan0: authenticate with 00:0b:86:32:f8:60 (try 1)
> [ 36.352284] wlan0: authenticated
> [ 36.352396] wlan0: associate with 00:0b:86:32:f8:60 (try 1)
> [ 36.356854] wlan0: RX AssocResp from 00:0b:86:32:f8:60 (capab=0x421
> status=0 aid=2)
> [ 36.356862] wlan0: associated
> [ 41.370318] ath: DMA failed to stop in 10 ms AR_CR=0x00000024
> AR_DIAG_SW=0x42000020
> [ 41.370324] ath: Could not stop RX, we could be confusing the DMA
> engine when we start RX up
> [ 41.370328] ------------[ cut here ]------------
> [ 41.370345] WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536
> ath_stoprecv+0xc8/0xda [ath9k]()
> [ 41.370349] Hardware name: MacBookPro2,2
> [ 41.370351] Modules linked in: hidp xfrm4_mode_transport xcbc
> rmd160 sha512_generic rfcomm sco bnep l2cap ipt_REJECT xt_tcpudp
> ipt_LOG iptable_nat nf_nat xt_state nf_conntrack_ftp nf_conntrack_ipv4
> nf_conntrack nf_defrag_ipv4 iptable_filter ip_tables x_tables btusb
> bluetooth evdev psmouse thermal fan container button ac battery video
> ath9k ath9k_common ath9k_hw ath ttm drm aes_x86_64 lzo zlib ipcomp
> xfrm_ipcomp crypto_null sha256_generic cbc des_generic cast5 blowfish
> serpent camellia twofish_generic twofish_x86_64 twofish_common ctr ah4
> esp4 authenc firewire_ohci firewire_core uhci_hcd ehci_hcd coretemp
> acpi_cpufreq processor mperf appletouch applesmc
> [ 41.370430] Pid: 766, comm: kworker/u:4 Not tainted
> 2.6.38-rc6-00116-g2821f46 #5
> [ 41.370434] Call Trace:
> [ 41.370444] [<ffffffff810612c0>] ? warn_slowpath_common+0x80/0x98
> [ 41.370450] [<ffffffff810612ed>] ? warn_slowpath_null+0x15/0x17
> [ 41.370458] [<ffffffffa01c6438>] ? ath_stoprecv+0xc8/0xda [ath9k]
> [ 41.370467] [<ffffffffa01c3a62>] ? ath_set_channel+0xb0/0x217 [ath9k]
> [ 41.370475] [<ffffffffa01c3f89>] ? ath9k_config+0x3c0/0x4c3 [ath9k]
> [ 41.370482] [<ffffffff8140fe8a>] ? ieee80211_hw_config+0x120/0x129
> [ 41.370487] [<ffffffff81413902>] ? ieee80211_scan_work+0x2f8/0x496
> [ 41.370495] [<ffffffffa01c7934>] ?
> ath_tx_complete_poll_work+0xf3/0x102 [ath9k]
> [ 41.370501] [<ffffffff8141360a>] ? ieee80211_scan_work+0x0/0x496
> [ 41.370506] [<ffffffff810769c7>] ? process_one_work+0x266/0x3d7
> [ 41.370511] [<ffffffff81076e9f>] ? worker_thread+0x1d6/0x350
> [ 41.370515] [<ffffffff81076cc9>] ? worker_thread+0x0/0x350
> [ 41.370521] [<ffffffff8107bdcf>] ? kthread+0x7d/0x85
> [ 41.370528] [<ffffffff8102e064>] ? kernel_thread_helper+0x4/0x10
> [ 41.370533] [<ffffffff8107bd52>] ? kthread+0x0/0x85
> [ 41.370537] [<ffffffff8102e060>] ? kernel_thread_helper+0x0/0x10
> [ 41.370541] ---[ end trace 062f507148a6fa8e ]---
>
>
> from what I remember I was at a local college(caltech) trying to
> connect to their public wifi
> in the public area. with no luck, then this popped up.
> full dmesg here:
>
> http://fpaste.org/SKU4/

In ath_stoprecv:

if (!(ah->ah_flags & AH_UNPLUGGED) &&
unlikely(!stopped)) {
ath_err(ath9k_hw_common(sc->sc_ah),
"Could not stop RX, we could be "
"confusing the DMA engine when we start RX up\n");
ATH_DBG_WARN_ON_ONCE(!stopped);
}

The Atheros guys will have to comment.

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2011-03-09 01:03:31

by Felix Fietkau

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On 2011-03-08 10:03 PM, Justin P. Mattock wrote:
> On 03/08/2011 11:59 AM, Ben Greear wrote:
>> On 03/08/2011 11:45 AM, Brian Prodoehl wrote:
>>> On Tue, Mar 8, 2011 at 2:27 PM, Ben Greear<[email protected]>
>>> wrote:
>>>> On 03/08/2011 10:49 AM, Justin P. Mattock wrote:
>>>>>
>>>>> On 03/07/2011 07:22 AM, Mohammed Shafi wrote:
>>>>>>
>>>>>> On Mon, Mar 7, 2011 at 8:42 PM, John W.
>>>>>> Linville<[email protected]> wrote:
>>>>>>>
>>>>>>> On Sun, Mar 06, 2011 at 12:47:05AM -0800, Justin Mattock wrote:
>>>>>>>
>>>>>>>> full dmesg here:
>>>>>>>> http://fpaste.org/5JQp/
>>>>>>>> let me know if I need to supply any info(also I can try a bisect,
>>>>>>>> but
>>>>>>>> am in the middle of changing residencies, so it might not be right
>>>>>>>> away)
>>>>>>>
>>>>>>> One of the Atheros guys suggested that you change a DMA timeout
>>>>>>> value.
>>>>>>> Did you try that?
>>>>>>
>>>>>> John it looks like increasing the timeout also does not seems to help.
>>>>>> A user reported this issue in ath9k developer list and he told that
>>>>>> increasing the timeout did not fix this issue.
>>>>>>
>>>>>>>
>>>>>>> John
>>>>>>> --
>>>>>>> John W. Linville Someday the world will need a hero, and you
>>>>>>> [email protected] might be all we have. Be ready.
>>>>>>> --
>>>>>>> To unsubscribe from this list: send the line "unsubscribe
>>>>>>> linux-wireless" in
>>>>>>> the body of a message to [email protected]
>>>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>>>
>>>>>>
>>>>>
>>>>> at barnes and noble, and I see this has fired off again. will see if I
>>>>> can reproduce and bisect.
>>>>
>>>> This problem goes way back, and the driver has had lots of fixes in the
>>>> last few months, so I'm not sure if bisecting is going to
>>>> do you any good.
>>>>
>>>> Thanks,
>>>> Ben
>>>
>>> The warnings have been around since you added the check for the
>>> problem, right? I remember initially it was a WARN_ON, and I'd get a
>>> steady flood of backtraces, and then it was switched to a
>>> WARN_ON_ONCE. I see these on every platform I have (x86_64, IXP425
>>> and AR71xx) with AR9002 and AR9003.
>>
>> I don't think I added the original check, but either way, it's
>> an old problem and bisecting it is unlikely to help.
>>
>> I can't believe that the Atheros guys really are unable reproduce
>> this, but I can believe that it might be very difficult to
>> actually understand and fix.
>>
>> At least in my testing, I see it quite often, but it doesn't
>> seem to cause any serious harm. We do occasionally see crashes,
>> especially on module unload for a heavily utilized system, or
>> one that is constantly trying and failing to associate,
>> so it could be related to this.
>>
>> Also, my patches to decrease scan and work_work related channel changes
>> made this harder to hit for our test cases.
>>
>> Thanks,
>> Ben
>>
>
>
> well I would do the bisect if I can easily reproduce this, but if this
> has been back since 2.6.2* or the initial release of ath9k then doing
> the bisect wont work.
>
> as for the warning message itself, seems the system is fine after this
> hits(just fires of on certain locations).
>
> Justin P. Mattock
Please try this patch (posted to linux-wireless@) and see if it fixes
this issue in your tests.

diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
index cb559e3..a9c3f46 100644
--- a/drivers/net/wireless/ath/ath9k/recv.c
+++ b/drivers/net/wireless/ath/ath9k/recv.c
@@ -413,9 +413,7 @@ u32 ath_calcrxfilter(struct ath_softc *sc)
* mode interface or when in monitor mode. AP mode does not need this
* since it receives all in-BSS frames anyway.
*/
- if (((sc->sc_ah->opmode != NL80211_IFTYPE_AP) &&
- (sc->rx.rxfilter & FIF_PROMISC_IN_BSS)) ||
- (sc->sc_ah->is_monitoring))
+ if (sc->sc_ah->is_monitoring)
rfilt |= ATH9K_RX_FILTER_PROM;

if (sc->rx.rxfilter & FIF_CONTROL)


2011-03-08 19:28:14

by Ben Greear

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On 03/08/2011 10:49 AM, Justin P. Mattock wrote:
> On 03/07/2011 07:22 AM, Mohammed Shafi wrote:
>> On Mon, Mar 7, 2011 at 8:42 PM, John W.
>> Linville<[email protected]> wrote:
>>> On Sun, Mar 06, 2011 at 12:47:05AM -0800, Justin Mattock wrote:
>>>
>>>> full dmesg here:
>>>> http://fpaste.org/5JQp/
>>>> let me know if I need to supply any info(also I can try a bisect, but
>>>> am in the middle of changing residencies, so it might not be right
>>>> away)
>>>
>>> One of the Atheros guys suggested that you change a DMA timeout value.
>>> Did you try that?
>>
>> John it looks like increasing the timeout also does not seems to help.
>> A user reported this issue in ath9k developer list and he told that
>> increasing the timeout did not fix this issue.
>>
>>>
>>> John
>>> --
>>> John W. Linville Someday the world will need a hero, and you
>>> [email protected] might be all we have. Be ready.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe
>>> linux-wireless" in
>>> the body of a message to [email protected]
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>>
>
> at barnes and noble, and I see this has fired off again. will see if I
> can reproduce and bisect.

This problem goes way back, and the driver has had lots of fixes in the
last few months, so I'm not sure if bisecting is going to
do you any good.

Thanks,
Ben

>
> full dmesg:
>
> http://fpaste.org/6sIH/
>
> Justin P. Mattock
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com


2011-03-08 18:50:01

by Justin P. Mattock

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On 03/07/2011 07:22 AM, Mohammed Shafi wrote:
> On Mon, Mar 7, 2011 at 8:42 PM, John W. Linville<[email protected]> wrote:
>> On Sun, Mar 06, 2011 at 12:47:05AM -0800, Justin Mattock wrote:
>>
>>> full dmesg here:
>>> http://fpaste.org/5JQp/
>>> let me know if I need to supply any info(also I can try a bisect, but
>>> am in the middle of changing residencies, so it might not be right
>>> away)
>>
>> One of the Atheros guys suggested that you change a DMA timeout value.
>> Did you try that?
>
> John it looks like increasing the timeout also does not seems to help.
> A user reported this issue in ath9k developer list and he told that
> increasing the timeout did not fix this issue.
>
>>
>> John
>> --
>> John W. Linville Someday the world will need a hero, and you
>> [email protected] might be all we have. Be ready.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>

at barnes and noble, and I see this has fired off again. will see if I
can reproduce and bisect.

full dmesg:

http://fpaste.org/6sIH/

Justin P. Mattock

2011-03-07 15:22:12

by Mohammed Shafi

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On Mon, Mar 7, 2011 at 8:42 PM, John W. Linville <[email protected]> wrote:
> On Sun, Mar 06, 2011 at 12:47:05AM -0800, Justin Mattock wrote:
>
>> full dmesg here:
>> http://fpaste.org/5JQp/
>> let me know if I need to supply any info(also I can try a bisect, but
>> am in the middle of changing residencies, so it might not be right
>> away)
>
> One of the Atheros guys suggested that you change a DMA timeout value.
> Did you try that?

John it looks like increasing the timeout also does not seems to help.
A user reported this issue in ath9k developer list and he told that
increasing the timeout did not fix this issue.

>
> John
> --
> John W. Linville ? ? ? ? ? ? ? ?Someday the world will need a hero, and you
> [email protected] ? ? ? ? ? ? ? ? ?might be all we have. ?Be ready.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>

2011-03-07 15:15:47

by John W. Linville

[permalink] [raw]
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 ath_stoprecv+0xc8/0xda [ath9k]()

On Sun, Mar 06, 2011 at 12:47:05AM -0800, Justin Mattock wrote:

> full dmesg here:
> http://fpaste.org/5JQp/
> let me know if I need to supply any info(also I can try a bisect, but
> am in the middle of changing residencies, so it might not be right
> away)

One of the Atheros guys suggested that you change a DMA timeout value.
Did you try that?

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.