2010-10-22 13:00:34

by Rajkumar Manoharan

Subject: [RFC] mac80211: Fix ibss station got expired immediately

Station addition in ieee80211_ibss_rx_queued_mgmt is not updating
sta->last_rx which is causing station expiry in ieee80211_ibss_work
path. So sta addition and deletion happens repeatedly.

Signed-off-by: Rajkumar Manoharan <[email protected]>
---
net/mac80211/ibss.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index ff60c02..239c483 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -456,6 +456,7 @@ struct sta_info *ieee80211_ibss_add_sta(struct ieee80211_sub_if_data *sdata,
if (!sta)
return NULL;

+ sta->last_rx = jiffies;
set_sta_flags(sta, WLAN_STA_AUTHORIZED);

/* make sure mandatory rates are always added */
--
1.7.3.1

2010-10-22 16:52:27

by Luis R. Rodriguez

Subject: Re: [RFC] mac80211: Fix ibss station got expired immediately

On Fri, Oct 22, 2010 at 9:48 AM, Rajkumar Manoharan
<[email protected]> wrote:
>>On Fri, Oct 22, 2010 at 6:06 AM, Rajkumar Manoharan
>><[email protected]> wrote:
>>> Station addition in ieee80211_ibss_rx_queued_mgmt is not updating
>>> sta->last_rx which is causing station expiry in ieee80211_ibss_work
>>> path. So sta addition and deletion happens repeatedly.
>>>
>>> Signed-off-by: Rajkumar Manoharan <[email protected]>
>
>>stable fix?
>
>  >Luis
> yes. while sending the patch, i'll cc'd stable.

To get a fix propagated to stable you must add a

Cc: [email protected]

to your commit log right before your Signed-off-by.

Luis

2010-10-22 16:50:26

by Rajkumar Manoharan

Subject: RE: [RFC] mac80211: Fix ibss station got expired immediately

>On Fri, Oct 22, 2010 at 6:06 AM, Rajkumar Manoharan
><[email protected]> wrote:
>> Station addition in ieee80211_ibss_rx_queued_mgmt is not updating
>> sta->last_rx which is causing station expiry in ieee80211_ibss_work
>> path. So sta addition and deletion happens repeatedly.
>>
>> Signed-off-by: Rajkumar Manoharan <[email protected]>

>stable fix?

>Luis
yes. while sending the patch, i'll cc'd stable.

Thanks,
Rajkumar

2010-10-22 17:50:27

by Rajkumar Manoharan

Subject: RE: [RFC] mac80211: Fix ibss station got expired immediately

>On Fri, Oct 22, 2010 at 9:48 AM, Rajkumar Manoharan
><[email protected]> wrote:
>>>On Fri, Oct 22, 2010 at 6:06 AM, Rajkumar Manoharan
>>><[email protected]> wrote:
>>>> Station addition in ieee80211_ibss_rx_queued_mgmt is not updating
>>>> sta->last_rx which is causing station expiry in ieee80211_ibss_work
>>>> path. So sta addition and deletion happens repeatedly.
>>>>
>>>> Signed-off-by: Rajkumar Manoharan <[email protected]>
>>
>>>stable fix?
>>
>>>Luis
> >yes. while sending the patch, i'll cc'd stable.
>
>To get a fix propagated to stable you must adda
>
>Cc: [email protected]
>
>to your commit log right before your Signed-off-by.
>Luis

Yep. thats what i meant ;)

- Rajkumar

2010-10-22 13:15:07

by Luis R. Rodriguez

Subject: Re: [RFC] mac80211: Fix ibss station got expired immediately

On Fri, Oct 22, 2010 at 6:06 AM, Rajkumar Manoharan
<[email protected]> wrote:
> Station addition in ieee80211_ibss_rx_queued_mgmt is not updating
> sta->last_rx which is causing station expiry in ieee80211_ibss_work
> path. So sta addition and deletion happens repeatedly.
>
> Signed-off-by: Rajkumar Manoharan <[email protected]>

stable fix?

Luis

2010-10-22 19:14:59

by Luis R. Rodriguez

Subject: Re: [RFC] mac80211: Fix ibss station got expired immediately

On Fri, Oct 22, 2010 at 10:48 AM, Rajkumar Manoharan
<[email protected]> wrote:
>>On Fri, Oct 22, 2010 at 9:48 AM, Rajkumar Manoharan
>><[email protected]> wrote:
>>>>On Fri, Oct 22, 2010 at 6:06 AM, Rajkumar Manoharan
>>>><[email protected]> wrote:
>>>>> Station addition in ieee80211_ibss_rx_queued_mgmt is not updating
>>>>> sta->last_rx which is causing station expiry in ieee80211_ibss_work
>>>>> path. So sta addition and deletion happens repeatedly.
>>>>>
>>>>> Signed-off-by: Rajkumar Manoharan <[email protected]>
>>>
>>>>stable fix?
>>>
>>>>Luis
>> >yes. while sending the patch, i'll cc'd stable.
>>
>>To get a fix propagated to stable you must adda
>>
>>Cc: [email protected]
>>
>>to your commit log right before your Signed-off-by.
>>Luis
>
> Yep. thats what i meant ;)

Are you saying that you are going to resubmit this patch with the Cc:
[email protected] on the commit log message?

Luis