Hi,
I just compiled linux-next (next-20101207) which also includes
wireless-next-2.6 (master-2010-12-06) [1].
I have already reported on linux-wireless (short: l-w) ML that after
especially the merge of "AHB Bus support" patchset (see [2]) my ath5k
was not working as expected in daily use (also modinfo).
I am not sure if it is the driver but reverting the 9 commits in my
local linux-next GIT seemed to "stabilize" a bit the Internet
connection.
The patchset from Nick (see below) definitely helped to stabilize ath5k.
What means "daily use"?
Quassel IRC-client (around 20 channels), Iceweasel (Debian's answer to
firefox) with sometimes 20 tabs open and radio live-stream in VLC.
Here and there I have still audio-dropouts or when typing emails in
web-based email-service, it stalls when "stressing" with for example
parallelly creating a tarball (that's normally no huge workload) the
probability for audio-dropouts increases.
As I said I am not sure what is causing these hangs, it's ath5k
driver? Is it sth. else?
How to dig into it?
Unfortunately, modinfo does not list aliases with pci-id matching (I
have already reported to l-w ML, see below).
With reverting "AHB Bus support" patchset modinfo works as expected.
As a workaround I added ath5k to /etc/modules (see below), otherwise I
have to stop networking, unload + reload ath5k and start networking
again.
I also added an iw station dump (see below) and outputs of filtered
lspci and dmesg commands.
Not sure if this is helpful to mention, I use crda and wireless-regdb
(see below).
BTW, I have these two patches in addition to linux-next:
(+) OK mac80211-fix/mac80211-fix-a-compiler-warning.patch
(+) OK ath5k-fix/ath5k-Use-capabilities-information-for-the-number-of-TX-queues.patch
Any ideas/help appreciated, Thanks in advance.
Kind Regards,
- Sedat -
[1] http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git
[2] http://wireless.kernel.org/en/users/Drivers/ath5k
P.S.: Patchset from Nick Kossifidis
$ ls -l ath5k-fix/*-6-*
-rw-r--r-- 1 sd sd 3439 3. Dez 06:52
ath5k-fix/1-6-ath5k-Always-write-tx-powertable-on-hw.patch
-rw-r--r-- 1 sd sd 1725 3. Dez 06:51
ath5k-fix/2-6-ath5k-Always-free-tx-buffers-before-reset.patch
-rw-r--r-- 1 sd sd 2132 3. Dez 06:52
ath5k-fix/3-6-ath5k-Disable-ANI-during-reset.patch
-rw-r--r-- 1 sd sd 1360 3. Dez 06:52
ath5k-fix/4-6-ath5k-Fix-reporting-of-RX-dma-stop-failure.patch
-rw-r--r-- 1 sd sd 1735 3. Dez 06:52
ath5k-fix/5-6-ath5k-Update-version-string.patch
-rw-r--r-- 1 sd sd 1744 3. Dez 06:53
ath5k-fix/6-6-ath5k-Include-tx-ack-reporting-on-hw-flags.patch
# modinfo ath5k
filename:
/lib/modules/2.6.37-rc4-686/kernel/drivers/net/wireless/ath/ath5k/ath5k.ko
version: 0.6.0 (EXPERIMENTAL)
license: Dual BSD/GPL
description: Support for 5xxx series of Atheros 802.11 wireless LAN cards.
author: Nick Kossifidis
author: Jiri Slaby
srcversion: 49DBF0BE975A1F9917151F4
depends: mac80211,cfg80211,ath
vermagic: 2.6.37-rc4-686 SMP mod_unload modversions 686
parm: debug:uint
parm: nohwcrypt:Disable hardware encryption. (bool)
parm: all_channels:Expose all channels the device can use. (bool)
# grep ath5k /etc/modules
ath5k
# iw wlan0 station dump
Station 00:04:0e:e4:00:3d (on wlan0)
inactive time: 48 ms
rx bytes: 60460696
rx packets: 95331
tx bytes: 5034456
tx packets: 50165
signal: -50 dBm
tx bitrate: 36.0 MBit/s
# lspci -nnvv | grep -i ath
02:02.0 Ethernet controller [0200]: Atheros Communications Inc. AR5212
802.11abg NIC [168c:1014] (rev 01)
Kernel driver in use: ath5k
# dmesg | egrep -i 'ath|80211|wlan'
[ 14.444118] cfg80211: Calling CRDA to update world regulatory domain
[ 14.725757] ath5k 0000:02:02.0: PCI INT A -> Link[LNKC] -> GSI 11
(level, low) -> IRQ 11
[ 14.736940] ath5k 0000:02:02.0: registered as 'phy0'
[ 15.036636] ath: EEPROM regdomain: 0x61
[ 15.036640] ath: EEPROM indicates we should expect a direct regpair map
[ 15.036646] ath: Country alpha2 being used: 00
[ 15.036648] ath: Regpair used: 0x61
[ 15.665415] cfg80211: World regulatory domain updated:
[ 15.676274] cfg80211: (start_freq - end_freq @ bandwidth),
(max_antenna_gain, max_eirp)
[ 15.687303] cfg80211: (2402000 KHz - 2472000 KHz @ 40000 KHz),
(300 mBi, 2000 mBm)
[ 15.698413] cfg80211: (2457000 KHz - 2482000 KHz @ 20000 KHz),
(300 mBi, 2000 mBm)
[ 15.709461] cfg80211: (2474000 KHz - 2494000 KHz @ 20000 KHz),
(300 mBi, 2000 mBm)
[ 15.720489] cfg80211: (5170000 KHz - 5250000 KHz @ 40000 KHz),
(300 mBi, 2000 mBm)
[ 15.731526] cfg80211: (5735000 KHz - 5835000 KHz @ 40000 KHz),
(300 mBi, 2000 mBm)
[ 15.754490] ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
[ 15.755482] Registered led device: ath5k-phy0::rx
[ 15.755516] Registered led device: ath5k-phy0::tx
[ 15.755529] ath5k phy0: Atheros AR5212 chip found (MAC: 0x56, PHY: 0x41)
[ 15.766686] ath5k phy0: RF5111 5GHz radio found (0x17)
[ 15.777870] ath5k phy0: RF2111 2GHz radio found (0x23)
[ 17.374647] ADDRCONF(NETDEV_UP): wlan0: link is not ready
[ 22.596104] wlan0: authenticate with 00:04:0e:e4:00:3d (try 1)
[ 22.597531] wlan0: authenticated
[ 22.597549] wlan0: associate with 00:04:0e:e4:00:3d (try 1)
[ 22.602095] wlan0: RX AssocResp from 00:04:0e:e4:00:3d (capab=0x411
status=0 aid=1)
[ 22.602100] wlan0: associated
[ 22.602986] ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
[ 33.312034] wlan0: no IPv6 routers present
[ 215.317105] cfg80211: Calling CRDA to update world regulatory domain
[ 215.346333] cfg80211: World regulatory domain updated:
[ 215.346341] cfg80211: (start_freq - end_freq @ bandwidth),
(max_antenna_gain, max_eirp)
[ 215.346346] cfg80211: (2402000 KHz - 2472000 KHz @ 40000 KHz),
(300 mBi, 2000 mBm)
[ 215.346350] cfg80211: (2457000 KHz - 2482000 KHz @ 20000 KHz),
(300 mBi, 2000 mBm)
[ 215.346354] cfg80211: (2474000 KHz - 2494000 KHz @ 20000 KHz),
(300 mBi, 2000 mBm)
[ 215.346358] cfg80211: (5170000 KHz - 5250000 KHz @ 40000 KHz),
(300 mBi, 2000 mBm)
[ 215.346362] cfg80211: (5735000 KHz - 5835000 KHz @ 40000 KHz),
(300 mBi, 2000 mBm)
[ 219.627199] wlan0: authenticate with 00:04:0e:e4:00:3d (try 1)
[ 219.629321] wlan0: authenticated
[ 219.629365] wlan0: associate with 00:04:0e:e4:00:3d (try 1)
[ 219.635825] wlan0: RX AssocResp from 00:04:0e:e4:00:3d (capab=0x411
status=0 aid=1)
[ 219.635836] wlan0: associated
# dpkg -l | egrep 'crda|wireless-regdb' | cut -c-80
ii crda 1.1.1-0~svnr1515.3
ii wireless-regdb 2010.11.24-1
On Tue, Dec 7, 2010 at 4:59 PM, John W. Linville <[email protected]> wrote:
> On Tue, Dec 07, 2010 at 04:57:08PM +0100, Sedat Dilek wrote:
>> On Tue, Dec 7, 2010 at 3:26 PM, John W. Linville <[email protected]> wrote:
>> > On Tue, Dec 07, 2010 at 12:24:14PM +0100, Sedat Dilek wrote:
>> >
>> >> I have already reported on linux-wireless (short: l-w) ML that after
>> >> especially the merge of "AHB Bus support" patchset (see [2]) my ath5k
>> >> was not working as expected in daily use (also modinfo).
>> >>
>> >> I am not sure if it is the driver but reverting the 9 commits in my
>> >> local linux-next GIT seemed to "stabilize" a bit the Internet
>> >> connection.
>> >> The patchset from Nick (see below) definitely helped to stabilize ath5k.
>> >
>> > I imagine that these are the "9 commits" you mean:
>> >
>> >> git rev-list c30ae13..4cebb34
>> > 4cebb34caa5122216a1e2451eae9e0fc47ec2589
>> > a0b907ee2a71052fefdf6151764095f3f97b3275
>> > c31b5c9c806b1fbdc9e98885d897664a0d482989
>> > e7aecd327d80b2f156b54769013aaccb2a20645a
>> > 8efa5d7d6ad307ae2d220def37ca89594062c40d
>> > 4aa5d783c9e1c72e4950ff34f388077ccecac74a
>> > e5b046d86fac609f636d127a38de94a175c7e83b
>> > 132b1c3ee38ea6fa0501004fd0f19acb554e5a44
>> > aeae4ac9090462ea38387dcdbac4f01b944af6a4
>> >
>> > Most of those look fairly harmless so long as you don't define
>> > CONFIG_ATHEROS_AR231X. Just to narrow things down...if you only revert
>> > the first 8 (i.e. leave aeae4ac alone), do you still have problems?
>> > Or does it still "stabilize"?
>> >
>> > That patch converts the driver to the generic DMA API. It seems
>> > OK at first glance, but I suspect it is the only one likely to be
>> > effecting your situation.
>> >
>> > John
>> > --
>> > John W. Linville Someday the world will need a hero, and you
>> > [email protected] might be all we have. Be ready.
>> >
>>
>> Before jumping to another problem, I had a quick look into the
>> appropriate Kconfig file, as you say I have not CONFIG_ATHEROS_AR231X
>> set and that's why AHB support is not selected/built, instead
>>
>> CC [M] drivers/net/wireless/ath/ath5k/pci.o
>>
>> is built.
>>
>> Unfortunately, I can't cleanly revert. Sorry, I can't help.
>
> I don't quite understand -- you said you were reverting them before,
> but now I ask you to revert one _less_ patch (i.e. the last one to
> be reverted anyway) and you can't do it?
>
> John
> --
> John W. Linville Someday the world will need a hero, and you
> [email protected] might be all we have. Be ready.
>
I tested with a linux-next (next-20101206) with revert-at5k-patches.
Unfortunately, Nick's patchset is needed for a stable WLAN connection,
several ReAssoc's etc.
So, I can't give a comment to the effects of the AHB patchset on my AR5212.
But... I have found the culprit patch which makes modinfo no more list
the aliases/pci-id (see [1]):
commit e5b046d86fac609f636d127a38de94a175c7e83b
"ath5k: Move PCI bus functions to separate file."
- Sedat -
[1] http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=commit;h=e5b046d86fac609f636d127a38de94a175c7e83b
$ ~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none
$ cat .pc/applied-patches
revert-ath5k-patches/0001-Revert-ath5k-Fix-reset-and-interrupts-for-AHB-type-o.patch
revert-ath5k-patches/0002-Revert-ath5k-Add-AHB-bus-support.patch
revert-ath5k-patches/0003-Revert-ath5k-Add-initial-registers-values-for-radio-.patch
revert-ath5k-patches/0004-Revert-ath5k-Add-a-function-to-read-chipset-s-MAC-re.patch
revert-ath5k-patches/0005-Revert-ath5k-Check-if-pci-pdev-struct-is-initialized.patch
revert-ath5k-patches/0006-Revert-ath5k-Use-generic-eeprom-read-from-common-ath.patch
revert-ath5k-patches/0007-Revert-ath5k-Move-PCI-bus-functions-to-separate-file.patch
# modinfo ath5k
filename:
/lib/modules/2.6.37-rc4-686/kernel/drivers/net/wireless/ath/ath5k/ath5k.ko
version: 0.6.0 (EXPERIMENTAL)
license: Dual BSD/GPL
description: Support for 5xxx series of Atheros 802.11 wireless LAN
cards.
author: Nick Kossifidis
author: Jiri Slaby
srcversion: 666105BAEE881F2C2F10CE6
alias: pci:v0000168Cd0000001Dsv*sd*bc*sc*i*
alias: pci:v0000168Cd0000001Csv*sd*bc*sc*i*
alias: pci:v0000168Cd0000001Bsv*sd*bc*sc*i*
alias: pci:v0000168Cd0000001Asv*sd*bc*sc*i*
alias: pci:v0000168Cd00000019sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000018sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000017sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000016sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000015sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000014sv*sd*bc*sc*i*
alias: pci:v0000168Cd00001014sv*sd*bc*sc*i*
alias: pci:v000010B7d00000013sv*sd*bc*sc*i*
alias: pci:v0000A727d00000013sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000013sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000012sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000011sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000007sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000207sv*sd*bc*sc*i*
depends: mac80211,cfg80211,ath
vermagic: 2.6.37-rc4-686 SMP mod_unload modversions 686
parm: debug:uint
parm: nohwcrypt:Disable hardware encryption. (bool)
parm: all_channels:Expose all channels the device can use. (bool)
On Tue, Dec 07, 2010 at 04:57:08PM +0100, Sedat Dilek wrote:
> On Tue, Dec 7, 2010 at 3:26 PM, John W. Linville <[email protected]> wrote:
> > On Tue, Dec 07, 2010 at 12:24:14PM +0100, Sedat Dilek wrote:
> >
> >> I have already reported on linux-wireless (short: l-w) ML that after
> >> especially the merge of "AHB Bus support" patchset (see [2]) my ath5k
> >> was not working as expected in daily use (also modinfo).
> >>
> >> I am not sure if it is the driver but reverting the 9 commits in my
> >> local linux-next GIT seemed to "stabilize" a bit the Internet
> >> connection.
> >> The patchset from Nick (see below) definitely helped to stabilize ath5k.
> >
> > I imagine that these are the "9 commits" you mean:
> >
> >> git rev-list c30ae13..4cebb34
> > 4cebb34caa5122216a1e2451eae9e0fc47ec2589
> > a0b907ee2a71052fefdf6151764095f3f97b3275
> > c31b5c9c806b1fbdc9e98885d897664a0d482989
> > e7aecd327d80b2f156b54769013aaccb2a20645a
> > 8efa5d7d6ad307ae2d220def37ca89594062c40d
> > 4aa5d783c9e1c72e4950ff34f388077ccecac74a
> > e5b046d86fac609f636d127a38de94a175c7e83b
> > 132b1c3ee38ea6fa0501004fd0f19acb554e5a44
> > aeae4ac9090462ea38387dcdbac4f01b944af6a4
> >
> > Most of those look fairly harmless so long as you don't define
> > CONFIG_ATHEROS_AR231X. ?Just to narrow things down...if you only revert
> > the first 8 (i.e. leave aeae4ac alone), do you still have problems?
> > Or does it still "stabilize"?
> >
> > That patch converts the driver to the generic DMA API. ?It seems
> > OK at first glance, but I suspect it is the only one likely to be
> > effecting your situation.
> >
> > John
> > --
> > John W. Linville ? ? ? ? ? ? ? ?Someday the world will need a hero, and you
> > [email protected] ? ? ? ? ? ? ? ? ?might be all we have. ?Be ready.
> >
>
> Before jumping to another problem, I had a quick look into the
> appropriate Kconfig file, as you say I have not CONFIG_ATHEROS_AR231X
> set and that's why AHB support is not selected/built, instead
>
> CC [M] drivers/net/wireless/ath/ath5k/pci.o
>
> is built.
>
> Unfortunately, I can't cleanly revert. Sorry, I can't help.
I don't quite understand -- you said you were reverting them before,
but now I ask you to revert one _less_ patch (i.e. the last one to
be reverted anyway) and you can't do it?
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On Tue, Dec 7, 2010 at 4:59 PM, John W. Linville <[email protected]> wrote:
> On Tue, Dec 07, 2010 at 04:57:08PM +0100, Sedat Dilek wrote:
>> On Tue, Dec 7, 2010 at 3:26 PM, John W. Linville <[email protected]> wrote:
>> > On Tue, Dec 07, 2010 at 12:24:14PM +0100, Sedat Dilek wrote:
>> >
>> >> I have already reported on linux-wireless (short: l-w) ML that after
>> >> especially the merge of "AHB Bus support" patchset (see [2]) my ath5k
>> >> was not working as expected in daily use (also modinfo).
>> >>
>> >> I am not sure if it is the driver but reverting the 9 commits in my
>> >> local linux-next GIT seemed to "stabilize" a bit the Internet
>> >> connection.
>> >> The patchset from Nick (see below) definitely helped to stabilize ath5k.
>> >
>> > I imagine that these are the "9 commits" you mean:
>> >
>> >> git rev-list c30ae13..4cebb34
>> > 4cebb34caa5122216a1e2451eae9e0fc47ec2589
>> > a0b907ee2a71052fefdf6151764095f3f97b3275
>> > c31b5c9c806b1fbdc9e98885d897664a0d482989
>> > e7aecd327d80b2f156b54769013aaccb2a20645a
>> > 8efa5d7d6ad307ae2d220def37ca89594062c40d
>> > 4aa5d783c9e1c72e4950ff34f388077ccecac74a
>> > e5b046d86fac609f636d127a38de94a175c7e83b
>> > 132b1c3ee38ea6fa0501004fd0f19acb554e5a44
>> > aeae4ac9090462ea38387dcdbac4f01b944af6a4
>> >
>> > Most of those look fairly harmless so long as you don't define
>> > CONFIG_ATHEROS_AR231X. Just to narrow things down...if you only revert
>> > the first 8 (i.e. leave aeae4ac alone), do you still have problems?
>> > Or does it still "stabilize"?
>> >
>> > That patch converts the driver to the generic DMA API. It seems
>> > OK at first glance, but I suspect it is the only one likely to be
>> > effecting your situation.
>> >
>> > John
>> > --
>> > John W. Linville Someday the world will need a hero, and you
>> > [email protected] might be all we have. Be ready.
>> >
>>
>> Before jumping to another problem, I had a quick look into the
>> appropriate Kconfig file, as you say I have not CONFIG_ATHEROS_AR231X
>> set and that's why AHB support is not selected/built, instead
>>
>> CC [M] drivers/net/wireless/ath/ath5k/pci.o
>>
>> is built.
>>
>> Unfortunately, I can't cleanly revert. Sorry, I can't help.
>
> I don't quite understand -- you said you were reverting them before,
> but now I ask you to revert one _less_ patch (i.e. the last one to
> be reverted anyway) and you can't do it?
>
> John
> --
> John W. Linville Someday the world will need a hero, and you
> [email protected] might be all we have. Be ready.
>
After AHB-support patches went into linux-next (next-20101207), there
are now new ath5k patches touching
"drivers/net/wireless/ath/ath5k/base.c" on top.
For example the patchset from Nick, this would mean revert them, too.
Doing so, won't give you a clear answer.
BTW, 0008 patch has a big change:
drivers/net/wireless/ath/ath5k/base.c | 344 +++++++++++++------------------
Another solution would be to take a previous linux-next where those
patches were not in.
As you say by yourself 0001..0008 do not hurt, it's 0009 patch (first
in patchset) you are speculating on.
As I have archived my "compiled" build-trees, I can look at them.
AFAICS linux-next (next-20101203) should have wireless-next-2.6
(master-2010-12-02) [1] included.
Also, I have to find the fitting linux-image binary and install it,
hope I have not purged it from hdd.
- Sedat -
[1] http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=shortlog;h=refs/tags/master-2010-12-02
$ ls revert-ath5k-patches/000*
revert-ath5k-patches/0001-Revert-ath5k-Fix-reset-and-interrupts-for-AHB-type-o.patch
revert-ath5k-patches/0002-Revert-ath5k-Add-AHB-bus-support.patch
revert-ath5k-patches/0003-Revert-ath5k-Add-initial-registers-values-for-radio-.patch
revert-ath5k-patches/0004-Revert-ath5k-Add-a-function-to-read-chipset-s-MAC-re.patch
revert-ath5k-patches/0005-Revert-ath5k-Check-if-pci-pdev-struct-is-initialized.patch
revert-ath5k-patches/0006-Revert-ath5k-Use-generic-eeprom-read-from-common-ath.patch
revert-ath5k-patches/0007-Revert-ath5k-Move-PCI-bus-functions-to-separate-file.patch
revert-ath5k-patches/0008-Revert-ath5k-Introduce-ath5k_init_softc-function-as-.patch
revert-ath5k-patches/0009-Revert-ath5k-Use-Generic-DMA-for-later-support-of-AH.patch
On Tue, Dec 7, 2010 at 7:13 PM, Sedat Dilek <[email protected]> wrote:
> On Tue, Dec 7, 2010 at 4:59 PM, John W. Linville <[email protected]> wrote:
>> On Tue, Dec 07, 2010 at 04:57:08PM +0100, Sedat Dilek wrote:
>>> On Tue, Dec 7, 2010 at 3:26 PM, John W. Linville <[email protected]> wrote:
>>> > On Tue, Dec 07, 2010 at 12:24:14PM +0100, Sedat Dilek wrote:
>>> >
>>> >> I have already reported on linux-wireless (short: l-w) ML that after
>>> >> especially the merge of "AHB Bus support" patchset (see [2]) my ath5k
>>> >> was not working as expected in daily use (also modinfo).
>>> >>
>>> >> I am not sure if it is the driver but reverting the 9 commits in my
>>> >> local linux-next GIT seemed to "stabilize" a bit the Internet
>>> >> connection.
>>> >> The patchset from Nick (see below) definitely helped to stabilize ath5k.
>>> >
>>> > I imagine that these are the "9 commits" you mean:
>>> >
>>> >> git rev-list c30ae13..4cebb34
>>> > 4cebb34caa5122216a1e2451eae9e0fc47ec2589
>>> > a0b907ee2a71052fefdf6151764095f3f97b3275
>>> > c31b5c9c806b1fbdc9e98885d897664a0d482989
>>> > e7aecd327d80b2f156b54769013aaccb2a20645a
>>> > 8efa5d7d6ad307ae2d220def37ca89594062c40d
>>> > 4aa5d783c9e1c72e4950ff34f388077ccecac74a
>>> > e5b046d86fac609f636d127a38de94a175c7e83b
>>> > 132b1c3ee38ea6fa0501004fd0f19acb554e5a44
>>> > aeae4ac9090462ea38387dcdbac4f01b944af6a4
>>> >
>>> > Most of those look fairly harmless so long as you don't define
>>> > CONFIG_ATHEROS_AR231X. Just to narrow things down...if you only revert
>>> > the first 8 (i.e. leave aeae4ac alone), do you still have problems?
>>> > Or does it still "stabilize"?
>>> >
>>> > That patch converts the driver to the generic DMA API. It seems
>>> > OK at first glance, but I suspect it is the only one likely to be
>>> > effecting your situation.
>>> >
>>> > John
>>> > --
>>> > John W. Linville Someday the world will need a hero, and you
>>> > [email protected] might be all we have. Be ready.
>>> >
>>>
>>> Before jumping to another problem, I had a quick look into the
>>> appropriate Kconfig file, as you say I have not CONFIG_ATHEROS_AR231X
>>> set and that's why AHB support is not selected/built, instead
>>>
>>> CC [M] drivers/net/wireless/ath/ath5k/pci.o
>>>
>>> is built.
>>>
>>> Unfortunately, I can't cleanly revert. Sorry, I can't help.
>>
>> I don't quite understand -- you said you were reverting them before,
>> but now I ask you to revert one _less_ patch (i.e. the last one to
>> be reverted anyway) and you can't do it?
>>
>> John
>> --
>> John W. Linville Someday the world will need a hero, and you
>> [email protected] might be all we have. Be ready.
>>
>
> I tested with a linux-next (next-20101206) with revert-at5k-patches.
> Unfortunately, Nick's patchset is needed for a stable WLAN connection,
> several ReAssoc's etc.
> So, I can't give a comment to the effects of the AHB patchset on my AR5212.
>
> But... I have found the culprit patch which makes modinfo no more list
> the aliases/pci-id (see [1]):
>
> commit e5b046d86fac609f636d127a38de94a175c7e83b
> "ath5k: Move PCI bus functions to separate file."
>
> - Sedat -
>
> [1] http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=commit;h=e5b046d86fac609f636d127a38de94a175c7e83b
>
> $ ~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none
>
> $ cat .pc/applied-patches
> revert-ath5k-patches/0001-Revert-ath5k-Fix-reset-and-interrupts-for-AHB-type-o.patch
> revert-ath5k-patches/0002-Revert-ath5k-Add-AHB-bus-support.patch
> revert-ath5k-patches/0003-Revert-ath5k-Add-initial-registers-values-for-radio-.patch
> revert-ath5k-patches/0004-Revert-ath5k-Add-a-function-to-read-chipset-s-MAC-re.patch
> revert-ath5k-patches/0005-Revert-ath5k-Check-if-pci-pdev-struct-is-initialized.patch
> revert-ath5k-patches/0006-Revert-ath5k-Use-generic-eeprom-read-from-common-ath.patch
> revert-ath5k-patches/0007-Revert-ath5k-Move-PCI-bus-functions-to-separate-file.patch
>
> # modinfo ath5k
> filename:
> /lib/modules/2.6.37-rc4-686/kernel/drivers/net/wireless/ath/ath5k/ath5k.ko
> version: 0.6.0 (EXPERIMENTAL)
> license: Dual BSD/GPL
> description: Support for 5xxx series of Atheros 802.11 wireless LAN
> cards.
> author: Nick Kossifidis
> author: Jiri Slaby
> srcversion: 666105BAEE881F2C2F10CE6
> alias: pci:v0000168Cd0000001Dsv*sd*bc*sc*i*
> alias: pci:v0000168Cd0000001Csv*sd*bc*sc*i*
> alias: pci:v0000168Cd0000001Bsv*sd*bc*sc*i*
> alias: pci:v0000168Cd0000001Asv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000019sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000018sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000017sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000016sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000015sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000014sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00001014sv*sd*bc*sc*i*
> alias: pci:v000010B7d00000013sv*sd*bc*sc*i*
> alias: pci:v0000A727d00000013sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000013sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000012sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000011sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000007sv*sd*bc*sc*i*
> alias: pci:v0000168Cd00000207sv*sd*bc*sc*i*
> depends: mac80211,cfg80211,ath
> vermagic: 2.6.37-rc4-686 SMP mod_unload modversions 686
> parm: debug:uint
> parm: nohwcrypt:Disable hardware encryption. (bool)
> parm: all_channels:Expose all channels the device can use. (bool)
>
I have found the cause for the modinfo problem, here is a fix (I will
send later a separate patch):
$ diff -Naur drivers/net/wireless/ath/ath5k/pci.c.orig
drivers/net/wireless/ath/ath5k/pci.c
--- drivers/net/wireless/ath/ath5k/pci.c.orig 2010-12-07
19:34:53.999334165 +0100
+++ drivers/net/wireless/ath/ath5k/pci.c 2010-12-07
22:25:20.387028188 +0100
@@ -45,6 +45,7 @@
{ PCI_VDEVICE(ATHEROS, 0x001d) }, /* 2417 Nala */
{ 0 }
};
+MODULE_DEVICE_TABLE(pci, ath5k_pci_id_table);
/* return bus cachesize in 4B word units */
static void ath5k_pci_read_cachesize(struct ath_common *common, int *csz)
# modinfo ath5k
filename:
/lib/modules/2.6.37-rc4-686/kernel/drivers/net/wireless/ath/ath5k/ath5k.ko
version: 0.6.0 (EXPERIMENTAL)
license: Dual BSD/GPL
description: Support for 5xxx series of Atheros 802.11 wireless LAN
cards.
author: Nick Kossifidis
author: Jiri Slaby
srcversion: 1B224A604952CD0597CA568
alias: pci:v0000168Cd0000001Dsv*sd*bc*sc*i*
alias: pci:v0000168Cd0000001Csv*sd*bc*sc*i*
alias: pci:v0000168Cd0000001Bsv*sd*bc*sc*i*
alias: pci:v0000168Cd0000001Asv*sd*bc*sc*i*
alias: pci:v0000168Cd00000019sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000018sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000017sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000016sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000015sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000014sv*sd*bc*sc*i*
alias: pci:v0000168Cd00001014sv*sd*bc*sc*i*
alias: pci:v000010B7d00000013sv*sd*bc*sc*i*
alias: pci:v0000A727d00000013sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000013sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000012sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000011sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000007sv*sd*bc*sc*i*
alias: pci:v0000168Cd00000207sv*sd*bc*sc*i*
depends: mac80211,cfg80211,ath
vermagic: 2.6.37-rc4-686 SMP mod_unload modversions 686
parm: debug:uint
parm: nohwcrypt:Disable hardware encryption. (bool)
parm: all_channels:Expose all channels the device can use. (bool)
On Tue, Dec 7, 2010 at 12:24 PM, Sedat Dilek <[email protected]> wrote:
> Hi,
>
> I just compiled linux-next (next-20101207) which also includes
> wireless-next-2.6 (master-2010-12-06) [1].
>
> I have already reported on linux-wireless (short: l-w) ML that after
> especially the merge of "AHB Bus support" patchset (see [2]) my ath5k
> was not working as expected in daily use (also modinfo).
>
> I am not sure if it is the driver but reverting the 9 commits in my
> local linux-next GIT seemed to "stabilize" a bit the Internet
> connection.
> The patchset from Nick (see below) definitely helped to stabilize ath5k.
>
> What means "daily use"?
> Quassel IRC-client (around 20 channels), Iceweasel (Debian's answer to
> firefox) with sometimes 20 tabs open and radio live-stream in VLC.
>
> Here and there I have still audio-dropouts or when typing emails in
> web-based email-service, it stalls when "stressing" with for example
> parallelly creating a tarball (that's normally no huge workload) the
> probability for audio-dropouts increases.
>
> As I said I am not sure what is causing these hangs, it's ath5k
> driver? Is it sth. else?
> How to dig into it?
>
> Unfortunately, modinfo does not list aliases with pci-id matching (I
> have already reported to l-w ML, see below).
> With reverting "AHB Bus support" patchset modinfo works as expected.
>
> As a workaround I added ath5k to /etc/modules (see below), otherwise I
> have to stop networking, unload + reload ath5k and start networking
> again.
>
> I also added an iw station dump (see below) and outputs of filtered
> lspci and dmesg commands.
>
> Not sure if this is helpful to mention, I use crda and wireless-regdb
> (see below).
>
> BTW, I have these two patches in addition to linux-next:
> (+) OK mac80211-fix/mac80211-fix-a-compiler-warning.patch
> (+) OK ath5k-fix/ath5k-Use-capabilities-information-for-the-number-of-TX-queues.patch
>
> Any ideas/help appreciated, Thanks in advance.
>
> Kind Regards,
> - Sedat -
>
> [1] http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git
> [2] http://wireless.kernel.org/en/users/Drivers/ath5k
>
> P.S.: Patchset from Nick Kossifidis
>
> $ ls -l ath5k-fix/*-6-*
> -rw-r--r-- 1 sd sd 3439 3. Dez 06:52
> ath5k-fix/1-6-ath5k-Always-write-tx-powertable-on-hw.patch
> -rw-r--r-- 1 sd sd 1725 3. Dez 06:51
> ath5k-fix/2-6-ath5k-Always-free-tx-buffers-before-reset.patch
> -rw-r--r-- 1 sd sd 2132 3. Dez 06:52
> ath5k-fix/3-6-ath5k-Disable-ANI-during-reset.patch
> -rw-r--r-- 1 sd sd 1360 3. Dez 06:52
> ath5k-fix/4-6-ath5k-Fix-reporting-of-RX-dma-stop-failure.patch
> -rw-r--r-- 1 sd sd 1735 3. Dez 06:52
> ath5k-fix/5-6-ath5k-Update-version-string.patch
> -rw-r--r-- 1 sd sd 1744 3. Dez 06:53
> ath5k-fix/6-6-ath5k-Include-tx-ack-reporting-on-hw-flags.patch
>
> # modinfo ath5k
> filename:
> /lib/modules/2.6.37-rc4-686/kernel/drivers/net/wireless/ath/ath5k/ath5k.ko
> version: 0.6.0 (EXPERIMENTAL)
> license: Dual BSD/GPL
> description: Support for 5xxx series of Atheros 802.11 wireless LAN cards.
> author: Nick Kossifidis
> author: Jiri Slaby
> srcversion: 49DBF0BE975A1F9917151F4
> depends: mac80211,cfg80211,ath
> vermagic: 2.6.37-rc4-686 SMP mod_unload modversions 686
> parm: debug:uint
> parm: nohwcrypt:Disable hardware encryption. (bool)
> parm: all_channels:Expose all channels the device can use. (bool)
>
> # grep ath5k /etc/modules
> ath5k
>
> # iw wlan0 station dump
> Station 00:04:0e:e4:00:3d (on wlan0)
> inactive time: 48 ms
> rx bytes: 60460696
> rx packets: 95331
> tx bytes: 5034456
> tx packets: 50165
> signal: -50 dBm
> tx bitrate: 36.0 MBit/s
>
> # lspci -nnvv | grep -i ath
> 02:02.0 Ethernet controller [0200]: Atheros Communications Inc. AR5212
> 802.11abg NIC [168c:1014] (rev 01)
> Kernel driver in use: ath5k
>
> # dmesg | egrep -i 'ath|80211|wlan'
> [ 14.444118] cfg80211: Calling CRDA to update world regulatory domain
> [ 14.725757] ath5k 0000:02:02.0: PCI INT A -> Link[LNKC] -> GSI 11
> (level, low) -> IRQ 11
> [ 14.736940] ath5k 0000:02:02.0: registered as 'phy0'
> [ 15.036636] ath: EEPROM regdomain: 0x61
> [ 15.036640] ath: EEPROM indicates we should expect a direct regpair map
> [ 15.036646] ath: Country alpha2 being used: 00
> [ 15.036648] ath: Regpair used: 0x61
> [ 15.665415] cfg80211: World regulatory domain updated:
> [ 15.676274] cfg80211: (start_freq - end_freq @ bandwidth),
> (max_antenna_gain, max_eirp)
> [ 15.687303] cfg80211: (2402000 KHz - 2472000 KHz @ 40000 KHz),
> (300 mBi, 2000 mBm)
> [ 15.698413] cfg80211: (2457000 KHz - 2482000 KHz @ 20000 KHz),
> (300 mBi, 2000 mBm)
> [ 15.709461] cfg80211: (2474000 KHz - 2494000 KHz @ 20000 KHz),
> (300 mBi, 2000 mBm)
> [ 15.720489] cfg80211: (5170000 KHz - 5250000 KHz @ 40000 KHz),
> (300 mBi, 2000 mBm)
> [ 15.731526] cfg80211: (5735000 KHz - 5835000 KHz @ 40000 KHz),
> (300 mBi, 2000 mBm)
> [ 15.754490] ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
> [ 15.755482] Registered led device: ath5k-phy0::rx
> [ 15.755516] Registered led device: ath5k-phy0::tx
> [ 15.755529] ath5k phy0: Atheros AR5212 chip found (MAC: 0x56, PHY: 0x41)
> [ 15.766686] ath5k phy0: RF5111 5GHz radio found (0x17)
> [ 15.777870] ath5k phy0: RF2111 2GHz radio found (0x23)
> [ 17.374647] ADDRCONF(NETDEV_UP): wlan0: link is not ready
> [ 22.596104] wlan0: authenticate with 00:04:0e:e4:00:3d (try 1)
> [ 22.597531] wlan0: authenticated
> [ 22.597549] wlan0: associate with 00:04:0e:e4:00:3d (try 1)
> [ 22.602095] wlan0: RX AssocResp from 00:04:0e:e4:00:3d (capab=0x411
> status=0 aid=1)
> [ 22.602100] wlan0: associated
> [ 22.602986] ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
> [ 33.312034] wlan0: no IPv6 routers present
> [ 215.317105] cfg80211: Calling CRDA to update world regulatory domain
> [ 215.346333] cfg80211: World regulatory domain updated:
> [ 215.346341] cfg80211: (start_freq - end_freq @ bandwidth),
> (max_antenna_gain, max_eirp)
> [ 215.346346] cfg80211: (2402000 KHz - 2472000 KHz @ 40000 KHz),
> (300 mBi, 2000 mBm)
> [ 215.346350] cfg80211: (2457000 KHz - 2482000 KHz @ 20000 KHz),
> (300 mBi, 2000 mBm)
> [ 215.346354] cfg80211: (2474000 KHz - 2494000 KHz @ 20000 KHz),
> (300 mBi, 2000 mBm)
> [ 215.346358] cfg80211: (5170000 KHz - 5250000 KHz @ 40000 KHz),
> (300 mBi, 2000 mBm)
> [ 215.346362] cfg80211: (5735000 KHz - 5835000 KHz @ 40000 KHz),
> (300 mBi, 2000 mBm)
> [ 219.627199] wlan0: authenticate with 00:04:0e:e4:00:3d (try 1)
> [ 219.629321] wlan0: authenticated
> [ 219.629365] wlan0: associate with 00:04:0e:e4:00:3d (try 1)
> [ 219.635825] wlan0: RX AssocResp from 00:04:0e:e4:00:3d (capab=0x411
> status=0 aid=1)
> [ 219.635836] wlan0: associated
>
> # dpkg -l | egrep 'crda|wireless-regdb' | cut -c-80
> ii crda 1.1.1-0~svnr1515.3
> ii wireless-regdb 2010.11.24-1
>
Might also be interesting to know:
# wpa_cli -i wlan0 status
bssid=00:04:0e:e4:00:3d
ssid=myCastle-WLAN WPA (Wireless LAN)
id=0
pairwise_cipher=CCMP
group_cipher=TKIP
key_mgmt=WPA2-PSK
wpa_state=COMPLETED
ip_address=192.168.178.25
- Sedat -
On Tue, Dec 07, 2010 at 12:24:14PM +0100, Sedat Dilek wrote:
> I have already reported on linux-wireless (short: l-w) ML that after
> especially the merge of "AHB Bus support" patchset (see [2]) my ath5k
> was not working as expected in daily use (also modinfo).
>
> I am not sure if it is the driver but reverting the 9 commits in my
> local linux-next GIT seemed to "stabilize" a bit the Internet
> connection.
> The patchset from Nick (see below) definitely helped to stabilize ath5k.
I imagine that these are the "9 commits" you mean:
> git rev-list c30ae13..4cebb34
4cebb34caa5122216a1e2451eae9e0fc47ec2589
a0b907ee2a71052fefdf6151764095f3f97b3275
c31b5c9c806b1fbdc9e98885d897664a0d482989
e7aecd327d80b2f156b54769013aaccb2a20645a
8efa5d7d6ad307ae2d220def37ca89594062c40d
4aa5d783c9e1c72e4950ff34f388077ccecac74a
e5b046d86fac609f636d127a38de94a175c7e83b
132b1c3ee38ea6fa0501004fd0f19acb554e5a44
aeae4ac9090462ea38387dcdbac4f01b944af6a4
Most of those look fairly harmless so long as you don't define
CONFIG_ATHEROS_AR231X. Just to narrow things down...if you only revert
the first 8 (i.e. leave aeae4ac alone), do you still have problems?
Or does it still "stabilize"?
That patch converts the driver to the generic DMA API. It seems
OK at first glance, but I suspect it is the only one likely to be
effecting your situation.
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On Tue, Dec 7, 2010 at 3:26 PM, John W. Linville <[email protected]> wrote:
> On Tue, Dec 07, 2010 at 12:24:14PM +0100, Sedat Dilek wrote:
>
>> I have already reported on linux-wireless (short: l-w) ML that after
>> especially the merge of "AHB Bus support" patchset (see [2]) my ath5k
>> was not working as expected in daily use (also modinfo).
>>
>> I am not sure if it is the driver but reverting the 9 commits in my
>> local linux-next GIT seemed to "stabilize" a bit the Internet
>> connection.
>> The patchset from Nick (see below) definitely helped to stabilize ath5k.
>
> I imagine that these are the "9 commits" you mean:
>
>> git rev-list c30ae13..4cebb34
> 4cebb34caa5122216a1e2451eae9e0fc47ec2589
> a0b907ee2a71052fefdf6151764095f3f97b3275
> c31b5c9c806b1fbdc9e98885d897664a0d482989
> e7aecd327d80b2f156b54769013aaccb2a20645a
> 8efa5d7d6ad307ae2d220def37ca89594062c40d
> 4aa5d783c9e1c72e4950ff34f388077ccecac74a
> e5b046d86fac609f636d127a38de94a175c7e83b
> 132b1c3ee38ea6fa0501004fd0f19acb554e5a44
> aeae4ac9090462ea38387dcdbac4f01b944af6a4
>
> Most of those look fairly harmless so long as you don't define
> CONFIG_ATHEROS_AR231X. Just to narrow things down...if you only revert
> the first 8 (i.e. leave aeae4ac alone), do you still have problems?
> Or does it still "stabilize"?
>
> That patch converts the driver to the generic DMA API. It seems
> OK at first glance, but I suspect it is the only one likely to be
> effecting your situation.
>
> John
> --
> John W. Linville Someday the world will need a hero, and you
> [email protected] might be all we have. Be ready.
>
Before jumping to another problem, I had a quick look into the
appropriate Kconfig file, as you say I have not CONFIG_ATHEROS_AR231X
set and that's why AHB support is not selected/built, instead
CC [M] drivers/net/wireless/ath/ath5k/pci.o
is built.
Unfortunately, I can't cleanly revert. Sorry, I can't help.
- Sedat -
sd@tbox:~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none$
LC_ALL=C quilt -f push
Applying patch 0001-Revert-Add-ath5k-Use-capabilities-information-for-th.patch
patching file drivers/net/wireless/ath/ath5k/base.c
patching file drivers/net/wireless/ath/ath5k/qcu.c
Now at patch 0001-Revert-Add-ath5k-Use-capabilities-information-for-th.patch
sd@tbox:~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none$
LC_ALL=C quilt -f push
Applying patch revert-ath5k-patches/0001-Revert-ath5k-Fix-reset-and-interrupts-for-AHB-type-o.patch
patching file drivers/net/wireless/ath/ath5k/base.c
patching file drivers/net/wireless/ath/ath5k/reset.c
Now at patch revert-ath5k-patches/0001-Revert-ath5k-Fix-reset-and-interrupts-for-AHB-type-o.patch
sd@tbox:~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none$
LC_ALL=C quilt -f push
Applying patch revert-ath5k-patches/0002-Revert-ath5k-Add-AHB-bus-support.patch
patching file drivers/net/wireless/ath/ath5k/Kconfig
patching file drivers/net/wireless/ath/ath5k/Makefile
patching file drivers/net/wireless/ath/ath5k/ahb.c
patching file drivers/net/wireless/ath/ath5k/ath5k.h
patching file drivers/net/wireless/ath/ath5k/base.c
patching file drivers/net/wireless/ath/ath5k/led.c
patching file drivers/net/wireless/ath/ath5k/reg.h
Now at patch revert-ath5k-patches/0002-Revert-ath5k-Add-AHB-bus-support.patch
sd@tbox:~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none$
LC_ALL=C quilt -f push
Applying patch revert-ath5k-patches/0003-Revert-ath5k-Add-initial-registers-values-for-radio-.patch
patching file drivers/net/wireless/ath/ath5k/initvals.c
Now at patch revert-ath5k-patches/0003-Revert-ath5k-Add-initial-registers-values-for-radio-.patch
sd@tbox:~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none$
LC_ALL=C quilt -f push
Applying patch revert-ath5k-patches/0004-Revert-ath5k-Add-a-function-to-read-chipset-s-MAC-re.patch
patching file drivers/net/wireless/ath/ath5k/ath5k.h
patching file drivers/net/wireless/ath/ath5k/attach.c
patching file drivers/net/wireless/ath/ath5k/pci.c
Now at patch revert-ath5k-patches/0004-Revert-ath5k-Add-a-function-to-read-chipset-s-MAC-re.patch
sd@tbox:~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none$
LC_ALL=C quilt -f push
Applying patch revert-ath5k-patches/0005-Revert-ath5k-Check-if-pci-pdev-struct-is-initialized.patch
patching file drivers/net/wireless/ath/ath5k/attach.c
patching file drivers/net/wireless/ath/ath5k/led.c
patching file drivers/net/wireless/ath/ath5k/reset.c
patching file drivers/net/wireless/ath/ath5k/sysfs.c
Now at patch revert-ath5k-patches/0005-Revert-ath5k-Check-if-pci-pdev-struct-is-initialized.patch
sd@tbox:~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none$
LC_ALL=C quilt -f push
Applying patch revert-ath5k-patches/0006-Revert-ath5k-Use-generic-eeprom-read-from-common-ath.patch
patching file drivers/net/wireless/ath/ath5k/ath5k.h
patching file drivers/net/wireless/ath/ath5k/eeprom.c
patching file drivers/net/wireless/ath/ath5k/eeprom.h
patching file drivers/net/wireless/ath/ath5k/pci.c
Now at patch revert-ath5k-patches/0006-Revert-ath5k-Use-generic-eeprom-read-from-common-ath.patch
sd@tbox:~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none$
LC_ALL=C quilt -f push
Applying patch revert-ath5k-patches/0007-Revert-ath5k-Move-PCI-bus-functions-to-separate-file.patch
patching file drivers/net/wireless/ath/ath5k/Makefile
patching file drivers/net/wireless/ath/ath5k/ath5k.h
patching file drivers/net/wireless/ath/ath5k/base.c
Hunk #5 succeeded at 3636 (offset 9 lines).
patching file drivers/net/wireless/ath/ath5k/pci.c
Now at patch revert-ath5k-patches/0007-Revert-ath5k-Move-PCI-bus-functions-to-separate-file.patch
sd@tbox:~/src/linux-2.6/linux-2.6.37-rc4/debian/build/source_i386_none$
LC_ALL=C quilt -f push
Applying patch revert-ath5k-patches/0008-Revert-ath5k-Introduce-ath5k_init_softc-function-as-.patch
patching file drivers/net/wireless/ath/ath5k/ath5k.h
patching file drivers/net/wireless/ath/ath5k/attach.c
patching file drivers/net/wireless/ath/ath5k/base.c
Hunk #4 FAILED at 2338.
Hunk #5 succeeded at 2530 (offset 1 line).
Hunk #6 succeeded at 2736 (offset 9 lines).
Hunk #7 succeeded at 2745 (offset 9 lines).
Hunk #8 succeeded at 2886 (offset 9 lines).
Hunk #9 succeeded at 2904 (offset 9 lines).
Hunk #10 succeeded at 2916 (offset 9 lines).
Hunk #11 succeeded at 2938 (offset 9 lines).
Hunk #12 succeeded at 3583 (offset 9 lines).
Hunk #13 succeeded at 3617 (offset 9 lines).
Hunk #14 succeeded at 3713 (offset 9 lines).
Hunk #15 succeeded at 3868 (offset 9 lines).
1 out of 15 hunks FAILED -- saving rejects to file
drivers/net/wireless/ath/ath5k/base.c.rej
patching file drivers/net/wireless/ath/ath5k/base.h
patching file drivers/net/wireless/ath/ath5k/eeprom.c
Applied patch revert-ath5k-patches/0008-Revert-ath5k-Introduce-ath5k_init_softc-function-as-.patch
(forced; needs refresh)
- EOT -