2010-10-27 21:53:15

by Ohad Ben Cohen

[permalink] [raw]
Subject: Re: sdio ids for wl12xx

[taking LKML out and adding linux-wireless]

Hi Elvis,

On Wed, Oct 27, 2010 at 8:42 PM, Elvis Dowson <[email protected]> wrote:
...
> ? ? ? ? ? ? ? ? ?I was wondering, don't you need the sdio_ids for TI WL12xx as follows?

No, it's already defined inside wl1271_sdio.c

> Do you think the LSR TiWi SDIO ids would be different?

No - all 1271 devices have these numbers:

#define SDIO_VENDOR_ID_TI 0x0097
#define SDIO_DEVICE_ID_TI_WL1271 0x4076

>
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> +#define SDIO_VENDOR_ID_TI ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?0x104c
> +#define SDIO_DEVICE_ID_TI_WL12xx ? ? ? ? ? ? ? 0x9066

Hmm. These looks like the 1251 numbers (check out wl1251_sdio.c).

Using wrong numbers can lead to not getting your probe function called.

But again let me ask you to just try Luca's tree + Beagle patches
first. It should work out of the box.

Regards,
Ohad.