2011-03-08 21:45:49

by John W. Linville

[permalink] [raw]
Subject: [PATCH] ath5k: restrict AR5K_TX_QUEUE_ID_DATA_MAX to reflect the [0,3] range

This just matches reality...

Signed-off-by: John W. Linville <[email protected]>
---
...or am I missing something?

drivers/net/wireless/ath/ath5k/ath5k.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h
index 0ee54eb..8a06dbd 100644
--- a/drivers/net/wireless/ath/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath/ath5k/ath5k.h
@@ -513,7 +513,7 @@ enum ath5k_tx_queue_id {
AR5K_TX_QUEUE_ID_NOQCU_DATA = 0,
AR5K_TX_QUEUE_ID_NOQCU_BEACON = 1,
AR5K_TX_QUEUE_ID_DATA_MIN = 0, /*IEEE80211_TX_QUEUE_DATA0*/
- AR5K_TX_QUEUE_ID_DATA_MAX = 4, /*IEEE80211_TX_QUEUE_DATA4*/
+ AR5K_TX_QUEUE_ID_DATA_MAX = 3, /*IEEE80211_TX_QUEUE_DATA3*/
AR5K_TX_QUEUE_ID_DATA_SVP = 5, /*IEEE80211_TX_QUEUE_SVP - Spectralink Voice Protocol*/
AR5K_TX_QUEUE_ID_CAB = 6, /*IEEE80211_TX_QUEUE_AFTER_BEACON*/
AR5K_TX_QUEUE_ID_BEACON = 7, /*IEEE80211_TX_QUEUE_BEACON*/
--
1.7.4



2011-03-11 21:22:54

by Nick Kossifidis

[permalink] [raw]
Subject: Re: [PATCH] ath5k: restrict AR5K_TX_QUEUE_ID_DATA_MAX to reflect the [0,3] range

2011/3/9 <[email protected]>:
> On Tue, Mar 08, 2011 at 04:36:00PM -0500, John W. Linville wrote:
>> This just matches reality...
>>
>> Signed-off-by: John W. Linville <[email protected]>
>> ---
>> ..or am I missing something?
>
> No, your change looks right to me.
>
> Acked-by: Bob Copeland <[email protected]>
>
> --
> Bob Copeland %% http://www.bobcopeland.com
>

Yup this is left from early dadwifi days, thanks for catching it ;-)
(http://johannes.sipsolutions.net/files/mac80211.h.txt)

We have to do some more cleanup on ath5k.h...

Acked-by: Nick Kossifidis <[email protected]>



--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

2011-03-09 03:51:44

by Bob Copeland

[permalink] [raw]
Subject: Re: [PATCH] ath5k: restrict AR5K_TX_QUEUE_ID_DATA_MAX to reflect the [0,3] range

On Tue, Mar 08, 2011 at 04:36:00PM -0500, John W. Linville wrote:
> This just matches reality...
>
> Signed-off-by: John W. Linville <[email protected]>
> ---
> ..or am I missing something?

No, your change looks right to me.

Acked-by: Bob Copeland <[email protected]>

--
Bob Copeland %% http://www.bobcopeland.com