2018-07-08 09:57:26

by Bernd Edlinger

[permalink] [raw]
Subject: [PATCH] Add a missing break in parse_station_flags

SSB3YXMgbG9va2luZyBhdCB1c3VhbGx5IHN1cHByZXNzZWQgZ2NjIHdhcm5pbmdzLA0KWy1XaW1w
bGljaXQtZmFsbHRocm91Z2g9XSBpbiB0aGlzIGNhc2U6DQoNClRoZSBjb2RlIGRlZmluaXRlbHkg
bG9va3MgbGlrZSBhIGJyZWFrIGlzIG1pc3NpbmcgaGVyZS4NCkhvd2V2ZXIgSSBhbSBub3QgYWJs
ZSB0byB0ZXN0IHRoZSBOTDgwMjExX0lGVFlQRV9NRVNIX1BPSU5ULA0Kbm9yIGRvIEkgYWN0dWFs
bHkga25vdyB3aGF0IG1pZ2h0IGJlIDopDQpTbyBwbGVhc2UgdXNlIHRoaXMgcGF0Y2ggd2l0aCBj
YXV0aW9uIGFuZCBvbmx5IGlmIHlvdSBhcmUNCmFibGUgdG8gZG8gc29tZSB0ZXN0aW5nLg0KDQpT
aWduZWQtb2ZmLWJ5OiBCZXJuZCBFZGxpbmdlciA8YmVybmQuZWRsaW5nZXJAaG90bWFpbC5kZT4N
Ci0tLQ0KICBuZXQvd2lyZWxlc3Mvbmw4MDIxMS5jIHwgMSArDQogIDEgZmlsZSBjaGFuZ2VkLCAx
IGluc2VydGlvbigrKQ0KDQpkaWZmIC0tZ2l0IGEvbmV0L3dpcmVsZXNzL25sODAyMTEuYyBiL25l
dC93aXJlbGVzcy9ubDgwMjExLmMNCmluZGV4IDRlZWNlMDYuLjY1MzdiNWQgMTAwNjQ0DQotLS0g
YS9uZXQvd2lyZWxlc3Mvbmw4MDIxMS5jDQorKysgYi9uZXQvd2lyZWxlc3Mvbmw4MDIxMS5jDQpA
QCAtNDQwOSw2ICs0NDA5LDcgQEAgc3RhdGljIGludCBwYXJzZV9zdGF0aW9uX2ZsYWdzKHN0cnVj
dCBnZW5sX2luZm8gKmluZm8sDQogIAkJcGFyYW1zLT5zdGFfZmxhZ3NfbWFzayA9IEJJVChOTDgw
MjExX1NUQV9GTEFHX0FVVEhFTlRJQ0FURUQpIHwNCiAgCQkJCQkgQklUKE5MODAyMTFfU1RBX0ZM
QUdfTUZQKSB8DQogIAkJCQkJIEJJVChOTDgwMjExX1NUQV9GTEFHX0FVVEhPUklaRUQpOw0KKwkJ
YnJlYWs7DQogIAlkZWZhdWx0Og0KICAJCXJldHVybiAtRUlOVkFMOw0KICAJfQ0KLS0gDQoxLjku
MQ0K


2018-07-23 10:31:02

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] Add a missing break in parse_station_flags

Bernd Edlinger <[email protected]> writes:

> I was looking at usually suppressed gcc warnings,
> [-Wimplicit-fallthrough=] in this case:
>
> The code definitely looks like a break is missing here.
> However I am not able to test the NL80211_IFTYPE_MESH_POINT,
> nor do I actually know what might be :)
> So please use this patch with caution and only if you are
> able to do some testing.
>
> Signed-off-by: Bernd Edlinger <[email protected]>
> ---
> net/wireless/nl80211.c | 1 +
> 1 file changed, 1 insertion(+)

You should use prefix "nl80211: " in the title.

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject

--
Kalle Valo