2011-05-05 15:48:23

by Andreas Hartmann

[permalink] [raw]
Subject: compile-error agg-tx.c: error: impl icit declaration of function ‘kfree_rcu’

Hello,

since May, there is a compile error in compat-wireless (against kernel
2.6.34):


compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c: In function
?___ieee80211_stop_tx_ba_session?:
compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:158: error: implicit
declaration of function ?kfree_rcu?
compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:158: error:
?rcu_head? undeclared (first use in this function)
compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:158: error: (Each
undeclared identifier is reported only once
compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:158: error: for each
function it appears in.)
compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c: In function
?ieee80211_tx_ba_session_handle_start?:
compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:317: error:
?rcu_head? undeclared (first use in this function)
compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c: In function
?ieee80211_stop_tx_ba_cb?:
compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:696: error:
?rcu_head? undeclared (first use in this function)


See https://patchwork.kernel.org/patch/745352/


Regards,
Andreas


2011-05-06 05:05:09

by Mohammed Shafi

[permalink] [raw]
Subject: Re: compile-error agg-tx.c: error: implicit declarat ion of function ‘kfree_rcu’

On Thu, May 5, 2011 at 9:20 PM, Andreas Hartmann
<[email protected]> wrote:
> Hello,
>
> since May, there is a compile error in compat-wireless (against kernel
> 2.6.34):
>
>
> compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c: In function
> ?___ieee80211_stop_tx_ba_session?:
> compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:158: error: implicit
> declaration of function ?kfree_rcu?
> compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:158: error:
> ?rcu_head? undeclared (first use in this function)
> compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:158: error: (Each
> undeclared identifier is reported only once
> compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:158: error: for each
> function it appears in.)
> compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c: In function
> ?ieee80211_tx_ba_session_handle_start?:
> compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:317: error:
> ?rcu_head? undeclared (first use in this function)
> compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c: In function
> ?ieee80211_stop_tx_ba_cb?:
> compat-wireless-2011-05-04-p/net/mac80211/agg-tx.c:696: error:
> ?rcu_head? undeclared (first use in this function)
>
>
> See https://patchwork.kernel.org/patch/745352/

this patch seems to be applied in compat-wireless-2011-05-05 but I am
still getting the same compilation errors in 2.6.32-25. any other
fixes

thanks,
shafi

>
>
> Regards,
> Andreas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>

2011-05-09 12:27:50

by Ignacy Gawedzki

[permalink] [raw]
Subject: Re: compile-error agg-tx.c: erro r: implicit declaration of function ‘kfree_rcu’

On Fri, May 06, 2011 at 10:35:08AM +0530, thus spake Mohammed Shafi:
> On Thu, May 5, 2011 at 9:20 PM, Andreas Hartmann
> <[email protected]> wrote:
> > Hello,
> >
> > since May, there is a compile error in compat-wireless (against kernel
> > 2.6.34):

I, as it appears with many others, have the same kind of trouble compiling the
latests compat-wireless snapshots on some kernels (2.6.38 for me).

Obviously the kfree_rcu machinery should go into some compat/ source file. In
the meantime, I personnaly reverted these changes (see attached patch) and it
works just fine.

--
/* This is not a comment */


Attachments:
(No filename) (618.00 B)
compat-wireless-no-kfree-rcu.patch (1.99 kB)
Download all attachments

2011-05-09 15:59:28

by Mohammed Shafi

[permalink] [raw]
Subject: Re: compile-error agg-tx.c: error: implicit declarat ion of function ‘kfree_rcu’

On Mon, May 9, 2011 at 8:50 PM, Juan Carlos Garza
<[email protected]> wrote:
> Hi,
>
> On Mon, May 9, 2011 at 3:32 PM, Mohammed Shafi <[email protected]> wrote:
>> On Mon, May 9, 2011 at 5:16 PM, Ignacy Gawedzki <[email protected]> wrote:
>>> On Fri, May 06, 2011 at 10:35:08AM +0530, thus spake Mohammed Shafi:
>>>> On Thu, May 5, 2011 at 9:20 PM, Andreas Hartmann
>>>> <[email protected]> wrote:
>>>> > Hello,
>>>> >
>>>> > since May, there is a compile error in compat-wireless (against kernel
>>>> > 2.6.34):
>>>
>>> I, as it appears with many others, have the same kind of trouble compiling the
>>> latests compat-wireless snapshots on some kernels (2.6.38 for me).
>
> I'm having this problem as well with a 2.6.24 kernel.
>
> The file /include/linux/rcupdate.h , and maybe other files too,
> need to be included in the compat-wireless package
> as the function kfree_rcu is actually introduced in a patch for
> the current linux-next tree.
>
> I guess they'll be fixing that soon, in the meantime try copying the missing
> ?file(s) manually.

Oh ok thanks!

>
>>>
>>> Obviously the kfree_rcu machinery should go into some compat/ source file. ?In
>>> the meantime, I personnaly reverted these changes (see attached patch) and it
>>> works just fine.
>>
>> I blindly used your patch and now the compat-wireless is compiling for me.
>> thanks a lot.
>>
>> with regards,
>> shafi
>>
>>>
>>> --
>>> /* This is not a comment */
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to [email protected]
>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>>
>
> --
> Juan Carlos Garza
>

Subject: Re: compile-error agg-tx.c: error: implicit declarat ion of function ‘kfree_rcu’

Hi,

On Mon, May 9, 2011 at 3:32 PM, Mohammed Shafi <[email protected]> wrote:
> On Mon, May 9, 2011 at 5:16 PM, Ignacy Gawedzki <[email protected]> wrote:
>> On Fri, May 06, 2011 at 10:35:08AM +0530, thus spake Mohammed Shafi:
>>> On Thu, May 5, 2011 at 9:20 PM, Andreas Hartmann
>>> <[email protected]> wrote:
>>> > Hello,
>>> >
>>> > since May, there is a compile error in compat-wireless (against kernel
>>> > 2.6.34):
>>
>> I, as it appears with many others, have the same kind of trouble compiling the
>> latests compat-wireless snapshots on some kernels (2.6.38 for me).

I'm having this problem as well with a 2.6.24 kernel.

The file /include/linux/rcupdate.h , and maybe other files too,
need to be included in the compat-wireless package
as the function kfree_rcu is actually introduced in a patch for
the current linux-next tree.

I guess they'll be fixing that soon, in the meantime try copying the missing
file(s) manually.

>>
>> Obviously the kfree_rcu machinery should go into some compat/ source file. ?In
>> the meantime, I personnaly reverted these changes (see attached patch) and it
>> works just fine.
>
> I blindly used your patch and now the compat-wireless is compiling for me.
> thanks a lot.
>
> with regards,
> shafi
>
>>
>> --
>> /* This is not a comment */
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>

--
Juan Carlos Garza

2011-05-09 13:32:48

by Mohammed Shafi

[permalink] [raw]
Subject: Re: compile-error agg-tx.c: error: implicit declarat ion of function ‘kfree_rcu’

On Mon, May 9, 2011 at 5:16 PM, Ignacy Gawedzki <[email protected]> wrote:
> On Fri, May 06, 2011 at 10:35:08AM +0530, thus spake Mohammed Shafi:
>> On Thu, May 5, 2011 at 9:20 PM, Andreas Hartmann
>> <[email protected]> wrote:
>> > Hello,
>> >
>> > since May, there is a compile error in compat-wireless (against kernel
>> > 2.6.34):
>
> I, as it appears with many others, have the same kind of trouble compiling the
> latests compat-wireless snapshots on some kernels (2.6.38 for me).
>
> Obviously the kfree_rcu machinery should go into some compat/ source file. ?In
> the meantime, I personnaly reverted these changes (see attached patch) and it
> works just fine.

I blindly used your patch and now the compat-wireless is compiling for me.
thanks a lot.

with regards,
shafi

>
> --
> /* This is not a comment */
>