On Sat, Mar 26, 2022 at 7:39 PM Benjamin Stürz <[email protected]> wrote:
>
> This replaces comments with C99's designated
> initializers because the kernel supports them now.
Does it follow the conventions which are accepted in the ACPI CA project?
--
With Best Regards,
Andy Shevchenko
-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Sunday, March 27, 2022 1:00 PM
To: Benjamin Stürz <[email protected]>
Cc: Andrew Lunn <[email protected]>; Sebastian Hesselbarth <[email protected]>; Gregory Clement <[email protected]>; Russell King - ARM Linux <[email protected]>; [email protected]; Krzysztof Kozlowski <[email protected]>; Alim Akhtar <[email protected]>; Thomas Gleixner <[email protected]>; Ingo Molnar <[email protected]>; Borislav Petkov <[email protected]>; Dave Hansen <[email protected]>; H. Peter Anvin <[email protected]>; Moore, Robert <[email protected]>; Wysocki, Rafael J <[email protected]>; Len Brown <[email protected]>; [email protected]; Harald Welte <[email protected]>; Arnd Bergmann <[email protected]>; Greg Kroah-Hartman <[email protected]>; Mauro Carvalho Chehab <[email protected]>; Luck, Tony <[email protected]>; James Morse <[email protected]>; Robert Richter <[email protected]>; Linus Walleij <[email protected]>; Bartosz Golaszewski <[email protected]>; [email protected]; [email protected]; Jason Gunthorpe <[email protected]>; Pali Rohár <[email protected]>; Dmitry Torokhov <[email protected]>; Karsten Keil <[email protected]>; Benjamin Herrenschmidt <[email protected]>; Frederic Barrat <[email protected]>; Andrew Donnellan <[email protected]>; David S. Miller <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Nicolas Pitre <[email protected]>; Loic Poulain <[email protected]>; Kalle Valo <[email protected]>; Ping-Ke Shih <[email protected]>; Bjorn Helgaas <[email protected]>; linux-arm Mailing List <[email protected]>; Linux Kernel Mailing List <[email protected]>; Linux Samsung SOC <[email protected]>; [email protected]; ACPI Devel Maling List <[email protected]>; open list:ACPI COMPONENT ARCHITECTURE (ACPICA) <[email protected]>; [email protected]; netdev <[email protected]>; [email protected]; open list:GPIO SUBSYSTEM <[email protected]>; open list:HFI1 DRIVER <[email protected]>; linux-input <[email protected]>; open list:LINUX FOR POWERPC PA SEMI PWRFICIENT <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 05/22] acpica: Replace comments with C99 initializers
On Sat, Mar 26, 2022 at 7:39 PM Benjamin Stürz <[email protected]> wrote:
>
> This replaces comments with C99's designated initializers because the
> kernel supports them now.
Does it follow the conventions which are accepted in the ACPI CA project?
No, it doesn't. ACPICA must work with many compilers, some of which are rather old. So, we don't support these initializers.
Bob
--
With Best Regards,
Andy Shevchenko
On Sun, Mar 27, 2022 at 10:59:54PM +0300, Andy Shevchenko wrote:
> On Sat, Mar 26, 2022 at 7:39 PM Benjamin St?rz <[email protected]> wrote:
> >
> > This replaces comments with C99's designated
> > initializers because the kernel supports them now.
>
> Does it follow the conventions which are accepted in the ACPI CA project?
Why would ACPI CA be allowed to make up it's own conventions? And as
you might imply not allow using a very useful and more than 20 year old
C feature? This kind of BS need to stop.