2023-12-20 09:02:54

by David Lin

Subject: [PATCH] wifi: mwifiex: fix uninitialized firmware_stat

Variable firmware_stat is possilbe to be used without initialization.

Signed-off-by: David Lin <[email protected]>
Fixes: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready")
Cc: [email protected]
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/r/[email protected]/
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index ef3e68d1059c..75f53c2f1e1f 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -779,7 +779,7 @@ static int mwifiex_check_fw_status(struct mwifiex_adapter *adapter,
{
struct sdio_mmc_card *card = adapter->card;
int ret = 0;
- u16 firmware_stat;
+ u16 firmware_stat = 0;
u32 tries;

for (tries = 0; tries < poll_num; tries++) {

base-commit: 783004b6dbda2cfe9a552a4cc9c1d168a2068f6c
prerequisite-patch-id: ee10b03f813ab1e72d05c59aef4e07a26afdf678
--
2.25.1

2023-12-20 23:12:54

by Jeff Johnson

Subject: Re: [PATCH] wifi: mwifiex: fix uninitialized firmware_stat

On 12/20/2023 1:01 AM, David Lin wrote:
> Variable firmware_stat is possilbe to be used without initialization.

s/possilbe /possible /

Kalle can probably fix when he picks it up

2023-12-21 01:35:08

by David Lin

Subject: RE: [EXT] Re: [PATCH] wifi: mwifiex: fix uninitialized firmware_stat

> From: Jeff Johnson <[email protected]>
> Sent: Thursday, December 21, 2023 7:03 AM
> To: David Lin <[email protected]>; [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Pete Hsieh
> <[email protected]>; [email protected]; kernel test robot
> <[email protected]>; Dan Carpenter <[email protected]>
> Subject: [EXT] Re: [PATCH] wifi: mwifiex: fix uninitialized firmware_stat
>
> On 12/20/2023 1:01 AM, David Lin wrote:
> > Variable firmware_stat is possilbe to be used without initialization.
>
> s/possilbe /possible /
>
> Kalle can probably fix when he picks it up


Sorry. Thanks for your correction.

2023-12-21 01:42:36

by Brian Norris

Subject: Re: [PATCH] wifi: mwifiex: fix uninitialized firmware_stat

On Wed, Dec 20, 2023 at 1:02 AM David Lin <[email protected]> wrote:
>
> Variable firmware_stat is possilbe to be used without initialization.
>
> Signed-off-by: David Lin <[email protected]>
> Fixes: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready")
> Cc: [email protected]
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Closes: https://lore.kernel.org/r/[email protected]/

Acked-by: Brian Norris <[email protected]>