2023-12-13 14:17:53

by Naresh Kamboju

Subject: next: arm64: gcc-8-defconfig - failed - net/wireless/shipped-certs.c:92:1: error: expected '}' before numeric constant

Following gcc-8 builds failed on Linux next-20231213 tag.

arm64: gcc-8-defconfig - failed
arm: gcc-8-defconfig - failed

arm64: gcc-13-defconfig - Pass
arm: gcc-13-defconfig - pass

Good: next-20231212
Bad: next-20231213

Build log:
-------------
net/wireless/shipped-certs.c:92:1: error: expected '}' before numeric constant
0x30, 0x82, 0x02, 0xa4, 0x30, 0x82, 0x01, 0x8c,
^~~~
net/wireless/shipped-certs.c:2:34: note: to match this '{'
const u8 shipped_regdb_certs[] = {

Reported-by: Linux Kernel Functional Testing <[email protected]>


Steps to reproduce:

# tuxmake --runtime podman --target-arch arm64 --toolchain gcc-8
--kconfig defconfig
^

Links:
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20231213/testrun/21662494/suite/build/test/gcc-8-defconfig/log
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20231213/testrun/21662494/suite/build/test/gcc-8-defconfig/history/
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2ZTTGLGEcQd1MiMrE1GgDyvdrla/



--
Linaro LKFT
https://lkft.linaro.org

2023-12-13 15:00:23

by Biju Das

Subject: Re: next: arm64: gcc-8-defconfig - failed - net/wireless/shipped-certs.c:92:1: error: expected '}' before numeric constant

Hi All,

I am also seeing similar issue[1] with below tool chain[2] on linux-next.

[1]
gcc-arm-10.3-2021.07-x86_64-aarch64-none-linux-gnu

Looks like latest code in net/wireless is not buildable with older toolchain.

Can we revert the change to unblock build failure on next?


[1]
https://lore.kernel.org/all/CA+G9fYv9j08=+-CpJdtAV1z9-8KYbYcH8YOvWjbz4TgP7pB2TA@mail.gmail.com/

Cheers,
Biju

2023-12-14 09:32:12

by Berg, Johannes

Subject: RE: Re: next: arm64: gcc-8-defconfig - failed - net/wireless/shipped-certs.c:92:1: error: expected '}' before numeric constant

>
> FYI, This issue is seen on today next as well, the generated code[2] is missing
> a comma leading to Build failure. Is it a requirement to use latest toolchain for
> linux-next?

Well, no surprise since I was out yesterday????

The issue isn't the toolchain or anything - it's related to the ordering in which the two files are returned when make checks for them... I've pushed a fix.

johannes
--

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, http://www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928