2011-09-16 10:08:49

by Vivek Natarajan

Subject: [PATCH] ath6kl: Indicate the roaming capability of the firmware

Signed-off-by: Vivek Natarajan <[email protected]>
---
drivers/net/wireless/ath/ath6kl/init.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
index b9b13a0..38d7e94 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -1494,6 +1494,8 @@ static int ath6kl_init(struct net_device *dev)
if (!status)
goto ath6kl_init_done;

+ ar->wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_FW_ROAM;
+
err_htc_stop:
ath6kl_htc_stop(ar->htc_target);
err_rxbuf_cleanup:
--
1.7.1

2011-09-19 06:53:00

by Kalle Valo

Subject: Re: [PATCH] ath6kl: Indicate the roaming capability of the firmware

On 09/16/2011 01:08 PM, Vivek Natarajan wrote:
> Signed-off-by: Vivek Natarajan <[email protected]>
> ---
> drivers/net/wireless/ath/ath6kl/init.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index b9b13a0..38d7e94 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1494,6 +1494,8 @@ static int ath6kl_init(struct net_device *dev)
> if (!status)
> goto ath6kl_init_done;
>
> + ar->wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_FW_ROAM;
> +
> err_htc_stop:
> ath6kl_htc_stop(ar->htc_target);
> err_rxbuf_cleanup:

You have to document what this change means in practise and what issue
it is actually fixing. (firmware/wpas getting out of sync, wpas not
handling roaming after the flag is set etc.)

Also please address Sam's comment.

Kalle

2011-09-16 18:55:04

by Sam Leffler

Subject: Re: [PATCH] ath6kl: Indicate the roaming capability of the firmware

On Fri, Sep 16, 2011 at 3:08 AM, Vivek Natarajan
<[email protected]> wrote:
> Signed-off-by: Vivek Natarajan <[email protected]>
> ---
> ?drivers/net/wireless/ath/ath6kl/init.c | ? ?2 ++
> ?1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index b9b13a0..38d7e94 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1494,6 +1494,8 @@ static int ath6kl_init(struct net_device *dev)
> ? ? ? ?if (!status)
> ? ? ? ? ? ? ? ?goto ath6kl_init_done;
>
> + ? ? ? ar->wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_FW_ROAM;
> +
> ?err_htc_stop:
> ? ? ? ?ath6kl_htc_stop(ar->htc_target);
> ?err_rxbuf_cleanup:
> --
> 1.7.1

This is wrong. Here is the working version I pointed you at:

http://git.chromium.org/gitweb/?p=chromiumos/third_party/kernel.git;a=commit;h=b1785f108aee6d861d807701bcb6152c7145ded7