2012-04-08 16:00:29

by Lorenzo Bianconi

Subject: [PATCH] rtlwifi: ID for Belkin Surf N300 XR

Hi,

I added ID for Belkin Surf N300 XR wireless usb adapter to rtlwifi driver.

Regards

Lorenzo

Signed-off-by: Lorenzo Bianconi <[email protected]>
---
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
@@ -340,6 +340,7 @@
/****** 8192CU ********/
{RTL_USB_DEVICE(0x050d, 0x2102, rtl92cu_hal_cfg)}, /*Belcom-Sercomm*/
{RTL_USB_DEVICE(0x050d, 0x2103, rtl92cu_hal_cfg)}, /*Belcom-Edimax*/
+ {RTL_USB_DEVICE(0x050d, 0x1004, rtl92cu_hal_cfg)}, /*Belkin-SurfN300*/
{RTL_USB_DEVICE(0x0586, 0x341f, rtl92cu_hal_cfg)}, /*Zyxel -Abocom*/
{RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
{RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/

--
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep

2012-04-08 17:37:25

by Lorenzo Bianconi

Subject: Re: [PATCH] rtlwifi: ID for Belkin Surf N300 XR

> On 04/08/2012 11:00 AM, Lorenzo Bianconi wrote:
>>
>> Hi,
>>
>> I added ID for Belkin Surf N300 XR wireless usb adapter to rtlwifi driver.
>>
>> Regards
>>
>> Lorenzo
>>
>> Signed-off-by: Lorenzo Bianconi<[email protected]>
>> ---
>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>> @@ -340,6 +340,7 @@
>> ? ? ? ?/****** 8192CU ********/
>> ? ? ? ?{RTL_USB_DEVICE(0x050d, 0x2102, rtl92cu_hal_cfg)},
>> /*Belcom-Sercomm*/
>> ? ? ? ?{RTL_USB_DEVICE(0x050d, 0x2103, rtl92cu_hal_cfg)},
>> /*Belcom-Edimax*/
>> + ? ? ? {RTL_USB_DEVICE(0x050d, 0x1004, rtl92cu_hal_cfg)},
>> /*Belkin-SurfN300*/
>> ? ? ? ?{RTL_USB_DEVICE(0x0586, 0x341f, rtl92cu_hal_cfg)}, /*Zyxel
>> -Abocom*/
>> ? ? ? ?{RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
>> ? ? ? ?{RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai
>> -Abocom*/
>
>
> Thanks for the patch, but I have some comments.
>
> Anything you state above the first --- delimiter ends up in the permanent
> commit message in the kernel. I doubt that you wanted your little note to be
> in that category.
>
> I try to keep the USB IDs sorted by device type, and in numerical order
> within a type. Are you sure your device is an 8192CU, and not an 8188CU?
> Belcom has used both. Is the one you have an F7D2101? Does 'lsusb' say
> anything about what chip is used?
>
> Larry

My device is F9L1004az. lsusb reports just Vendor and Product ID. I
suppose the device is 8192CU because Windows driver is rtl8192cu.

I will rewrite the patch respecting the numerical order

Regards

Lorenzo

2012-04-08 17:52:52

by Larry Finger

Subject: Re: [PATCH] rtlwifi: ID for Belkin Surf N300 XR

On 04/08/2012 12:37 PM, Lorenzo Bianconi wrote:
>
> My device is F9L1004az. lsusb reports just Vendor and Product ID. I
> suppose the device is 8192CU because Windows driver is rtl8192cu.
>
> I will rewrite the patch respecting the numerical order

Driver rtl8192cu is used for both RTL8192CU and RTL8188CU; however, in the
absence of any other info, putting the new device in the 8192CU table will be OK.

Thanks,

Larry

2012-04-08 16:46:16

by Larry Finger

Subject: Re: [PATCH] rtlwifi: ID for Belkin Surf N300 XR

On 04/08/2012 11:00 AM, Lorenzo Bianconi wrote:
> Hi,
>
> I added ID for Belkin Surf N300 XR wireless usb adapter to rtlwifi driver.
>
> Regards
>
> Lorenzo
>
> Signed-off-by: Lorenzo Bianconi<[email protected]>
> ---
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
> @@ -340,6 +340,7 @@
> /****** 8192CU ********/
> {RTL_USB_DEVICE(0x050d, 0x2102, rtl92cu_hal_cfg)}, /*Belcom-Sercomm*/
> {RTL_USB_DEVICE(0x050d, 0x2103, rtl92cu_hal_cfg)}, /*Belcom-Edimax*/
> + {RTL_USB_DEVICE(0x050d, 0x1004, rtl92cu_hal_cfg)}, /*Belkin-SurfN300*/
> {RTL_USB_DEVICE(0x0586, 0x341f, rtl92cu_hal_cfg)}, /*Zyxel -Abocom*/
> {RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
> {RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/

Thanks for the patch, but I have some comments.

Anything you state above the first --- delimiter ends up in the permanent commit
message in the kernel. I doubt that you wanted your little note to be in that
category.

I try to keep the USB IDs sorted by device type, and in numerical order within a
type. Are you sure your device is an 8192CU, and not an 8188CU? Belcom has used
both. Is the one you have an F7D2101? Does 'lsusb' say anything about what chip
is used?

Larry