2012-04-22 21:59:34

by Hauke Mehrtens

[permalink] [raw]
Subject: [PATCH 1/2] compat: add module_pci_driver

module_pci_driver is needed to register the pci driver to the pci sub system.
---
include/linux/compat-3.4.h | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/include/linux/compat-3.4.h b/include/linux/compat-3.4.h
index e82e52f..1b72374 100644
--- a/include/linux/compat-3.4.h
+++ b/include/linux/compat-3.4.h
@@ -62,6 +62,19 @@ static inline void eth_hw_addr_random(struct net_device *dev)
#endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,31)) */
#endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,12)) */

+/* source include/linux/pci.h */
+/**
+ * module_pci_driver() - Helper macro for registering a PCI driver
+ * @__pci_driver: pci_driver struct
+ *
+ * Helper macro for PCI drivers which do not do anything special in module
+ * init/exit. This eliminates a lot of boilerplate. Each module may only
+ * use this macro once, and calling it replaces module_init() and module_exit()
+ */
+#define module_pci_driver(__pci_driver) \
+ module_driver(__pci_driver, pci_register_driver, \
+ pci_unregister_driver)
+
#endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(3,4,0)) */

#endif /* LINUX_5_4_COMPAT_H */
--
1.7.9.5



2012-04-23 23:06:14

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [PATCH 1/2] compat: add module_pci_driver

On Mon, Apr 23, 2012 at 3:19 PM, Hauke Mehrtens <[email protected]> wrote:
> On 04/23/2012 11:09 PM, Luis R. Rodriguez wrote:
>> On Sun, Apr 22, 2012 at 2:59 PM, Hauke Mehrtens <[email protected]> wrote:
>>> module_pci_driver is needed to register the pci driver to the pci sub system.
>>
>> Thanks ! I see no Signed-off-by tag on these though, I use the SOB tag
>> just as the kernel and other projects us it, the meaning of it is the
>> same, under the "Developer's Certificate of Origin 1.1":
>>
>> http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html
>>
>> Do you SOB these patches?
>>
>>   Luis
> Hi Luis,
>
> I SOB these patches and the patches for compat-wireless I send also on
> that day. I forgot to add the option to generate a SOB line in git
> format-patch this time. Should I resend them with a SOB line or do you
> take this late SOB in this mail?

I take this late SOB, thanks!

Luis

2012-04-23 22:19:38

by Hauke Mehrtens

[permalink] [raw]
Subject: Re: [PATCH 1/2] compat: add module_pci_driver

On 04/23/2012 11:09 PM, Luis R. Rodriguez wrote:
> On Sun, Apr 22, 2012 at 2:59 PM, Hauke Mehrtens <[email protected]> wrote:
>> module_pci_driver is needed to register the pci driver to the pci sub system.
>
> Thanks ! I see no Signed-off-by tag on these though, I use the SOB tag
> just as the kernel and other projects us it, the meaning of it is the
> same, under the "Developer's Certificate of Origin 1.1":
>
> http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html
>
> Do you SOB these patches?
>
> Luis
Hi Luis,

I SOB these patches and the patches for compat-wireless I send also on
that day. I forgot to add the option to generate a SOB line in git
format-patch this time. Should I resend them with a SOB line or do you
take this late SOB in this mail?

Hauke

2012-04-22 21:59:34

by Hauke Mehrtens

[permalink] [raw]
Subject: [PATCH 2/2] compat: add dummy file kmemleak.h

Some drivers are including kmemleak.h directly and this causes a build
problem on old kernel versions as it is not available on all.
---
include/linux/kmemleak.h | 5 +++++
1 file changed, 5 insertions(+)
create mode 100644 include/linux/kmemleak.h

diff --git a/include/linux/kmemleak.h b/include/linux/kmemleak.h
new file mode 100644
index 0000000..83bd199
--- /dev/null
+++ b/include/linux/kmemleak.h
@@ -0,0 +1,5 @@
+#include <linux/version.h>
+
+#if (LINUX_VERSION_CODE > KERNEL_VERSION(2,6,30))
+#include_next <linux/kmemleak.h>
+#endif /* (LINUX_VERSION_CODE > KERNEL_VERSION(2,6,25)) */
--
1.7.9.5


2012-04-23 21:10:01

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [PATCH 1/2] compat: add module_pci_driver

On Sun, Apr 22, 2012 at 2:59 PM, Hauke Mehrtens <[email protected]> wrote:
> module_pci_driver is needed to register the pci driver to the pci sub system.

Thanks ! I see no Signed-off-by tag on these though, I use the SOB tag
just as the kernel and other projects us it, the meaning of it is the
same, under the "Developer's Certificate of Origin 1.1":

http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html

Do you SOB these patches?

Luis