2012-08-10 20:58:35

by Andy Gospodarek

Subject: [PATCH] compat: fixup error in no_printk definition

What initially looked like a valid definition for the #define for
no_printk was not. This corrects the problem and the change that was
thought to correct it.

Signed-off-by: Andy Gospodarek <[email protected]>
---
include/linux/compat-2.6.36.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/compat-2.6.36.h b/include/linux/compat-2.6.36.h
index b6757c3..cd5e37c 100644
--- a/include/linux/compat-2.6.36.h
+++ b/include/linux/compat-2.6.36.h
@@ -99,9 +99,9 @@ struct pm_qos_request_list {
* gcc's format and side-effect checking.
*/
/* mask no_printk as RHEL6 backports this */
-#define no_printk(...) compat_no_printk(...)
+#define no_printk(a, ...) compat_no_printk(a, ##__VA_ARGS__)
static inline __attribute__ ((format (printf, 1, 2)))
-int compat_no_printk(const char *s, ...) { return 0; }
+int no_printk(const char *s, ...) { return 0; }

#ifndef alloc_workqueue
#define alloc_workqueue(name, flags, max_active) __create_workqueue(name, flags, max_active, 0)
--
1.7.1

2012-08-11 00:50:30

by Luis R. Rodriguez

Subject: Re: [PATCH] compat: fixup error in no_printk definition

On Fri, Aug 10, 2012 at 1:57 PM, Andy Gospodreak <[email protected]> wrote:
> What initially looked like a valid definition for the #define for
> no_printk was not. This corrects the problem and the change that was
> thought to correct it.
>
> Signed-off-by: Andy Gospodarek <[email protected]>

thanks, applied and pushed!