Hi All,
Lately simultaneous AP-STA functionality in mwifiex driver is not
working. I feel this has something to do with recent changes in
cfg80211.
If we associate mwifiex STA to external AP first and then try to start
mwifiex AP using hostapd(on different channel), we get ?EBUSY error
from cfg80211. This happens from path
nl80211_start_ap->cfg80211_can_use_chan. cfg80211_can_use_chan
returns EBUSY error. In our design if mwifiex STA is already
associated on some different channel, AP follows this channel and BSS
is started using STA channel settings. If we start hostapd on same
channel, BSS is successfully started, but association requests from
external station result in failure.
Please let me know if we are missing something while registering
n_iface and iface combinations. num_different_channels in
ieee80211_iface_combination has been advertised as 1.
Regards,
Avinash.
Hi,
On Fri, Aug 10, 2012 at 11:37 AM, Avinash Patil <[email protected]> wrote:
> Hi All,
>
> Lately simultaneous AP-STA functionality in mwifiex driver is not
> working. I feel this has something to do with recent changes in
> cfg80211.
>
> If we associate mwifiex STA to external AP first and then try to start
> mwifiex AP using hostapd(on different channel), we get ?EBUSY error
> from cfg80211. This happens from path
> nl80211_start_ap->cfg80211_can_use_chan. cfg80211_can_use_chan
> returns EBUSY error. In our design if mwifiex STA is already
> associated on some different channel, AP follows this channel and BSS
> is started using STA channel settings. If we start hostapd on same
> channel, BSS is successfully started, but association requests from
> external station result in failure.
i got the same EBUSY error when i tried to start a P2P-GO in a different
channel when my other concurrent STA is associated to some other channel.
first cfg80211_can_use_chan -> cfg80211_can_use_iftype_chan
when driver advertises num_different_channels as 1
it seems to be caught under the following logic
case CHAN_MODE_SHARED:
1077 for (i = 0; i <
CFG80211_MAX_NUM_DIFFERENT_CHANNELS; i++)
1078 if (!used_channels[i] ||
used_channels[i] == ch)
1079 break;
1080
1081 if (i == CFG80211_MAX_NUM_DIFFERENT_CHANNELS)
1082 return -EBUSY;
1083
1084 if (used_channels[i] == NULL) {
1085 used_channels[i] = ch;
1086 num_different_channels++;
1087 }
1088 break;
used_channels[1] is NULL
num_different_channels becomes '2' when STA vifs is already in some
other channel
the following check in interface_combination for loop seems to cause
the EBUSY error
1111 if (num_different_channels > c->num_different_channels)
1112 continue;
not sure why assoc req from external STA fails.
>
> Please let me know if we are missing something while registering
> n_iface and iface combinations. num_different_channels in
> ieee80211_iface_combination has been advertised as 1.
>
> Regards,
> Avinash.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
thanks,
shafi
Hi Avinash,
On Tue, Aug 14, 2012 at 5:26 PM, Avinash Patil <[email protected]> wrote:
> Hi Mohammed,
>
> Thanks for confirming regression on your side as well.
not sure, may be its by design(for p2p the operating channel
had to be decided from supplicant itself i suppose, rather than
cfg80211/driver).
when we try to operate some other vif in another channel, as driver
does not supports
mutl channel it need to show an error. for p2p case we can set channel
regulatory
in the conf file i suppose to avoid this.
yes Johannes/Michal will be able to clarify. i am going home and out
of office for a week :)
>
> I suspect patch from Michal Kazior [PATCH 12/13] cfg80211: add channel
> checking for iface combinations - has introduced this regression.
>
> Michal/Johannes,
>
> Can you please help here?
>
> I tried to set software_iftypes to NL80211_IFTYPE_STATION |
> NL80211_IFTYPE_AP during wiphy_register(). It didn't work.
> One more observation- if I comment num_different_channels++ statement
> inside first switch(chanmode) for CHAN_MODE_SHARED; AP-STA mode works
> fine.
>
> Regards,
> Avinash
>
>
>
> On Mon, Aug 13, 2012 at 11:05 AM, Mohammed Shafi
> <[email protected]> wrote:
>> Hi,
>>
>>
>> On Fri, Aug 10, 2012 at 11:37 AM, Avinash Patil <[email protected]> wrote:
>>> Hi All,
>>>
>>> Lately simultaneous AP-STA functionality in mwifiex driver is not
>>> working. I feel this has something to do with recent changes in
>>> cfg80211.
>>>
>>> If we associate mwifiex STA to external AP first and then try to start
>>> mwifiex AP using hostapd(on different channel), we get ?EBUSY error
>>> from cfg80211. This happens from path
>>> nl80211_start_ap->cfg80211_can_use_chan. cfg80211_can_use_chan
>>> returns EBUSY error. In our design if mwifiex STA is already
>>> associated on some different channel, AP follows this channel and BSS
>>> is started using STA channel settings. If we start hostapd on same
>>> channel, BSS is successfully started, but association requests from
>>> external station result in failure.
>>
>>
>> i got the same EBUSY error when i tried to start a P2P-GO in a different
>> channel when my other concurrent STA is associated to some other channel.
>> first cfg80211_can_use_chan -> cfg80211_can_use_iftype_chan
>> when driver advertises num_different_channels as 1
>> it seems to be caught under the following logic
>>
>> case CHAN_MODE_SHARED:
>> 1077 for (i = 0; i <
>> CFG80211_MAX_NUM_DIFFERENT_CHANNELS; i++)
>> 1078 if (!used_channels[i] ||
>> used_channels[i] == ch)
>> 1079 break;
>> 1080
>> 1081 if (i == CFG80211_MAX_NUM_DIFFERENT_CHANNELS)
>> 1082 return -EBUSY;
>> 1083
>> 1084 if (used_channels[i] == NULL) {
>> 1085 used_channels[i] = ch;
>> 1086 num_different_channels++;
>> 1087 }
>> 1088 break;
>>
>> used_channels[1] is NULL
>> num_different_channels becomes '2' when STA vifs is already in some
>> other channel
>>
>> the following check in interface_combination for loop seems to cause
>> the EBUSY error
>>
>> 1111 if (num_different_channels > c->num_different_channels)
>> 1112 continue;
>>
>> not sure why assoc req from external STA fails.
>>
>>
>>>
>>> Please let me know if we are missing something while registering
>>> n_iface and iface combinations. num_different_channels in
>>> ieee80211_iface_combination has been advertised as 1.
>>>
>>> Regards,
>>> Avinash.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>>> the body of a message to [email protected]
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>>
>> --
>> thanks,
>> shafi
--
thanks,
shafi
On Fri, 2012-08-10 at 11:37 +0530, Avinash Patil wrote:
> Hi All,
>
> Lately simultaneous AP-STA functionality in mwifiex driver is not
> working. I feel this has something to do with recent changes in
> cfg80211.
>
> If we associate mwifiex STA to external AP first and then try to start
> mwifiex AP using hostapd(on different channel), we get –EBUSY error
> from cfg80211. This happens from path
> nl80211_start_ap->cfg80211_can_use_chan. cfg80211_can_use_chan
> returns EBUSY error. In our design if mwifiex STA is already
> associated on some different channel, AP follows this channel and BSS
> is started using STA channel settings. If we start hostapd on same
> channel, BSS is successfully started, but association requests from
> external station result in failure.
>
> Please let me know if we are missing something while registering
> n_iface and iface combinations. num_different_channels in
> ieee80211_iface_combination has been advertised as 1.
Well, if the number of different channels is 1, why would you expect to
be able to start an AP on a different channel than the STA is currently
using? Hostapd should know (needs to, I think) what channel is actually
being used, so you should start it on the right channel I think?
I don't know why association requests would fail.
johannes
Hi Mohammed,
Thanks for confirming regression on your side as well.
I suspect patch from Michal Kazior [PATCH 12/13] cfg80211: add channel
checking for iface combinations - has introduced this regression.
Michal/Johannes,
Can you please help here?
I tried to set software_iftypes to NL80211_IFTYPE_STATION |
NL80211_IFTYPE_AP during wiphy_register(). It didn't work.
One more observation- if I comment num_different_channels++ statement
inside first switch(chanmode) for CHAN_MODE_SHARED; AP-STA mode works
fine.
Regards,
Avinash
On Mon, Aug 13, 2012 at 11:05 AM, Mohammed Shafi
<[email protected]> wrote:
> Hi,
>
>
> On Fri, Aug 10, 2012 at 11:37 AM, Avinash Patil <[email protected]> wrote:
>> Hi All,
>>
>> Lately simultaneous AP-STA functionality in mwifiex driver is not
>> working. I feel this has something to do with recent changes in
>> cfg80211.
>>
>> If we associate mwifiex STA to external AP first and then try to start
>> mwifiex AP using hostapd(on different channel), we get ?EBUSY error
>> from cfg80211. This happens from path
>> nl80211_start_ap->cfg80211_can_use_chan. cfg80211_can_use_chan
>> returns EBUSY error. In our design if mwifiex STA is already
>> associated on some different channel, AP follows this channel and BSS
>> is started using STA channel settings. If we start hostapd on same
>> channel, BSS is successfully started, but association requests from
>> external station result in failure.
>
>
> i got the same EBUSY error when i tried to start a P2P-GO in a different
> channel when my other concurrent STA is associated to some other channel.
> first cfg80211_can_use_chan -> cfg80211_can_use_iftype_chan
> when driver advertises num_different_channels as 1
> it seems to be caught under the following logic
>
> case CHAN_MODE_SHARED:
> 1077 for (i = 0; i <
> CFG80211_MAX_NUM_DIFFERENT_CHANNELS; i++)
> 1078 if (!used_channels[i] ||
> used_channels[i] == ch)
> 1079 break;
> 1080
> 1081 if (i == CFG80211_MAX_NUM_DIFFERENT_CHANNELS)
> 1082 return -EBUSY;
> 1083
> 1084 if (used_channels[i] == NULL) {
> 1085 used_channels[i] = ch;
> 1086 num_different_channels++;
> 1087 }
> 1088 break;
>
> used_channels[1] is NULL
> num_different_channels becomes '2' when STA vifs is already in some
> other channel
>
> the following check in interface_combination for loop seems to cause
> the EBUSY error
>
> 1111 if (num_different_channels > c->num_different_channels)
> 1112 continue;
>
> not sure why assoc req from external STA fails.
>
>
>>
>> Please let me know if we are missing something while registering
>> n_iface and iface combinations. num_different_channels in
>> ieee80211_iface_combination has been advertised as 1.
>>
>> Regards,
>> Avinash.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> thanks,
> shafi