2023-03-27 07:32:29

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: Build regressions/improvements in v6.3-rc4

On Mon, 27 Mar 2023, Geert Uytterhoeven wrote:
> JFYI, when comparing v6.3-rc4[1] to v6.3-rc3[3], the summaries are:
> - build errors: +9/-1

+ /kisskb/src/drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]: => 6163:45

sh4-gcc11/sh-allmodconfig
seen before

+ error: modpost: "ebus_dma_enable" [drivers/parport/parport_pc.ko] undefined!: => N/A
+ error: modpost: "ebus_dma_irq_enable" [drivers/parport/parport_pc.ko] undefined!: => N/A
+ error: modpost: "ebus_dma_prepare" [drivers/parport/parport_pc.ko] undefined!: => N/A
+ error: modpost: "ebus_dma_register" [drivers/parport/parport_pc.ko] undefined!: => N/A
+ error: modpost: "ebus_dma_request" [drivers/parport/parport_pc.ko] undefined!: => N/A
+ error: modpost: "ebus_dma_residue" [drivers/parport/parport_pc.ko] undefined!: => N/A
+ error: modpost: "ebus_dma_unregister" [drivers/parport/parport_pc.ko] undefined!: => N/A
+ error: modpost: "ns87303_lock" [drivers/parport/parport_pc.ko] undefined!: => N/A

sparc64-gcc11/sparc-allmodconfig
seen before

> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/197b6b60ae7bc51dd0814953c562833143b292aa/ (all 152 configs)
> [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/e8d018dd0257f744ca50a729e3d042cf2ec9da65/ (all 152 configs)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2023-04-04 21:19:07

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: Build regressions/improvements in v6.3-rc4

On Mon, 27 Mar 2023 at 08:29, Geert Uytterhoeven <[email protected]> wrote:
>
> On Mon, 27 Mar 2023, Geert Uytterhoeven wrote:
> > JFYI, when comparing v6.3-rc4[1] to v6.3-rc3[3], the summaries are:
> > - build errors: +9/-1
>
> + /kisskb/src/drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]: => 6163:45
>
> sh4-gcc11/sh-allmodconfig
> seen before
>
> + error: modpost: "ebus_dma_enable" [drivers/parport/parport_pc.ko] undefined!: => N/A
> + error: modpost: "ebus_dma_irq_enable" [drivers/parport/parport_pc.ko] undefined!: => N/A
> + error: modpost: "ebus_dma_prepare" [drivers/parport/parport_pc.ko] undefined!: => N/A
> + error: modpost: "ebus_dma_register" [drivers/parport/parport_pc.ko] undefined!: => N/A
> + error: modpost: "ebus_dma_request" [drivers/parport/parport_pc.ko] undefined!: => N/A
> + error: modpost: "ebus_dma_residue" [drivers/parport/parport_pc.ko] undefined!: => N/A
> + error: modpost: "ebus_dma_unregister" [drivers/parport/parport_pc.ko] undefined!: => N/A
> + error: modpost: "ns87303_lock" [drivers/parport/parport_pc.ko] undefined!: => N/A
>
> sparc64-gcc11/sparc-allmodconfig
> seen before

Tried sparc64 allmodconfig with gcc-11 and did not see the parport
errors with 6ab608fe852b ("Merge tag 'for-6.3-rc4-tag' of
git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux").
Is it still being seen?

--
Regards
Sudip

2023-04-04 22:53:01

by Randy Dunlap

[permalink] [raw]
Subject: Re: Build regressions/improvements in v6.3-rc4



On 4/4/23 14:16, Sudip Mukherjee wrote:
> On Mon, 27 Mar 2023 at 08:29, Geert Uytterhoeven <[email protected]> wrote:
>>
>> On Mon, 27 Mar 2023, Geert Uytterhoeven wrote:
>>> JFYI, when comparing v6.3-rc4[1] to v6.3-rc3[3], the summaries are:
>>> - build errors: +9/-1
>>
>> + /kisskb/src/drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]: => 6163:45
>>
>> sh4-gcc11/sh-allmodconfig
>> seen before
>>
>> + error: modpost: "ebus_dma_enable" [drivers/parport/parport_pc.ko] undefined!: => N/A
>> + error: modpost: "ebus_dma_irq_enable" [drivers/parport/parport_pc.ko] undefined!: => N/A
>> + error: modpost: "ebus_dma_prepare" [drivers/parport/parport_pc.ko] undefined!: => N/A
>> + error: modpost: "ebus_dma_register" [drivers/parport/parport_pc.ko] undefined!: => N/A
>> + error: modpost: "ebus_dma_request" [drivers/parport/parport_pc.ko] undefined!: => N/A
>> + error: modpost: "ebus_dma_residue" [drivers/parport/parport_pc.ko] undefined!: => N/A
>> + error: modpost: "ebus_dma_unregister" [drivers/parport/parport_pc.ko] undefined!: => N/A
>> + error: modpost: "ns87303_lock" [drivers/parport/parport_pc.ko] undefined!: => N/A
>>
>> sparc64-gcc11/sparc-allmodconfig
>> seen before
>
> Tried sparc64 allmodconfig with gcc-11 and did not see the parport
> errors with 6ab608fe852b ("Merge tag 'for-6.3-rc4-tag' of
> git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux").
> Is it still being seen?
>

This is reported at http://kisskb.ellerman.id.au/kisskb/buildresult/14905002/

I still see it on sparc32 using gcc-12.2.0.

The compiler info vs. the sparc-allmodconfig is confusing IMO.
I am compiling with sparc-linux, not sparc64-linux.

The .config file says:
# CONFIG_64BIT is not set
CONFIG_SPARC=y
CONFIG_SPARC32=y


--
~Randy

2023-04-05 00:09:30

by Randy Dunlap

[permalink] [raw]
Subject: Re: Build regressions/improvements in v6.3-rc4 (parport_pc)



On 4/4/23 15:40, Randy Dunlap wrote:
>
>
> On 4/4/23 14:16, Sudip Mukherjee wrote:
>> On Mon, 27 Mar 2023 at 08:29, Geert Uytterhoeven <[email protected]> wrote:
>>>
>>> On Mon, 27 Mar 2023, Geert Uytterhoeven wrote:
>>>> JFYI, when comparing v6.3-rc4[1] to v6.3-rc3[3], the summaries are:
>>>> - build errors: +9/-1
>>>
>>> + /kisskb/src/drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]: => 6163:45
>>>
>>> sh4-gcc11/sh-allmodconfig
>>> seen before
>>>
>>> + error: modpost: "ebus_dma_enable" [drivers/parport/parport_pc.ko] undefined!: => N/A
>>> + error: modpost: "ebus_dma_irq_enable" [drivers/parport/parport_pc.ko] undefined!: => N/A
>>> + error: modpost: "ebus_dma_prepare" [drivers/parport/parport_pc.ko] undefined!: => N/A
>>> + error: modpost: "ebus_dma_register" [drivers/parport/parport_pc.ko] undefined!: => N/A
>>> + error: modpost: "ebus_dma_request" [drivers/parport/parport_pc.ko] undefined!: => N/A
>>> + error: modpost: "ebus_dma_residue" [drivers/parport/parport_pc.ko] undefined!: => N/A
>>> + error: modpost: "ebus_dma_unregister" [drivers/parport/parport_pc.ko] undefined!: => N/A
>>> + error: modpost: "ns87303_lock" [drivers/parport/parport_pc.ko] undefined!: => N/A
>>>
>>> sparc64-gcc11/sparc-allmodconfig
>>> seen before
>>
>> Tried sparc64 allmodconfig with gcc-11 and did not see the parport
>> errors with 6ab608fe852b ("Merge tag 'for-6.3-rc4-tag' of
>> git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux").
>> Is it still being seen?
>>
>
> This is reported at http://kisskb.ellerman.id.au/kisskb/buildresult/14905002/
>
> I still see it on sparc32 using gcc-12.2.0.
>
> The compiler info vs. the sparc-allmodconfig is confusing IMO.
> I am compiling with sparc-linux, not sparc64-linux.
>
> The .config file says:
> # CONFIG_64BIT is not set
> CONFIG_SPARC=y
> CONFIG_SPARC32=y

It looks to me like we have 2 choices (though there may be others
that are more complicated):

(1) restrict PARPORT_PC to !SPARC32
This fixes the build errors.

(2) We could build ebus.o and some (new) binary that includes
ns87303_lock for SPARC32. They are currently only built for SPARC64.

I prefer option (1) unless we need to support PARPORT_PC on
Sparc32 (which I have no idea about). Patch for it is below for inspection.

---
From: Randy Dunlap <[email protected]>
Subject: [PATCH] parport_pc: don't allow driver for SPARC32

arch/sparc/kernel/ebus.o is only built for SPARC64.
ns87303_lock is only built for SPARC64.
Also, arch/sparc/include/asm/parport.h says that it is for sparc64.

Therefore don't allow PARPORT_PC to be built for SPARC32.

Fixes these build errors on SPARC32:

ERROR: modpost: "ebus_dma_irq_enable" [drivers/parport/parport_pc.ko] undefined!
ERROR: modpost: "ebus_dma_unregister" [drivers/parport/parport_pc.ko] undefined!
ERROR: modpost: "ebus_dma_register" [drivers/parport/parport_pc.ko] undefined!
ERROR: modpost: "ns87303_lock" [drivers/parport/parport_pc.ko] undefined!
ERROR: modpost: "ebus_dma_enable" [drivers/parport/parport_pc.ko] undefined!
ERROR: modpost: "ebus_dma_prepare" [drivers/parport/parport_pc.ko] undefined!
ERROR: modpost: "ebus_dma_request" [drivers/parport/parport_pc.ko] undefined!
ERROR: modpost: "ebus_dma_residue" [drivers/parport/parport_pc.ko] undefined!

Fixes: 66bcd06099bb ("parport_pc: Also enable driver for PCI systems")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Sudip Mukherjee <[email protected]>
Cc: Maciej W. Rozycki <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
Cc: Sam Ravnborg <[email protected]>
Cc: [email protected]
---
drivers/parport/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/parport/Kconfig b/drivers/parport/Kconfig
--- a/drivers/parport/Kconfig
+++ b/drivers/parport/Kconfig
@@ -42,7 +42,7 @@ if PARPORT

config PARPORT_PC
tristate "PC-style hardware"
- depends on ARCH_MIGHT_HAVE_PC_PARPORT || (PCI && !S390)
+ depends on ARCH_MIGHT_HAVE_PC_PARPORT || (PCI && !S390 && !SPARC32)
help
You should say Y here if you have a PC-style parallel port. All
IBM PC compatible computers and some Alphas have PC-style