Hello,
First of all I'm not sure what the policy of this community is on
typos. It's my first time contributing to iw :) If you consider this
too minor to fix, I understand. The package has a lot of amazing stuff
to it.
While reading through the output of `iw help`, I noticed that
"timestamp" was misspelled as "timstamp":
event [-t|-r] [-f]
Monitor events from the kernel.
-t - print timestamp
-r - print relative timstamp
-f - print full frame for auth/assoc etc.
The erroneous line seems to be
https://git.sipsolutions.net/iw.git/tree/event.c#n1175.
Thanks,
Ryan
On Mon, 2019-10-21 at 02:34 -0700, Ryan Adolf wrote:
> Hello,
>
> First of all I'm not sure what the policy of this community is on
> typos. It's my first time contributing to iw :) If you consider this
> too minor to fix, I understand. The package has a lot of amazing stuff
> to it.
Just submit a patch! Then the maintainers will decide whether it's
worth it or not. I, particularly, don't see why it wouldn't be taken.
--
Cheers,
Luca.
The patch is attached.
There's only one modified line in it: correcting the typo of timstamp
--> timestamp.
On Mon, Oct 21, 2019 at 1:07 PM Luca Coelho <[email protected]> wrote:
>
> On Mon, 2019-10-21 at 02:34 -0700, Ryan Adolf wrote:
> > Hello,
> >
> > First of all I'm not sure what the policy of this community is on
> > typos. It's my first time contributing to iw :) If you consider this
> > too minor to fix, I understand. The package has a lot of amazing stuff
> > to it.
>
> Just submit a patch! Then the maintainers will decide whether it's
> worth it or not. I, particularly, don't see why it wouldn't be taken.
>
> --
> Cheers,
> Luca.
>
Ryan Adolf <[email protected]> writes:
> The patch is attached.
> There's only one modified line in it: correcting the typo of timstamp
> --> timestamp.
The patches need to be submitted in certain format. Please carefully
read the documentation (a link in my signature below) how to submit
patches.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Ryan Adolf <[email protected]> writes:
> The patch is attached.
> There's only one modified line in it: correcting the typo of timstamp
> --> timestamp.
You'll probably need to send this as a properly formatted patch. Pretty
simple to do:
- Make you change (you already did that)
- Run 'git add event.c; git commit -s' and write a commit message; check
that the signed-off-by has your name and email address right.
- Run 'git format-patch HEAD^' which will produce a file
- Run 'git send-email <filename>.patch' to send it
You'll need some config to teach git how to talk to your SMTP server for
the last one to work. It should be straight-forward to to set it up with
gmail (just Google it).
-Toke