2015-02-10 08:27:14

by Marek Puzyniak

[permalink] [raw]
Subject: Re: [PATCH] ath10k: fix wmm params per vdev

On 6 February 2015 at 14:41, Marek Puzyniak <[email protected]> wrote:
> During wmm tests changing wmm parameters did not change anything.
> This was because of mismatch in WMM params per vdev command.
> WMM params per vdev uses different command structure than wmm params
> per pdev command. Also txop for per vdev settings has the
> same units as provided by mac80211.
>
> Patch concerns qca6174.
>
> Signed-off-by: Marek Puzyniak <[email protected]>

Kalle,

Please do not merge this patch yet. I need to clarify some side effects.
I will inform you about next steps.

Thanks,
Marek


2015-02-10 11:07:43

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath10k: fix wmm params per vdev

Marek Puzyniak <[email protected]> writes:

> On 6 February 2015 at 14:41, Marek Puzyniak <[email protected]> wrote:
>> During wmm tests changing wmm parameters did not change anything.
>> This was because of mismatch in WMM params per vdev command.
>> WMM params per vdev uses different command structure than wmm params
>> per pdev command. Also txop for per vdev settings has the
>> same units as provided by mac80211.
>>
>> Patch concerns qca6174.
>>
>> Signed-off-by: Marek Puzyniak <[email protected]>
>
> Kalle,
>
> Please do not merge this patch yet. I need to clarify some side effects.
> I will inform you about next steps.

Ok, I have dropped the patch. Please resend if it's ok to apply.

--
Kalle Valo