2016-02-11 06:47:15

by Ujjal Roy

Subject: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue

This patch fixes the incorrect indentation of the case label.

Signed-off-by: Ujjal Roy <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index e7adef7..cb0cf03 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -676,7 +676,7 @@ mwifiex_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
}
break;

- case MWIFIEX_BSS_ROLE_STA:
+ case MWIFIEX_BSS_ROLE_STA:
if (priv->media_connected) {
mwifiex_dbg(adapter, ERROR,
"cannot change wiphy params when connected");
--
1.9.1

2016-02-15 23:46:11

by Julian Calaby

Subject: Re: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue

Hi All,

On Thu, Feb 11, 2016 at 5:47 PM, Ujjal Roy <[email protected]> wrote:
> This patch fixes the incorrect indentation of the case label.
>
> Signed-off-by: Ujjal Roy <[email protected]>

Looks right to me.

Reviewed-by: Julian Calaby <[email protected]>

Thanks,

> ---
> drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index e7adef7..cb0cf03 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -676,7 +676,7 @@ mwifiex_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
> }
> break;
>
> - case MWIFIEX_BSS_ROLE_STA:
> + case MWIFIEX_BSS_ROLE_STA:
> if (priv->media_connected) {
> mwifiex_dbg(adapter, ERROR,
> "cannot change wiphy params when connected");
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

2016-02-11 09:35:44

by Kalle Valo

Subject: Re: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue

Ujjal Roy <[email protected]> writes:

> This patch fixes the incorrect indentation of the case label.
>
> Signed-off-by: Ujjal Roy <[email protected]>

A changelog is always recommended to have. Also for some reason your
name in patchwork is all caps:

Submitter UJJAL ROY

https://patchwork.kernel.org/patch/8276851/

Please try to fix that, but I don't know if that's even possible.

--
Kalle Valo

2016-02-11 06:47:20

by Ujjal Roy

Subject: [PATCH 3/3] mwifiex: Added missing spaces around brackets

This patch fixes the missing spaces issue in coding style.

Signed-off-by: Ujjal Roy <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/usb.c b/drivers/net/wireless/marvell/mwifiex/usb.c
index e43aff9..0510861 100644
--- a/drivers/net/wireless/marvell/mwifiex/usb.c
+++ b/drivers/net/wireless/marvell/mwifiex/usb.c
@@ -244,9 +244,9 @@ setup_for_next:
if (card->rx_cmd_ep == context->ep) {
mwifiex_usb_submit_rx_urb(context, size);
} else {
- if (atomic_read(&adapter->rx_pending) <= HIGH_RX_PENDING){
+ if (atomic_read(&adapter->rx_pending) <= HIGH_RX_PENDING) {
mwifiex_usb_submit_rx_urb(context, size);
- }else{
+ } else {
context->skb = NULL;
}
}
--
1.9.1

2016-02-24 19:27:00

by Ujjal Roy

Subject: Re: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue

I have sent all the patches again with my name in CAPITAL letter.
Please have a look.

Thanks,
UjjaL Roy


On Thu, Feb 11, 2016 at 3:05 PM, Kalle Valo <[email protected]> wrote:
> Ujjal Roy <[email protected]> writes:
>
>> This patch fixes the incorrect indentation of the case label.
>>
>> Signed-off-by: Ujjal Roy <[email protected]>
>
> A changelog is always recommended to have. Also for some reason your
> name in patchwork is all caps:
>
> Submitter UJJAL ROY
>
> https://patchwork.kernel.org/patch/8276851/
>
> Please try to fix that, but I don't know if that's even possible.
>
> --
> Kalle Valo

2016-02-11 15:02:34

by Ujjal Roy

Subject: Re: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue

On Thu, Feb 11, 2016 at 3:05 PM, Kalle Valo <[email protected]> wrote:
> Ujjal Roy <[email protected]> writes:
>
>> This patch fixes the incorrect indentation of the case label.
>>
>> Signed-off-by: Ujjal Roy <[email protected]>
>
> A changelog is always recommended to have. Also for some reason your
> name in patchwork is all caps:
>
> Submitter UJJAL ROY
>
> https://patchwork.kernel.org/patch/8276851/
>
> Please try to fix that, but I don't know if that's even possible.
>
> --
> Kalle Valo

I checked that and unable to change the name. If you have any
suggestion please share with me.

Thanks,
UjjaL Roy

2016-02-16 05:56:53

by Souptick Joarder

Subject: Re: [PATCH 3/3] mwifiex: Added missing spaces around brackets

Looks fine.

On Thu, Feb 11, 2016 at 12:17 PM, Ujjal Roy <[email protected]> wrote:
> This patch fixes the missing spaces issue in coding style.
>
> Signed-off-by: Ujjal Roy <[email protected]>
> ---
> drivers/net/wireless/marvell/mwifiex/usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/usb.c b/drivers/net/wireless/marvell/mwifiex/usb.c
> index e43aff9..0510861 100644
> --- a/drivers/net/wireless/marvell/mwifiex/usb.c
> +++ b/drivers/net/wireless/marvell/mwifiex/usb.c
> @@ -244,9 +244,9 @@ setup_for_next:
> if (card->rx_cmd_ep == context->ep) {
> mwifiex_usb_submit_rx_urb(context, size);
> } else {
> - if (atomic_read(&adapter->rx_pending) <= HIGH_RX_PENDING){
> + if (atomic_read(&adapter->rx_pending) <= HIGH_RX_PENDING) {
> mwifiex_usb_submit_rx_urb(context, size);
> - }else{
> + } else {
> context->skb = NULL;
> }
> }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

-Souptick

2016-02-11 06:47:17

by Ujjal Roy

Subject: [PATCH 2/3] mwifiex: Removed extra spaces before commas

This patch fixes spaces before commas issue in coding style.

Signed-off-by: Ujjal Roy <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 2 +-
drivers/net/wireless/marvell/mwifiex/uap_cmd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
index 6d0dc40..4d29cce 100644
--- a/drivers/net/wireless/marvell/mwifiex/pcie.c
+++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
@@ -1408,7 +1408,7 @@ mwifiex_pcie_send_boot_cmd(struct mwifiex_adapter *adapter, struct sk_buff *skb)
return -1;
}

- if (mwifiex_map_pci_memory(adapter, skb, skb->len , PCI_DMA_TODEVICE))
+ if (mwifiex_map_pci_memory(adapter, skb, skb->len, PCI_DMA_TODEVICE))
return -1;

buf_pa = MWIFIEX_SKB_DMA_ADDR(skb);
diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
index e791166..16d95b2 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
@@ -192,7 +192,7 @@ mwifiex_set_ht_params(struct mwifiex_private *priv,
}
priv->ap_11n_enabled = 1;
} else {
- memset(&bss_cfg->ht_cap , 0, sizeof(struct ieee80211_ht_cap));
+ memset(&bss_cfg->ht_cap, 0, sizeof(struct ieee80211_ht_cap));
bss_cfg->ht_cap.cap_info = cpu_to_le16(MWIFIEX_DEF_HT_CAP);
bss_cfg->ht_cap.ampdu_params_info = MWIFIEX_DEF_AMPDU;
}
--
1.9.1

2016-02-15 23:46:56

by Julian Calaby

Subject: Re: [PATCH 3/3] mwifiex: Added missing spaces around brackets

Hi All,

On Thu, Feb 11, 2016 at 5:47 PM, Ujjal Roy <[email protected]> wrote:
> This patch fixes the missing spaces issue in coding style.
>
> Signed-off-by: Ujjal Roy <[email protected]>

Looks right to me.

Reviewed-by: Julian Calaby <[email protected]>

Thanks,

> ---
> drivers/net/wireless/marvell/mwifiex/usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/usb.c b/drivers/net/wireless/marvell/mwifiex/usb.c
> index e43aff9..0510861 100644
> --- a/drivers/net/wireless/marvell/mwifiex/usb.c
> +++ b/drivers/net/wireless/marvell/mwifiex/usb.c
> @@ -244,9 +244,9 @@ setup_for_next:
> if (card->rx_cmd_ep == context->ep) {
> mwifiex_usb_submit_rx_urb(context, size);
> } else {
> - if (atomic_read(&adapter->rx_pending) <= HIGH_RX_PENDING){
> + if (atomic_read(&adapter->rx_pending) <= HIGH_RX_PENDING) {
> mwifiex_usb_submit_rx_urb(context, size);
> - }else{
> + } else {
> context->skb = NULL;
> }
> }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/