2012-08-24 03:31:24

by Chun-Yeow Yeoh

Subject: [PATCH] ath5k: set hw mfp capable flag for secured mesh

The IEEE80211_HW_MFP_CAPABLE is required to ensure the
successful key installation of CIPHER_AES_CMAC (currently
done in software) for secured mesh.

Signed-off-by: Chun-Yeow Yeoh <[email protected]>
---
drivers/net/wireless/ath/ath5k/base.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index a0a202d..4605fe1 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -2446,7 +2446,8 @@ ath5k_init_ah(struct ath5k_hw *ah, const struct ath_bus_ops *bus_ops)
hw->flags = IEEE80211_HW_RX_INCLUDES_FCS |
IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
IEEE80211_HW_SIGNAL_DBM |
- IEEE80211_HW_REPORTS_TX_ACK_STATUS;
+ IEEE80211_HW_REPORTS_TX_ACK_STATUS |
+ IEEE80211_HW_MFP_CAPABLE;

hw->wiphy->interface_modes =
BIT(NL80211_IFTYPE_AP) |
--
1.7.0.4

2012-08-24 10:07:30

by Chun-Yeow Yeoh

Subject: Re: [PATCH] ath5k: set hw mfp capable flag for secured mesh

> You shouldn't blindly set the flag though because it "is required". You
> really need to test that management frames aren't decrypted by the
> hardware erroneously.

Noted. Will take a look on alternative solution for this.

--
Chun-Yeow

2012-08-24 06:55:27

by Johannes Berg

Subject: Re: [PATCH] ath5k: set hw mfp capable flag for secured mesh

On Fri, 2012-08-24 at 11:29 +0800, Chun-Yeow Yeoh wrote:
> The IEEE80211_HW_MFP_CAPABLE is required to ensure the
> successful key installation of CIPHER_AES_CMAC (currently
> done in software) for secured mesh.

You shouldn't blindly set the flag though because it "is required". You
really need to test that management frames aren't decrypted by the
hardware erroneously.

johannes