2016-09-06 19:06:39

by Thomas Pedersen

[permalink] [raw]
Subject: [PATCH] ath10k: enable peer stats by default

IFTYPE_MESH_POINT need to rely on these for accurate path
selection metrics. Other modes will probably also find
them useful. Enabling peer stats has the side effect of
reducing max number of STAs from 128 to 118. There should
be negligible performance impact.

If users really need 128 STAs and don't mind losing out on
peer stats, they can still disable them:

echo 0 > debugfs/ieee80211/phyn/ath10k/peer_stats

Signed-off-by: Thomas Pedersen <[email protected]>
---
drivers/net/wireless/ath/ath10k/core.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index c9d163e..c0ab4f4 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -2145,6 +2145,9 @@ static void ath10k_core_register_work(struct work_struct *work)
struct ath10k *ar = container_of(work, struct ath10k, register_work);
int status;

+ /* peer stats are enabled by default */
+ set_bit(ATH10K_FLAG_PEER_STATS, &ar->dev_flags);
+
status = ath10k_core_probe_fw(ar);
if (status) {
ath10k_err(ar, "could not probe fw (%d)\n", status);
--
2.1.4


2016-09-13 12:26:39

by Kalle Valo

[permalink] [raw]
Subject: Re: ath10k: enable peer stats by default

"Pedersen, Thomas" <[email protected]> wrote:
> IFTYPE_MESH_POINT need to rely on these for accurate path
> selection metrics. Other modes will probably also find
> them useful. Enabling peer stats has the side effect of
> reducing max number of STAs from 128 to 118. There should
> be negligible performance impact.
>
> If users really need 128 STAs and don't mind losing out on
> peer stats, they can still disable them:
>
> echo 0 > debugfs/ieee80211/phyn/ath10k/peer_stats
>
> Signed-off-by: Thomas Pedersen <[email protected]>

Thanks, 1 patch applied to ath-next branch of ath.git:

8c1d7fa53166 ath10k: enable peer stats by default

--
Sent by pwcli
https://patchwork.kernel.org/patch/9317865/

2016-10-02 16:10:26

by Chun-Yeow Yeoh

[permalink] [raw]
Subject: Re: [PATCH] ath10k: enable peer stats by default

Hi, Thomas

On Wed, Sep 7, 2016 at 3:05 AM, Thomas Pedersen <[email protected]> wrote:
> IFTYPE_MESH_POINT need to rely on these for accurate path
> selection metrics. Other modes will probably also find

Both get expected throughput or get txrate are not available to
mac80211. So, is this useful by enabling it?

----
Chun-Yeow