Hi Amitkumar,
I have two observations:
1. I have found that in the command response path for host command
"HostCmd_CMD_802_11_EEPROM_ACCESS", a "0" value has been endian
converted. It can only be a safe futuristic approach for any non-zero
value there however! Otherwise, the endian conversion can be removed.
2. For multiple Host Commands (e.g HostCmd_CMD_802_11_EEPROM_ACCESS
etc.) "cpu_to_leX"-converted values are saved to driver. So
"leX_to_cpu" conversion is required too many times afterwards in
driver.
On the contrary, we can save the values to driver without any
conversion, and only command buffer(s) are prepared with endian
converted values. In this way we can gain some efficiency [code size /
time] by reducing the number of endian conversion considerably.
Please let me know your opinion on the above.
--
Thanks,
Prasun
Hi Amitkumar,
On Tue, Jun 21, 2016 at 3:47 PM, Amitkumar Karwar <[email protected]> wrote:
> I agree with your observations. We'll prepare a cleanup patch to address this.
>
> Regards,
> Amitkumar
I have already made some changes. I will send you a patch for this.
--
Thanks,
Prasun
SGkgUHJhc3VuLA0KDQo+IEZyb206IFByYXN1biBNYWl0aSBbbWFpbHRvOnByYXN1bm1haXRpODdA
Z21haWwuY29tXQ0KPiBTZW50OiBGcmlkYXksIEp1bmUgMTcsIDIwMTYgNjo0MiBQTQ0KPiBUbzog
QW1pdGt1bWFyIEthcndhcjsgTmlzaGFudCBTYXJtdWthZGFtDQo+IENjOiBMaW51eCBLZXJuZWw7
IExpbnV4IE5leHQ7IFdpRmkgTWFpbGluZyBMaXN0OyBKb2hhbm5lcyBCZXJnDQo+IFN1YmplY3Q6
IFtRdWVyeV0gbXdpZmlleDogZmV3IG9ic2VydmF0aW9ucyB0byByZWR1Y2UgbnVtYmVyIG9mIGVu
ZGlhbg0KPiBjb252ZXJzaW9ucw0KPiANCj4gSGkgQW1pdGt1bWFyLA0KPiANCj4gSSBoYXZlIHR3
byBvYnNlcnZhdGlvbnM6DQo+IA0KPiAxLiBJIGhhdmUgZm91bmQgdGhhdCBpbiB0aGUgY29tbWFu
ZCByZXNwb25zZSBwYXRoIGZvciBob3N0IGNvbW1hbmQNCj4gIkhvc3RDbWRfQ01EXzgwMl8xMV9F
RVBST01fQUNDRVNTIiwgYSAiMCIgdmFsdWUgaGFzIGJlZW4gZW5kaWFuDQo+IGNvbnZlcnRlZC4g
SXQgY2FuIG9ubHkgYmUgYSBzYWZlIGZ1dHVyaXN0aWMgYXBwcm9hY2ggZm9yIGFueSBub24temVy
bw0KPiB2YWx1ZSB0aGVyZSBob3dldmVyISBPdGhlcndpc2UsIHRoZSBlbmRpYW4gY29udmVyc2lv
biBjYW4gYmUgcmVtb3ZlZC4NCj4gDQo+IDIuIEZvciBtdWx0aXBsZSBIb3N0IENvbW1hbmRzIChl
LmcgSG9zdENtZF9DTURfODAyXzExX0VFUFJPTV9BQ0NFU1MNCj4gZXRjLikgImNwdV90b19sZVgi
LWNvbnZlcnRlZCB2YWx1ZXMgYXJlIHNhdmVkIHRvIGRyaXZlci4gU28gImxlWF90b19jcHUiDQo+
IGNvbnZlcnNpb24gaXMgcmVxdWlyZWQgdG9vIG1hbnkgdGltZXMgYWZ0ZXJ3YXJkcyBpbiBkcml2
ZXIuDQo+IE9uIHRoZSBjb250cmFyeSwgd2UgY2FuIHNhdmUgdGhlIHZhbHVlcyB0byBkcml2ZXIg
d2l0aG91dCBhbnkNCj4gY29udmVyc2lvbiwgYW5kIG9ubHkgY29tbWFuZCBidWZmZXIocykgYXJl
IHByZXBhcmVkIHdpdGggZW5kaWFuDQo+IGNvbnZlcnRlZCB2YWx1ZXMuIEluIHRoaXMgd2F5IHdl
IGNhbiBnYWluIHNvbWUgZWZmaWNpZW5jeSBbY29kZSBzaXplIC8NCj4gdGltZV0gYnkgcmVkdWNp
bmcgdGhlIG51bWJlciBvZiBlbmRpYW4gY29udmVyc2lvbiBjb25zaWRlcmFibHkuDQo+IA0KDQpJ
IGFncmVlIHdpdGggeW91ciBvYnNlcnZhdGlvbnMuIFdlJ2xsIHByZXBhcmUgYSBjbGVhbnVwIHBh
dGNoIHRvIGFkZHJlc3MgdGhpcy4NCg0KUmVnYXJkcywNCkFtaXRrdW1hcg0K