LinuxLists.cc - [PATCH] ath10k: disable burst mode

2015-03-25 08:17:30

Subject: [PATCH] ath10k: disable burst mode

Firmwares that indicate BURST_SERVICE as enabled
could overwrite some wmm parameters (eg. txop).
This could lead IOT and balancing issues.
Hence disable this by default.

Signed-off-by: Janusz Dziedzic <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 75dcd3a..b0d550b 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3079,6 +3079,7 @@ static int ath10k_set_antenna(struct ieee80211_hw *hw, u32 tx_ant, u32 rx_ant)
static int ath10k_start(struct ieee80211_hw *hw)
{
struct ath10k *ar = hw->priv;
+ u32 burst_enable;
int ret = 0;

/*
@@ -3133,6 +3134,15 @@ static int ath10k_start(struct ieee80211_hw *hw)
goto err_core_stop;
}

+ if (test_bit(WMI_SERVICE_BURST, ar->wmi.svc_map)) {
+ burst_enable = ar->wmi.pdev_param->burst_enable;
+ ret = ath10k_wmi_pdev_set_param(ar, burst_enable, 0);
+ if (ret) {
+ ath10k_warn(ar, "failed to disable burst: %d\n", ret);
+ goto err_core_stop;
+ }
+ }
+
if (ar->cfg_tx_chainmask)
__ath10k_set_antenna(ar, ar->cfg_tx_chainmask,
ar->cfg_rx_chainmask);
--
1.9.1

2015-03-31 11:22:54

by Janusz Dziedzic

[permalink] [raw]

Subject: Re: [PATCH] ath10k: disable burst mode

2015-03-30 15:15 GMT+02:00 Kalle Valo <[email protected]>:
> Janusz Dziedzic <[email protected]> writes:
>
>> Firmwares that indicate BURST_SERVICE as enabled
>> could overwrite some wmm parameters (eg. txop).
>> This could lead IOT and balancing issues.
>> Hence disable this by default.
>>
>> Signed-off-by: Janusz Dziedzic <[email protected]>
>
> There was a trivial conflict, please check my resolution in the pending
> branch.
>
Looks good. Thanks

BR
Janusz

2015-03-30 13:15:27

by Kalle Valo

[permalink] [raw]

Subject: Re: [PATCH] ath10k: disable burst mode

Janusz Dziedzic <[email protected]> writes:

> Firmwares that indicate BURST_SERVICE as enabled
> could overwrite some wmm parameters (eg. txop).
> This could lead IOT and balancing issues.
> Hence disable this by default.
>
> Signed-off-by: Janusz Dziedzic <[email protected]>

There was a trivial conflict, please check my resolution in the pending
branch.

--
Kalle Valo

2015-04-09 11:56:27

by Kalle Valo

[permalink] [raw]