2014-04-25 18:47:08

by Nickolay Ledovskikh

Subject: [PATCH] ath5k: Fix AR5K_PHY_TXPOWER_RATE_MAX register value setting.

I was reading ath5k power setting code and
noticed typing error in ath5k_hw_txpower function.
Invalid value was written to AR5K_PHY_TXPOWER_RATE_MAX
register.

Signed-off-by: Nikolay Ledovskikh <[email protected]>
---
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 1a2973b..f383b25 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -3709,8 +3709,8 @@ ath5k_hw_txpower(struct ath5k_hw *ah, struct ieee80211_channel *channel,
AR5K_REG_MS(AR5K_TUNE_MAX_TXPOWER, AR5K_TPC_CHIRP),
AR5K_TPC);
} else {
- ath5k_hw_reg_write(ah, AR5K_PHY_TXPOWER_RATE_MAX |
- AR5K_TUNE_MAX_TXPOWER, AR5K_PHY_TXPOWER_RATE_MAX);
+ ath5k_hw_reg_write(ah, AR5K_TUNE_MAX_TXPOWER,
+ AR5K_PHY_TXPOWER_RATE_MAX);
}

return 0;
--
Best regards, Nikolay Ledovskikh.

2014-04-25 19:15:46

by Nick Kossifidis

Subject: Re: [PATCH] ath5k: Fix AR5K_PHY_TXPOWER_RATE_MAX register value setting.

2014-04-25 19:53 GMT+01:00 Nickolay Ledovskikh <[email protected]>:
> I was reading ath5k power setting code and
> noticed typing error in ath5k_hw_txpower function.
> Invalid value was written to AR5K_PHY_TXPOWER_RATE_MAX
> register.
>
> Signed-off-by: Nikolay Ledovskikh <[email protected]>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
> index 1a2973b..f383b25 100644
> --- a/drivers/net/wireless/ath/ath5k/phy.c
> +++ b/drivers/net/wireless/ath/ath5k/phy.c
> @@ -3709,8 +3709,8 @@ ath5k_hw_txpower(struct ath5k_hw *ah, struct ieee80211_channel *channel,
> AR5K_REG_MS(AR5K_TUNE_MAX_TXPOWER, AR5K_TPC_CHIRP),
> AR5K_TPC);
> } else {
> - ath5k_hw_reg_write(ah, AR5K_PHY_TXPOWER_RATE_MAX |
> - AR5K_TUNE_MAX_TXPOWER, AR5K_PHY_TXPOWER_RATE_MAX);
> + ath5k_hw_reg_write(ah, AR5K_TUNE_MAX_TXPOWER,
> + AR5K_PHY_TXPOWER_RATE_MAX);
> }
>
> return 0;
> --
> Best regards, Nikolay Ledovskikh.

Acked-by: Nick Kossifidis <[email protected]>

--
GPG ID: 0xEE878588
As you read this post global entropy rises. Have Fun ;-)
Nick