2016-06-17 17:35:13

by weiyj_lk

Subject: [PATCH] staging: wilc1000: fix return value check in wlan_initialize_threads()

From: Wei Yongjun <[email protected]>

In case of error, the function kthread_run() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 4f93c11..b622510 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -717,10 +717,10 @@ static int wlan_initialize_threads(struct net_device *dev)

wilc->txq_thread = kthread_run(linux_wlan_txq_task, (void *)dev,
"K_TXQ_TASK");
- if (!wilc->txq_thread) {
+ if (IS_ERR(wilc->txq_thread)) {
netdev_err(dev, "couldn't create TXQ thread\n");
wilc->close = 0;
- return -ENOBUFS;
+ return PTR_ERR(wilc->txq_thread);
}
wait_for_completion(&wilc->txq_thread_started);

2016-06-23 01:33:37

by Julian Calaby

Subject: Re: [PATCH] staging: wilc1000: fix return value check in wlan_initialize_threads()

Hi All,

On Sat, Jun 18, 2016 at 3:34 AM, <[email protected]> wrote:
> From: Wei Yongjun <[email protected]>
>
> In case of error, the function kthread_run() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <[email protected]>

The return value of wlan_initialize_threads() is only checked to be
non-zero, so this looks right to me.

Reviewed-by: Julian Calaby <[email protected]>

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/