2012-03-20 21:49:53

by Stanislav Yakovlev

Subject: [PATCH] net/wireless: ipw2x00: fix a typo in wiphy struct initilization

Fix comment as well.

Signed-off-by: Stanislav Yakovlev <[email protected]>
---
drivers/net/wireless/ipw2x00/ipw2200.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
index 4fcdac6..2b02257 100644
--- a/drivers/net/wireless/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/ipw2x00/ipw2200.c
@@ -11507,9 +11507,9 @@ static int ipw_wdev_init(struct net_device *dev)
rc = -ENOMEM;
goto out;
}
- /* translate geo->bg to a_band.channels */
+ /* translate geo->a to a_band.channels */
for (i = 0; i < geo->a_channels; i++) {
- a_band->channels[i].band = IEEE80211_BAND_2GHZ;
+ a_band->channels[i].band = IEEE80211_BAND_5GHZ;
a_band->channels[i].center_freq = geo->a[i].freq;
a_band->channels[i].hw_value = geo->a[i].channel;
a_band->channels[i].max_power = geo->a[i].max_power;
--
1.7.2.5

2012-03-20 22:05:35

by Julian Calaby

Subject: Re: [PATCH] net/wireless: ipw2x00: fix a typo in wiphy struct initilization

Hi Stanislav,

On Wed, Mar 21, 2012 at 08:52, Stanislav Yakovlev
<[email protected]> wrote:
> Fix comment as well.
>
> Signed-off-by: Stanislav Yakovlev <[email protected]>
> ---
> diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
> index 4fcdac6..2b02257 100644
> --- a/drivers/net/wireless/ipw2x00/ipw2200.c
> +++ b/drivers/net/wireless/ipw2x00/ipw2200.c
> @@ -11507,9 +11507,9 @@ static int ipw_wdev_init(struct net_device *dev)
> ? ? ? ? ? ? ? ? ? ? ? ?rc = -ENOMEM;
> ? ? ? ? ? ? ? ? ? ? ? ?goto out;
> ? ? ? ? ? ? ? ?}
> - ? ? ? ? ? ? ? /* translate geo->bg to a_band.channels */
> + ? ? ? ? ? ? ? /* translate geo->a to a_band.channels */
> ? ? ? ? ? ? ? ?for (i = 0; i < geo->a_channels; i++) {
> - ? ? ? ? ? ? ? ? ? ? ? a_band->channels[i].band = IEEE80211_BAND_2GHZ;
> + ? ? ? ? ? ? ? ? ? ? ? a_band->channels[i].band = IEEE80211_BAND_5GHZ;

Looks good.

I'm surprised that nobody noticed this before, but someone did mention
that the 2x00 802.11a parts were extremely rare.

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/