2016-09-07 11:24:18

by Julian Calaby

Subject: Re: [PATCH] rsi: code clean-up

Hi,

On Wed, Sep 7, 2016 at 8:26 PM, Prameela Rani Garnepudi
<[email protected]> wrote:
> From 0c3da95dfac07df5dffb5e00bcd8a38f2f8491c9 Mon Sep 17 00:00:00 2001
> From: Prameela Rani Garnepudi <[email protected]>
> Date: Wed, 7 Sep 2016 15:28:43 +0530
> Subject: [PATCH] rsi: code clean-up

Describe what the changes are achieving.

You're also still sending this as a HTML email, there are instructions
on how to configure your email client to send plain text emails here:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/email-clients.txt

Because you're sending multi-part HTML emails, your emails are being
rejected by the mailing list.

> Signed-off-by: Prameela Rani Garnepudi
> <[email protected]>
> ---
> drivers/net/wireless/rsi/rsi_91x_core.c | 18 ++--
> drivers/net/wireless/rsi/rsi_91x_debugfs.c | 13 +--
> drivers/net/wireless/rsi/rsi_91x_mac80211.c | 81 +++++++++------
> drivers/net/wireless/rsi/rsi_91x_main.c | 16 ++-
> drivers/net/wireless/rsi/rsi_91x_mgmt.c | 155
> +++++++++++-----------------
> drivers/net/wireless/rsi/rsi_91x_sdio.c | 14 +--
> drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 11 +-
> drivers/net/wireless/rsi/rsi_91x_usb.c | 34 ++++--
> drivers/net/wireless/rsi/rsi_common.h | 2 +-
> drivers/net/wireless/rsi/rsi_debugfs.h | 3 +-
> drivers/net/wireless/rsi/rsi_main.h | 36 ++++---
> drivers/net/wireless/rsi/rsi_mgmt.h | 54 +++++-----
> drivers/net/wireless/rsi/rsi_sdio.h | 18 ++--
> 13 files changed, 228 insertions(+), 227 deletions(-)

You're doing a lot of stuff here, you really need to split this up
into several patches, e.g.
1. Fix the spelling mistakes
2. Add the new debug messages
etc. etc. etc.

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

2016-09-07 11:39:11

by Kalle Valo

Subject: Re: [PATCH] rsi: code clean-up

Julian Calaby <[email protected]> writes:

> Hi,
>
> On Wed, Sep 7, 2016 at 8:26 PM, Prameela Rani Garnepudi
> <[email protected]> wrote:
>> From 0c3da95dfac07df5dffb5e00bcd8a38f2f8491c9 Mon Sep 17 00:00:00 2001
>> From: Prameela Rani Garnepudi <[email protected]>
>> Date: Wed, 7 Sep 2016 15:28:43 +0530
>> Subject: [PATCH] rsi: code clean-up
>
> Describe what the changes are achieving.
>
> You're also still sending this as a HTML email, there are instructions
> on how to configure your email client to send plain text emails here:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/email-clients.txt
>
> Because you're sending multi-part HTML emails, your emails are being
> rejected by the mailing list.

I recommend to try to use git-send-email to submit patches, it makes
life so much more easier:

https://www.kernel.org/pub/software/scm/git/docs/git-send-email.html

--
Kalle Valo