2017-03-02 15:35:07

by Georgios Emmanouil

Subject: [PATCH 1/3] Staging:wilc1000:host_interface: Removed unnecessary blank line

Removed unnecessary blank line.

Signed-off-by: Georgios Emmanouil <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index c307cce..090fd43 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -287,7 +287,6 @@ static int wilc_enqueue_cmd(struct host_if_msg *msg)
return 0;
}

-
/* The u8IfIdx starts from 0 to NUM_CONCURRENT_IFC -1, but 0 index used as
* special purpose in wilc device, so we add 1 to the index to starts from 1.
* As a result, the returned index will be 1 to NUM_CONCURRENT_IFC.
--
2.1.4

2017-03-02 16:48:22

by Georgios Emmanouil

Subject: [PATCH 3/3] Staging:wilc1000:host_interface: Integrated two 'if' statements to a single 'if' statement

Removed unnecessary 'if' statement and integrated the condition to the
previous 'if' statement.

Signed-off-by: Georgios Emmanouil <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index bbe1a09..4936e80 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1355,13 +1355,11 @@ static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,
} else {
strConnectInfo.status = pstrConnectRespInfo->status;

- if (strConnectInfo.status == SUCCESSFUL_STATUSCODE) {
- if (pstrConnectRespInfo->ies) {
- strConnectInfo.resp_ies_len = pstrConnectRespInfo->ies_len;
- strConnectInfo.resp_ies = kmalloc(pstrConnectRespInfo->ies_len, GFP_KERNEL);
- memcpy(strConnectInfo.resp_ies, pstrConnectRespInfo->ies,
- pstrConnectRespInfo->ies_len);
- }
+ if (strConnectInfo.status == SUCCESSFUL_STATUSCODE && pstrConnectRespInfo->ies) {
+ strConnectInfo.resp_ies_len = pstrConnectRespInfo->ies_len;
+ strConnectInfo.resp_ies = kmalloc(pstrConnectRespInfo->ies_len, GFP_KERNEL);
+ memcpy(strConnectInfo.resp_ies, pstrConnectRespInfo->ies,
+ pstrConnectRespInfo->ies_len);
}

if (pstrConnectRespInfo) {
--
2.1.4

2017-03-04 22:51:02

by Julian Calaby

Subject: Re: [PATCH 3/3] Staging:wilc1000:host_interface: Integrated two 'if' statements to a single 'if' statement

Hi All,

On Fri, Mar 3, 2017 at 2:38 AM, Georgios Emmanouil <[email protected]> wrote:
> Removed unnecessary 'if' statement and integrated the condition to the
> previous 'if' statement.
>
> Signed-off-by: Georgios Emmanouil <[email protected]>

Reviewed-by: Julian Calaby <[email protected]>

> ---
> drivers/staging/wilc1000/host_interface.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

2017-03-02 15:46:39

by Georgios Emmanouil

Subject: [PATCH 2/3] Staging:wilc1000:host_interface: Fixed alignment to match open parenthesis

Fixed alignment to match open parenthesis.

Signed-off-by: Georgios Emmanouil <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 090fd43..bbe1a09 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1349,7 +1349,7 @@ static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,

if (u32RcvdAssocRespInfoLen != 0) {
s32Err = wilc_parse_assoc_resp_info(rcv_assoc_resp, u32RcvdAssocRespInfoLen,
- &pstrConnectRespInfo);
+ &pstrConnectRespInfo);
if (s32Err) {
netdev_err(vif->ndev, "wilc_parse_assoc_resp_info() returned error %d\n", s32Err);
} else {
--
2.1.4

2017-03-04 22:49:49

by Julian Calaby

Subject: Re: [PATCH 2/3] Staging:wilc1000:host_interface: Fixed alignment to match open parenthesis

Hi All,

On Fri, Mar 3, 2017 at 2:37 AM, Georgios Emmanouil <[email protected]> wrote:
> Fixed alignment to match open parenthesis.
>
> Signed-off-by: Georgios Emmanouil <[email protected]>

Reviewed-by: Julian Calaby <[email protected]>

> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

2017-03-04 22:49:23

by Julian Calaby

Subject: Re: [PATCH 1/3] Staging:wilc1000:host_interface: Removed unnecessary blank line

Hi All,

On Fri, Mar 3, 2017 at 2:35 AM, Georgios Emmanouil <[email protected]> wrote:
> Removed unnecessary blank line.
>
> Signed-off-by: Georgios Emmanouil <[email protected]>

Reviewed-by: Julian Calaby <[email protected]>

> ---
> drivers/staging/wilc1000/host_interface.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index c307cce..090fd43 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -287,7 +287,6 @@ static int wilc_enqueue_cmd(struct host_if_msg *msg)
> return 0;
> }
>
> -
> /* The u8IfIdx starts from 0 to NUM_CONCURRENT_IFC -1, but 0 index used as
> * special purpose in wilc device, so we add 1 to the index to starts from 1.
> * As a result, the returned index will be 1 to NUM_CONCURRENT_IFC.
> --
> 2.1.4
>



--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/