2015-10-17 20:04:44

by Paul McQuade

[permalink] [raw]
Subject: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

Removed empty spaces before/after parenthesis

Signed-off-by: Paul McQuade <[email protected]>
---
drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt61pci.h b/drivers/net/wireless/rt2x00/rt61pci.h
index 1442075..ab86415 100644
--- a/drivers/net/wireless/rt2x00/rt61pci.h
+++ b/drivers/net/wireless/rt2x00/rt61pci.h
@@ -138,14 +138,14 @@
#define PAIRWISE_TA_TABLE_BASE 0x1a00

#define SHARED_KEY_ENTRY(__idx) \
- ( SHARED_KEY_TABLE_BASE + \
- ((__idx) * sizeof(struct hw_key_entry)) )
+ (SHARED_KEY_TABLE_BASE + \
+ ((__idx) * sizeof(struct hw_key_entry)))
#define PAIRWISE_KEY_ENTRY(__idx) \
- ( PAIRWISE_KEY_TABLE_BASE + \
- ((__idx) * sizeof(struct hw_key_entry)) )
+ (PAIRWISE_KEY_TABLE_BASE + \
+ ((__idx) * sizeof(struct hw_key_entry)))
#define PAIRWISE_TA_ENTRY(__idx) \
- ( PAIRWISE_TA_TABLE_BASE + \
- ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
+ (PAIRWISE_TA_TABLE_BASE + \
+ ((__idx) * sizeof(struct hw_pairwise_ta_entry)))

struct hw_key_entry {
u8 key[16];
@@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
#define HW_BEACON_BASE3 0x2f00

#define HW_BEACON_OFFSET(__index) \
- ( HW_BEACON_BASE0 + (__index * 0x0100) )
+ (HW_BEACON_BASE0 + (__index * 0x0100))

/*
* HOST-MCU shared memory.
@@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
/*
* DMA descriptor defines.
*/
-#define TXD_DESC_SIZE ( 16 * sizeof(__le32) )
-#define TXINFO_SIZE ( 6 * sizeof(__le32) )
-#define RXD_DESC_SIZE ( 16 * sizeof(__le32) )
+#define TXD_DESC_SIZE (16 * sizeof(__le32))
+#define TXINFO_SIZE (6 * sizeof(__le32))
+#define RXD_DESC_SIZE (16 * sizeof(__le32))

/*
* TX descriptor format for TX, PRIO and Beacon Ring.
--
2.6.1



2016-01-21 16:56:58

by Helmut Schaa

[permalink] [raw]
Subject: Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <[email protected]> wrote:
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <[email protected]>

Just noticed these did not get applied by Kalle yet.

Looks good to me.

Acked-by: Helmut Schaa <[email protected]>

> ---
> drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt61pci.h b/drivers/net/wireless/rt2x00/rt61pci.h
> index 1442075..ab86415 100644
> --- a/drivers/net/wireless/rt2x00/rt61pci.h
> +++ b/drivers/net/wireless/rt2x00/rt61pci.h
> @@ -138,14 +138,14 @@
> #define PAIRWISE_TA_TABLE_BASE 0x1a00
>
> #define SHARED_KEY_ENTRY(__idx) \
> - ( SHARED_KEY_TABLE_BASE + \
> - ((__idx) * sizeof(struct hw_key_entry)) )
> + (SHARED_KEY_TABLE_BASE + \
> + ((__idx) * sizeof(struct hw_key_entry)))
> #define PAIRWISE_KEY_ENTRY(__idx) \
> - ( PAIRWISE_KEY_TABLE_BASE + \
> - ((__idx) * sizeof(struct hw_key_entry)) )
> + (PAIRWISE_KEY_TABLE_BASE + \
> + ((__idx) * sizeof(struct hw_key_entry)))
> #define PAIRWISE_TA_ENTRY(__idx) \
> - ( PAIRWISE_TA_TABLE_BASE + \
> - ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
> + (PAIRWISE_TA_TABLE_BASE + \
> + ((__idx) * sizeof(struct hw_pairwise_ta_entry)))
>
> struct hw_key_entry {
> u8 key[16];
> @@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
> #define HW_BEACON_BASE3 0x2f00
>
> #define HW_BEACON_OFFSET(__index) \
> - ( HW_BEACON_BASE0 + (__index * 0x0100) )
> + (HW_BEACON_BASE0 + (__index * 0x0100))
>
> /*
> * HOST-MCU shared memory.
> @@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
> /*
> * DMA descriptor defines.
> */
> -#define TXD_DESC_SIZE ( 16 * sizeof(__le32) )
> -#define TXINFO_SIZE ( 6 * sizeof(__le32) )
> -#define RXD_DESC_SIZE ( 16 * sizeof(__le32) )
> +#define TXD_DESC_SIZE (16 * sizeof(__le32))
> +#define TXINFO_SIZE (6 * sizeof(__le32))
> +#define RXD_DESC_SIZE (16 * sizeof(__le32))
>
> /*
> * TX descriptor format for TX, PRIO and Beacon Ring.
> --
> 2.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2016-01-21 17:12:42

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

Helmut Schaa <[email protected]> writes:

> On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa
> <[email protected]> wrote:
>> On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <[email protected]> wrote:
>>> Removed empty spaces before/after parenthesis
>>>
>>> Signed-off-by: Paul McQuade <[email protected]>
>>
>> Just noticed these did not get applied by Kalle yet.
>
> Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when applying?
> Or would you prefer Paul to respin the whole code style cleanup series?

Actually git should be manage that automatically, it's so awesome :)

I can also fix the title and remove the unnecessary "net: wireless:"
prefix.


--
Kalle Valo

2016-01-21 17:02:46

by Helmut Schaa

[permalink] [raw]
Subject: Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa
<[email protected]> wrote:
> On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <[email protected]> wrote:
>> Removed empty spaces before/after parenthesis
>>
>> Signed-off-by: Paul McQuade <[email protected]>
>
> Just noticed these did not get applied by Kalle yet.

Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when applying?
Or would you prefer Paul to respin the whole code style cleanup series?

Thanks,
Helmut

> Looks good to me.
>
> Acked-by: Helmut Schaa <[email protected]>
>
>> ---
>> drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt61pci.h b/drivers/net/wireless/rt2x00/rt61pci.h
>> index 1442075..ab86415 100644
>> --- a/drivers/net/wireless/rt2x00/rt61pci.h
>> +++ b/drivers/net/wireless/rt2x00/rt61pci.h
>> @@ -138,14 +138,14 @@
>> #define PAIRWISE_TA_TABLE_BASE 0x1a00
>>
>> #define SHARED_KEY_ENTRY(__idx) \
>> - ( SHARED_KEY_TABLE_BASE + \
>> - ((__idx) * sizeof(struct hw_key_entry)) )
>> + (SHARED_KEY_TABLE_BASE + \
>> + ((__idx) * sizeof(struct hw_key_entry)))
>> #define PAIRWISE_KEY_ENTRY(__idx) \
>> - ( PAIRWISE_KEY_TABLE_BASE + \
>> - ((__idx) * sizeof(struct hw_key_entry)) )
>> + (PAIRWISE_KEY_TABLE_BASE + \
>> + ((__idx) * sizeof(struct hw_key_entry)))
>> #define PAIRWISE_TA_ENTRY(__idx) \
>> - ( PAIRWISE_TA_TABLE_BASE + \
>> - ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
>> + (PAIRWISE_TA_TABLE_BASE + \
>> + ((__idx) * sizeof(struct hw_pairwise_ta_entry)))
>>
>> struct hw_key_entry {
>> u8 key[16];
>> @@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
>> #define HW_BEACON_BASE3 0x2f00
>>
>> #define HW_BEACON_OFFSET(__index) \
>> - ( HW_BEACON_BASE0 + (__index * 0x0100) )
>> + (HW_BEACON_BASE0 + (__index * 0x0100))
>>
>> /*
>> * HOST-MCU shared memory.
>> @@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
>> /*
>> * DMA descriptor defines.
>> */
>> -#define TXD_DESC_SIZE ( 16 * sizeof(__le32) )
>> -#define TXINFO_SIZE ( 6 * sizeof(__le32) )
>> -#define RXD_DESC_SIZE ( 16 * sizeof(__le32) )
>> +#define TXD_DESC_SIZE (16 * sizeof(__le32))
>> +#define TXINFO_SIZE (6 * sizeof(__le32))
>> +#define RXD_DESC_SIZE (16 * sizeof(__le32))
>>
>> /*
>> * TX descriptor format for TX, PRIO and Beacon Ring.
>> --
>> 2.6.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html

2016-02-07 07:10:40

by Kalle Valo

[permalink] [raw]
Subject: Re: net: wireless: rt2x00: Fixed Spacing issues


> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <[email protected]>
> Acked-by: Helmut Schaa <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

2016-02-02 15:59:59

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: net: wireless: rt2x00: Fixed Spacing issues

On Sat, Oct 17, 2015 at 09:04:39PM +0100, Paul Mcquade wrote:
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <[email protected]>
> Acked-by: Helmut Schaa <[email protected]>
>
> ---
> drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)

This patch and your other patches related to rt2x00 will not apply
anymore as the driver has moved to drivers/net/wireless/ralink/rt2x00

can you please send them again after rebasing against current tree..

regards
sudip