2015-10-17 21:11:29

by Paul McQuade

[permalink] [raw]
Subject: [PATCH 3/3] net: wireless: rt2x00: Space Required

Space needed before open parenthesis

Signed-off-by: Paul McQuade <[email protected]>
---
drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
index 90fdb02..25ee3cb 100644
--- a/drivers/net/wireless/rt2x00/rt2x00debug.c
+++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
@@ -629,7 +629,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
data += sprintf(data, "register\tbase\twords\twordsize\n");
#define RT2X00DEBUGFS_SPRINTF_REGISTER(__name) \
{ \
- if(debug->__name.read) \
+ if (debug->__name.read) \
data += sprintf(data, __stringify(__name) \
"\t%d\t%d\t%d\n", \
debug->__name.word_base, \
@@ -699,7 +699,7 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)

#define RT2X00DEBUGFS_CREATE_REGISTER_ENTRY(__intf, __name) \
({ \
- if(debug->__name.read) { \
+ if (debug->__name.read) { \
(__intf)->__name##_off_entry = \
debugfs_create_u32(__stringify(__name) "_offset", \
S_IRUSR | S_IWUSR, \
--
2.6.1



2016-01-21 17:10:30

by Helmut Schaa

[permalink] [raw]
Subject: Re: [PATCH 3/3] net: wireless: rt2x00: Space Required

On Sat, Oct 17, 2015 at 11:11 PM, Paul McQuade <[email protected]> wrote:
> Space needed before open parenthesis
>
> Signed-off-by: Paul McQuade <[email protected]>

Looks valid to me.

Acked-by: Helmut Schaa <[email protected]>

> ---
> drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
> index 90fdb02..25ee3cb 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00debug.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
> @@ -629,7 +629,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
> data += sprintf(data, "register\tbase\twords\twordsize\n");
> #define RT2X00DEBUGFS_SPRINTF_REGISTER(__name) \
> { \
> - if(debug->__name.read) \
> + if (debug->__name.read) \
> data += sprintf(data, __stringify(__name) \
> "\t%d\t%d\t%d\n", \
> debug->__name.word_base, \
> @@ -699,7 +699,7 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)
>
> #define RT2X00DEBUGFS_CREATE_REGISTER_ENTRY(__intf, __name) \
> ({ \
> - if(debug->__name.read) { \
> + if (debug->__name.read) { \
> (__intf)->__name##_off_entry = \
> debugfs_create_u32(__stringify(__name) "_offset", \
> S_IRUSR | S_IWUSR, \
> --
> 2.6.1
>