2015-10-17 21:06:57

by Paul McQuade

Subject: [PATCH 1/3] net: wireless: rt2x00: Space issue

Removed empty spaces before/after parenthesis

Signed-off-by: Paul McQuade <[email protected]>
---
drivers/net/wireless/rt2x00/rt2x00.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
index 3282ddb..6f8310a 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h
@@ -107,7 +107,7 @@
* amount of bytes needed to move the data.
*/
#define ALIGN_SIZE(__skb, __header) \
- ( ((unsigned long)((__skb)->data + (__header))) & 3 )
+ (((unsigned long)((__skb)->data + (__header))) & 3)

/*
* Constants for extra TX headroom for alignment purposes.
@@ -128,14 +128,14 @@
#define SLOT_TIME 20
#define SHORT_SLOT_TIME 9
#define SIFS 10
-#define PIFS ( SIFS + SLOT_TIME )
-#define SHORT_PIFS ( SIFS + SHORT_SLOT_TIME )
-#define DIFS ( PIFS + SLOT_TIME )
-#define SHORT_DIFS ( SHORT_PIFS + SHORT_SLOT_TIME )
-#define EIFS ( SIFS + DIFS + \
- GET_DURATION(IEEE80211_HEADER + ACK_SIZE, 10) )
-#define SHORT_EIFS ( SIFS + SHORT_DIFS + \
- GET_DURATION(IEEE80211_HEADER + ACK_SIZE, 10) )
+#define PIFS (SIFS + SLOT_TIME)
+#define SHORT_PIFS (SIFS + SHORT_SLOT_TIME)
+#define DIFS (PIFS + SLOT_TIME)
+#define SHORT_DIFS (SHORT_PIFS + SHORT_SLOT_TIME)
+#define EIFS (SIFS + DIFS + \
+ GET_DURATION(IEEE80211_HEADER + ACK_SIZE, 10))
+#define SHORT_EIFS (SIFS + SHORT_DIFS + \
+ GET_DURATION(IEEE80211_HEADER + ACK_SIZE, 10))

enum rt2x00_chip_intf {
RT2X00_CHIP_INTF_PCI,

--
2.6.1

2015-10-17 21:07:06

by Paul McQuade

Subject: [PATCH 3/3] net: wireless: rt2x00: Space Required

Space needed before open parenthesis

Signed-off-by: Paul McQuade <[email protected]>#
---
drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
index 90fdb02..25ee3cb 100644
--- a/drivers/net/wireless/rt2x00/rt2x00debug.c
+++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
@@ -629,7 +629,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
data += sprintf(data, "register\tbase\twords\twordsize\n");
#define RT2X00DEBUGFS_SPRINTF_REGISTER(__name) \
{ \
- if(debug->__name.read) \
+ if (debug->__name.read) \
data += sprintf(data, __stringify(__name) \
"\t%d\t%d\t%d\n", \
debug->__name.word_base, \
@@ -699,7 +699,7 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)

#define RT2X00DEBUGFS_CREATE_REGISTER_ENTRY(__intf, __name) \
({ \
- if(debug->__name.read) { \
+ if (debug->__name.read) { \
(__intf)->__name##_off_entry = \
debugfs_create_u32(__stringify(__name) "_offset", \
S_IRUSR | S_IWUSR, \
--
2.6.1

2015-10-17 21:07:05

by Paul McQuade

Subject: [PATCH 2/3] net: wireless: rt2x00: Pointer issue

Code Style: pointer is declared wrong

Signed-off-by: Paul McQuade <[email protected]>
---
drivers/net/wireless/rt2x00/rt2x00.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
index 6f8310a..b052e87 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h
@@ -380,7 +380,7 @@ struct rt2x00_intf {
atomic_t seqno;
};

-static inline struct rt2x00_intf* vif_to_intf(struct ieee80211_vif *vif)
+static inline struct rt2x00_intf *vif_to_intf(struct ieee80211_vif *vif)
{
return (struct rt2x00_intf *)vif->drv_priv;
}
@@ -507,7 +507,7 @@ struct rt2x00_sta {
int wcid;
};

-static inline struct rt2x00_sta* sta_to_rt2x00_sta(struct ieee80211_sta *sta)
+static inline struct rt2x00_sta *sta_to_rt2x00_sta(struct ieee80211_sta *sta)
{
return (struct rt2x00_sta *)sta->drv_priv;
}
--
2.6.1

2016-01-21 16:59:08

by Helmut Schaa

Subject: Re: [PATCH 2/3] net: wireless: rt2x00: Pointer issue

On Sat, Oct 17, 2015 at 11:06 PM, Paul McQuade <[email protected]> wrote:
> Code Style: pointer is declared wrong
>
> Signed-off-by: Paul McQuade <[email protected]>

Thanks for fixing this code style issue.

Acked-by: Helmut Schaa <[email protected]>

> ---
> drivers/net/wireless/rt2x00/rt2x00.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
> index 6f8310a..b052e87 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00.h
> @@ -380,7 +380,7 @@ struct rt2x00_intf {
> atomic_t seqno;
> };
>
> -static inline struct rt2x00_intf* vif_to_intf(struct ieee80211_vif *vif)
> +static inline struct rt2x00_intf *vif_to_intf(struct ieee80211_vif *vif)
> {
> return (struct rt2x00_intf *)vif->drv_priv;
> }
> @@ -507,7 +507,7 @@ struct rt2x00_sta {
> int wcid;
> };
>
> -static inline struct rt2x00_sta* sta_to_rt2x00_sta(struct ieee80211_sta *sta)
> +static inline struct rt2x00_sta *sta_to_rt2x00_sta(struct ieee80211_sta *sta)
> {
> return (struct rt2x00_sta *)sta->drv_priv;
> }
> --
> 2.6.1
>

2016-01-21 17:04:08

by Helmut Schaa

Subject: Re: [PATCH 1/3] net: wireless: rt2x00: Space issue

On Sat, Oct 17, 2015 at 11:06 PM, Paul McQuade <[email protected]> wrote:
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <[email protected]>

Looks valid to me as well.

Acked-by: Helmut Schaa <[email protected]>

> ---
> drivers/net/wireless/rt2x00/rt2x00.h | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
> index 3282ddb..6f8310a 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00.h
> @@ -107,7 +107,7 @@
> * amount of bytes needed to move the data.
> */
> #define ALIGN_SIZE(__skb, __header) \
> - ( ((unsigned long)((__skb)->data + (__header))) & 3 )
> + (((unsigned long)((__skb)->data + (__header))) & 3)
>
> /*
> * Constants for extra TX headroom for alignment purposes.
> @@ -128,14 +128,14 @@
> #define SLOT_TIME 20
> #define SHORT_SLOT_TIME 9
> #define SIFS 10
> -#define PIFS ( SIFS + SLOT_TIME )
> -#define SHORT_PIFS ( SIFS + SHORT_SLOT_TIME )
> -#define DIFS ( PIFS + SLOT_TIME )
> -#define SHORT_DIFS ( SHORT_PIFS + SHORT_SLOT_TIME )
> -#define EIFS ( SIFS + DIFS + \
> - GET_DURATION(IEEE80211_HEADER + ACK_SIZE, 10) )
> -#define SHORT_EIFS ( SIFS + SHORT_DIFS + \
> - GET_DURATION(IEEE80211_HEADER + ACK_SIZE, 10) )
> +#define PIFS (SIFS + SLOT_TIME)
> +#define SHORT_PIFS (SIFS + SHORT_SLOT_TIME)
> +#define DIFS (PIFS + SLOT_TIME)
> +#define SHORT_DIFS (SHORT_PIFS + SHORT_SLOT_TIME)
> +#define EIFS (SIFS + DIFS + \
> + GET_DURATION(IEEE80211_HEADER + ACK_SIZE, 10))
> +#define SHORT_EIFS (SIFS + SHORT_DIFS + \
> + GET_DURATION(IEEE80211_HEADER + ACK_SIZE, 10))
>
> enum rt2x00_chip_intf {
> RT2X00_CHIP_INTF_PCI,
>
> --
> 2.6.1
>

2016-02-07 07:12:16

by Kalle Valo

Subject: Re: [1/3] net: wireless: rt2x00: Space issue

> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <[email protected]>
> Acked-by: Helmut Schaa <[email protected]>

Thanks, 2 patches applied to wireless-drivers-next.git:

b2cc2dd8ebb8 net: wireless: rt2x00: Space issue
5b451715e94d net: wireless: rt2x00: Space Required

1 patches skipped:

[2/3] net: wireless: rt2x00: Pointer issue

Kalle Valo

2016-02-07 07:13:58

by Kalle Valo

Subject: Re: [2/3] net: wireless: rt2x00: Pointer issue

> Code Style: pointer is declared wrong
>
> Signed-off-by: Paul McQuade <[email protected]>
> Acked-by: Helmut Schaa <[email protected]>

This patch didn't apply, so please resend.

Kalle