2023-09-13 19:59:34

by Rusty Howell

[permalink] [raw]
Subject: Add extra check in regdb scripts

From 434588b8f06f78a3188909c298a6f6671dab7b3f Mon Sep 17 00:00:00 2001
From: Rusty Howell <[email protected]>
Date: Thu, 7 Sep 2023 12:56:47 -0600
Subject: [PATCH] Add same check that kernel uses to check reg domain

The kernel will reject a regulatory domain if the max bandwidth is greater than
the span from start to end. We should catch this error when compiling the
regulatory database.
---
dbparse.py | 3 +++
1 file changed, 3 insertions(+)

diff --git a/dbparse.py b/dbparse.py
index 5f7e082..1e87813 100755
--- a/dbparse.py
+++ b/dbparse.py
@@ -218,6 +218,9 @@ class DBParser(object):
self._syntax_error("Inverted freq range (%d - %d)" %
(start, end))
if start == end:
self._syntax_error("Start and end freqs are equal
(%d)" % start)
+ if bw > (end - start):
+ self._syntax_error("Max bandwidth must not exceed the
range from start to end")
+
except ValueError:
self._syntax_error("band must have frequency range")

--
2.25.1


2023-12-05 02:50:22

by Chen-Yu Tsai

[permalink] [raw]
Subject: Re: [wireless-regdb] Add extra check in regdb scripts

Hi,

On Thu, Sep 14, 2023 at 12:16 PM Rusty Howell <[email protected]> wrote:
>
> From 434588b8f06f78a3188909c298a6f6671dab7b3f Mon Sep 17 00:00:00 2001
> From: Rusty Howell <[email protected]>
> Date: Thu, 7 Sep 2023 12:56:47 -0600
> Subject: [PATCH] Add same check that kernel uses to check reg domain
>
> The kernel will reject a regulatory domain if the max bandwidth is greater than
> the span from start to end. We should catch this error when compiling the
> regulatory database.
> ---
> dbparse.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/dbparse.py b/dbparse.py
> index 5f7e082..1e87813 100755
> --- a/dbparse.py
> +++ b/dbparse.py
> @@ -218,6 +218,9 @@ class DBParser(object):
> self._syntax_error("Inverted freq range (%d - %d)" %
> (start, end))
> if start == end:
> self._syntax_error("Start and end freqs are equal
> (%d)" % start)
> + if bw > (end - start):
> + self._syntax_error("Max bandwidth must not exceed the
> range from start to end")
> +
> except ValueError:
> self._syntax_error("band must have frequency range")
>
> --
> 2.25.1

It looks like this patch was incorrectly line wrapped (by Gmail maybe).
Can you resend?


Thanks
ChenYu