2018-02-05 22:39:13

by Mike Lothian

[permalink] [raw]
Subject: Regression in ath10k

Hi

Since the merge window opened I've been unable to see any wireless
networks or join my usual access point

I bisected this to:

9ed4f91628737c820af6a1815b65bc06bd31518f is the first bad commit
commit 9ed4f91628737c820af6a1815b65bc06bd31518f
Author: Ryan Hsu <[email protected]>
Date: Tue Jan 16 11:43:49 2018 +0200

ath10k: add sanity check to ie_len before parsing fw/board ie

Validate ie_len after the alignment padding before access the buffer
to avoid potential overflow.

Signed-off-by: Ryan Hsu <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>

And I can confirm that reverting the patch makes things work again (attached)

Device:

3c:00.0 Network controller [0280]: Qualcomm Atheros QCA6174 802.11ac
Wireless Network Adapter [168c:003e] (rev 32)

Firmware:

https://github.com/kvalo/ath10k-firmware

ath10k-firmware/QCA6174/hw3.0/4.4.1.c1

There was nothing obvious in the dmesg

Regards

Mike


Attachments:
06-ath10k-revert.patch (1.59 kB)

2018-02-06 13:13:40

by Mike Lothian

[permalink] [raw]
Subject: Re: Regression in ath10k

On 5 February 2018 at 22:38, Mike Lothian <[email protected]> wrote:
> Hi
>
> Since the merge window opened I've been unable to see any wireless
> networks or join my usual access point
>
> I bisected this to:
>
> 9ed4f91628737c820af6a1815b65bc06bd31518f is the first bad commit
> commit 9ed4f91628737c820af6a1815b65bc06bd31518f
> Author: Ryan Hsu <[email protected]>
> Date: Tue Jan 16 11:43:49 2018 +0200
>
> ath10k: add sanity check to ie_len before parsing fw/board ie
>
> Validate ie_len after the alignment padding before access the buffer
> to avoid potential overflow.
>
> Signed-off-by: Ryan Hsu <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
>
> And I can confirm that reverting the patch makes things work again (attached)
>
> Device:
>
> 3c:00.0 Network controller [0280]: Qualcomm Atheros QCA6174 802.11ac
> Wireless Network Adapter [168c:003e] (rev 32)
>
> Firmware:
>
> https://github.com/kvalo/ath10k-firmware
>
> ath10k-firmware/QCA6174/hw3.0/4.4.1.c1
>
> There was nothing obvious in the dmesg
>
> Regards
>
> Mike

Adding in the ath10k list and another email address for Kalle