2018-05-21 16:28:53

by Guy Chronister

[permalink] [raw]
Subject: [PATCH] Added Dell Wireless 1537 Ath6kl sdio card (0x19) to the list.

Signed-off-by: Guy Chronister <[email protected]>
---
drivers/net/wireless/ath/ath6kl/sdio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c
index 2195b1b7a8a6..bb50680580f3 100644
--- a/drivers/net/wireless/ath/ath6kl/sdio.c
+++ b/drivers/net/wireless/ath/ath6kl/sdio.c
@@ -1415,6 +1415,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
+ {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x19))},
{},
};

--
2.17.0


2018-05-21 20:41:35

by Steve deRosier

[permalink] [raw]
Subject: Re: [PATCH] Added Dell Wireless 1537 Ath6kl sdio card (0x19) to the list.

Hi Guy,

On Mon, May 21, 2018 at 9:28 AM Guy Chronister <[email protected]>
wrote:

> Signed-off-by: Guy Chronister <[email protected]>
> ---
> drivers/net/wireless/ath/ath6kl/sdio.c | 1 +
> 1 file changed, 1 insertion(+)

> diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c
b/drivers/net/wireless/ath/ath6kl/sdio.c
> index 2195b1b7a8a6..bb50680580f3 100644
> --- a/drivers/net/wireless/ath/ath6kl/sdio.c
> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c
> @@ -1415,6 +1415,7 @@ static const struct sdio_device_id
ath6kl_sdio_devices[] = {
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE |
0x1))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE |
0x2))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE |
0x18))},
> + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE |
0x19))},
> {},
> };


Thanks for this. I'd like to see more information in the git commit
message. While I get that this is some Dell card, it would be helpful to
know what is the actual chip, which firmware, sdio id, and what tests were
done to confirm this worked. Honestly I'm a bit surprised to see a new
ath6k chip ID.

Thanks,
- Steve