2015-02-25 17:59:07

by Taehee Yoo

Subject: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg

rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.

Signed-off-by: Taehee Yoo <[email protected]>
---
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
index fe4b699..f6ad959 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
case HW_VAR_DATA_FILTER:
*((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
break;
+ case HAL_DEF_WOWLAN:
+ if (ppsc->wo_wlan_mode)
+ *((bool *)(val)) = true;
+ else
+ *((bool *)(val)) = false;
+ break;
default:
RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
"switch case not processed\n");
--
1.9.1

2015-02-25 20:23:44

by Larry Finger

Subject: Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg

On 02/25/2015 01:34 PM, Taehee Yoo wrote:
> Add HAL_DEF_WOWLAN case in rtl92cu_get_hw_reg
>
> Signed-off-by: Taehee Yoo <[email protected]>

Acked-by: Larry Finger <[email protected]>

@Kalle: This is V2. V1 is not OK.

Larry

> ---
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index fe4b699..96bae39 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1589,6 +1589,8 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
> case HW_VAR_DATA_FILTER:
> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
> break;
> + case HAL_DEF_WOWLAN:
> + break;
> default:
> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
> "switch case not processed\n");
>

2015-02-25 18:59:24

by Taehee Yoo

Subject: Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg

2015-02-26 3:33 GMT+09:00 Larry Finger <[email protected]>:
> On 02/25/2015 11:58 AM, Taehee Yoo wrote:
>>
>> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.
>>
>> Signed-off-by: Taehee Yoo <[email protected]>
>
>
> Has this been tested? I am not aware that the RTL8192CU firmware could
> handle WOWLAN.
>
> Larry
>
>
>> ---
>> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> index fe4b699..f6ad959 100644
>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8
>> variable, u8 *val)
>> case HW_VAR_DATA_FILTER:
>> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
>> break;
>> + case HAL_DEF_WOWLAN:
>> + if (ppsc->wo_wlan_mode)
>> + *((bool *)(val)) = true;
>> + else
>> + *((bool *)(val)) = false;
>> + break;
>> default:
>> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
>> "switch case not processed\n");
>>
>

As far as i know, rtl8192cu is not support WOWLAN.
in rtl8192cu, this code is no effect. so, It is care of unnecessary
debug message.

2015-02-25 18:33:37

by Larry Finger

Subject: Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg

On 02/25/2015 11:58 AM, Taehee Yoo wrote:
> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.
>
> Signed-off-by: Taehee Yoo <[email protected]>

Has this been tested? I am not aware that the RTL8192CU firmware could handle
WOWLAN.

Larry

> ---
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index fe4b699..f6ad959 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
> case HW_VAR_DATA_FILTER:
> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
> break;
> + case HAL_DEF_WOWLAN:
> + if (ppsc->wo_wlan_mode)
> + *((bool *)(val)) = true;
> + else
> + *((bool *)(val)) = false;
> + break;
> default:
> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
> "switch case not processed\n");
>

2015-02-25 19:12:06

by Larry Finger

Subject: Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg

On 02/25/2015 12:59 PM, ap420073 . wrote:
> 2015-02-26 3:33 GMT+09:00 Larry Finger <[email protected]>:
>> On 02/25/2015 11:58 AM, Taehee Yoo wrote:
>>>
>>> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.
>>>
>>> Signed-off-by: Taehee Yoo <[email protected]>
>>
>>
>> Has this been tested? I am not aware that the RTL8192CU firmware could
>> handle WOWLAN.
>>
>> Larry
>>
>>
>>> ---
>>> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>> b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>> index fe4b699..f6ad959 100644
>>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8
>>> variable, u8 *val)
>>> case HW_VAR_DATA_FILTER:
>>> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
>>> break;
>>> + case HAL_DEF_WOWLAN:
>>> + if (ppsc->wo_wlan_mode)
>>> + *((bool *)(val)) = true;
>>> + else
>>> + *((bool *)(val)) = false;
>>> + break;
>>> default:
>>> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
>>> "switch case not processed\n");
>>>
>>
>
> As far as i know, rtl8192cu is not support WOWLAN.
> in rtl8192cu, this code is no effect. so, It is care of unnecessary
> debug message.

That is what I thought. In that case, the new code should be

case HAL_DEF_WOWLAN:
break;

Larry

2015-02-25 19:24:50

by Taehee Yoo

Subject: Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg

2015-02-26 4:12 GMT+09:00 Larry Finger <[email protected]>:
> On 02/25/2015 12:59 PM, ap420073 . wrote:
>>
>> 2015-02-26 3:33 GMT+09:00 Larry Finger <[email protected]>:
>>>
>>> On 02/25/2015 11:58 AM, Taehee Yoo wrote:
>>>>
>>>>
>>>> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.
>>>>
>>>> Signed-off-by: Taehee Yoo <[email protected]>
>>>
>>>
>>>
>>> Has this been tested? I am not aware that the RTL8192CU firmware could
>>> handle WOWLAN.
>>>
>>> Larry
>>>
>>>
>>>> ---
>>>> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
>>>> 1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>>> b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>>> index fe4b699..f6ad959 100644
>>>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>>> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw,
>>>> u8
>>>> variable, u8 *val)
>>>> case HW_VAR_DATA_FILTER:
>>>> *((u16 *) (val)) = rtl_read_word(rtlpriv,
>>>> REG_RXFLTMAP2);
>>>> break;
>>>> + case HAL_DEF_WOWLAN:
>>>> + if (ppsc->wo_wlan_mode)
>>>> + *((bool *)(val)) = true;
>>>> + else
>>>> + *((bool *)(val)) = false;
>>>> + break;
>>>> default:
>>>> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
>>>> "switch case not processed\n");
>>>>
>>>
>>
>> As far as i know, rtl8192cu is not support WOWLAN.
>> in rtl8192cu, this code is no effect. so, It is care of unnecessary
>> debug message.
>
>
> That is what I thought. In that case, the new code should be
>
> case HAL_DEF_WOWLAN:
> break;
>
> Larry
>

Thanks!
I would send a new code.