2015-06-06 10:57:25

by Taehee Yoo

[permalink] [raw]
Subject: [PATCH V2 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile

in the _rtl92c_phy_rf6052_config_parafile(), cases
RF90_PATH_A and RF90_PATH_B call the same routine.
so i remove one of these routine. also the return
routine is duplicated. so i remove it.

Signed-off-by: Taehee Yoo <[email protected]>
---
drivers/net/wireless/rtlwifi/rtl8192cu/rf.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
index b878d56..8ce055c 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
@@ -452,9 +452,6 @@ static bool _rtl92c_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
udelay(1);
switch (rfpath) {
case RF90_PATH_A:
- rtstatus = rtl92cu_phy_config_rf_with_headerfile(hw,
- (enum radio_path) rfpath);
- break;
case RF90_PATH_B:
rtstatus = rtl92cu_phy_config_rf_with_headerfile(hw,
(enum radio_path) rfpath);
@@ -483,7 +480,6 @@ static bool _rtl92c_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
}
}
RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, "<---\n");
- return rtstatus;
phy_rf_cfg_fail:
return rtstatus;
}
--
2.1.4



2015-06-07 11:52:03

by Taehee Yoo

[permalink] [raw]
Subject: Re: [PATCH V2 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile

2015-06-06 21:42 GMT+09:00 Kalle Valo <[email protected]>:
> Taehee Yoo <[email protected]> writes:
>
>> in the _rtl92c_phy_rf6052_config_parafile(), cases
>> RF90_PATH_A and RF90_PATH_B call the same routine.
>> so i remove one of these routine. also the return
>> routine is duplicated. so i remove it.
>>
>> Signed-off-by: Taehee Yoo <[email protected]>
>
> Please resend the whole series (ie. all three patches), not just the
> patch which has changed.
>
> --
> Kalle Valo

Thank you for your feedback!
I will resend the two patches.

2015-06-06 12:42:11

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH V2 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile

Taehee Yoo <[email protected]> writes:

> in the _rtl92c_phy_rf6052_config_parafile(), cases
> RF90_PATH_A and RF90_PATH_B call the same routine.
> so i remove one of these routine. also the return
> routine is duplicated. so i remove it.
>
> Signed-off-by: Taehee Yoo <[email protected]>

Please resend the whole series (ie. all three patches), not just the
patch which has changed.

--
Kalle Valo

2015-06-15 09:32:02

by Kalle Valo

[permalink] [raw]
Subject: Re: [V2, 1/3] rtlwifi: rtl8192cu: remove duplicated routine in_rtl92c_phy_rf6052_config_parafile


> in the _rtl92c_phy_rf6052_config_parafile(), cases
> RF90_PATH_A and RF90_PATH_B call the same routine.
> so i remove one of these routine. also the return
> routine is duplicated. so i remove it.
>
> Signed-off-by: Taehee Yoo <[email protected]>

Thanks, 3 patches applied to wireless-drivers-next.git:

138055e23b66 rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile
8657f9c4d52f rtlwifi: rtl8192cu: debug message change "RTL8192CE" to "RTL8192CU"
d92460097c00 rtlwifi: rtl8192cu: Fix variable isfirst_ampdu

Kalle Valo