2023-09-26 00:17:18

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH v3 1/1] cfg80211: Allow AP/P2PGO to indicate port authorization to peer STA/P2PClient

On Fri, 2023-09-22 at 18:19 +0530, Vinayak Yadawad wrote:
> In 4way handshake offload, cfg80211_port_authorized enables driver
> to indicate successful 4way handshake to cfg80211 layer. Currently
> this path of port authorization is restricted to interface type
> NL80211_IFTYPE_STATION and NL80211_IFTYPE_P2P_CLIENT. This patch
> extends the support for NL80211_IFTYPE_AP and NL80211_IFTYPE_P2P_GO
> interfaces to authorize peer STA/P2P_CLIENT, whenever authentication
> is offloaded on the AP/P2P_GO interface.
>
> Signed-off-by: Vinayak Yadawad <[email protected]>
> ---
> v2->v3: Fixed indentation in comment

Well, I had another comment on v2, and this patch _still_ doesn't apply.

Also please put 'wifi: ' prefix on all your patches. I've fixed the
other one for you, but I don't want to do it all the time.

johannes

2023-10-05 14:22:07

by Vinayak Yadawad

[permalink] [raw]
Subject: Re: [PATCH v3 1/1] cfg80211: Allow AP/P2PGO to indicate port authorization to peer STA/P2PClient

Hi Johannes,

Could you please review the changes addressed in "[PATCH v4 1/1] wifi:
cfg80211: Allow AP/P2PGO to indicate port authorization to peer
STA/P2PClient"

Regards,
Vinayak

On Mon, Sep 25, 2023 at 2:29 PM Johannes Berg <[email protected]> wrote:
>
> On Fri, 2023-09-22 at 18:19 +0530, Vinayak Yadawad wrote:
> > In 4way handshake offload, cfg80211_port_authorized enables driver
> > to indicate successful 4way handshake to cfg80211 layer. Currently
> > this path of port authorization is restricted to interface type
> > NL80211_IFTYPE_STATION and NL80211_IFTYPE_P2P_CLIENT. This patch
> > extends the support for NL80211_IFTYPE_AP and NL80211_IFTYPE_P2P_GO
> > interfaces to authorize peer STA/P2P_CLIENT, whenever authentication
> > is offloaded on the AP/P2P_GO interface.
> >
> > Signed-off-by: Vinayak Yadawad <[email protected]>
> > ---
> > v2->v3: Fixed indentation in comment
>
> Well, I had another comment on v2, and this patch _still_ doesn't apply.
>
> Also please put 'wifi: ' prefix on all your patches. I've fixed the
> other one for you, but I don't want to do it all the time.
>
> johannes
>


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature