[permalink] [raw]

On Monday 28 October 2013 14:55:22 Johannes Berg wrote:
> On Mon, 2013-10-28 at 14:49 +0100, Pali Rohár wrote:
> > On Monday 28 October 2013 14:45:05 Johannes Berg wrote:
> > > On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote:
> > > > Driver wl1251 generating mac address randomly at startup
> > > > and there is no way to set permanent mac address via
> > > > SET_IEEE80211_PERM_ADDR. This patch export sysfs file
> > > > which can set permanent mac address by userspace helper
> > > > program. Patch is needed for devices which do not store
> > > > mac address in internal wl1251 eeprom.
> > >
> > > This doesn't really seem like a good idea since you can
> > > also just use 'ip' or whatever to set the MAC address.
> > >
> > > johannes
> >
> > AFAIK you cannot set permanent address (show by ethtool -P
> > wlan0) via ip/ifconfig.
>
> You probably can't, but that address also doesn't matter at
> all and isn't really used anywhere.
>
> johannes

There are some (proprietary) applications which using permanent
address for something...

And also more important: some network managing tools using it.
NetworkManager resetting current MAC address to permanent one
before starting configuring interface.

So this will lead to never use correct MAC address (but random
permanent one) assigned for that wl1251 wireless card...

--
Pali Rohár
[email protected]

Attachments:

signature.asc (198.00 B)
This is a digitally signed message part.

2013-10-30 11:55:43

by Pavel Machek

[permalink] [raw]

Subject: Re: [PATCH 14/16] wl1251: add nvs file name to module firmware list

On Sat 2013-10-26 22:34:13, Pali Roh?r wrote:
> Signed-off-by: Pali Roh?r <[email protected]>

Reviewed-by: Pavel Machek <[email protected]>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2013-10-28 15:30:25

by Dan Williams

[permalink] [raw]

Subject: Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

On Mon, 2013-10-28 at 16:04 +0100, Pali Rohár wrote:
> On Monday 28 October 2013 15:56:55 Johannes Berg wrote:
> > On Mon, 2013-10-28 at 09:46 -0500, Dan Williams wrote:
> > > If the device doesn't actually *have* a permanent MAC
> > > address, then it shouldn't be returning one via ethtool,
> > > and should return an error for ETHTOOL_GPERMADDR.
> >
> > There's currently no provision for that, but I agree it would
> > be better to do so.
> >
> > johannes
>
> So what to do with devices which has MAC address stored in some
> obscure place and there is userspace binary which can read it?
>
> I think that there should be some way to tell kernel that *this*
> is the permanent address and it should use it.
>
> This is reason why I proposed patch which adding sysfs entry for
> setting permanent address from userspace in wl1251 driver.

Ok, so the N900's MAC is stored in the "cal partition", which is a
region of flash exposed to the OS as /dev/mtd1. That also stores the
regulatory domain. Typically userspace binaries are used to pull out
this and other data (see
https://dev.openwrt.org/browser/packages/utils/calvaria/files/src/calvaria.c ) which is then used to initialize the device.

Any idea what kernel driver is used to expose the CAL partition
as /dev/mtd1? If it's nothing special maybe a small EEPROM-style driver
could be written to read the relevant areas (and since they don't ever
change, don't need to worry about something else writing at the same
time).

Dan

2013-10-26 20:40:25

by Pali Rohár

[permalink] [raw]

Subject: [PATCH 01/16] mac80211: fix TX device statistics for monitor interfaces

From: David Gnedt <[email protected]>

Count TX packets and bytes also for monitor interfaces.

Signed-of-by: David Gnedt <[email protected]>
---
net/mac80211/tx.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 3456c04..674db8e 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1593,6 +1593,9 @@ netdev_tx_t ieee80211_monitor_start_xmit(struct sk_buff *skb,
if (unlikely(skb->len < len_rthdr))
goto fail; /* skb too short for claimed rt header extent */

+ dev->stats.tx_packets++;
+ dev->stats.tx_bytes += skb->len;
+
/*
* fix up the pointers accounting for the radiotap
* header still being in there. We are being given
--
1.7.10.4

2013-10-28 16:21:29

On Tuesday 29 October 2013 00:39:47 Ben Hutchings wrote:
> On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote:
> > From: David Gnedt <[email protected]>
> >
> > Port the bt_coex_mode sysfs interface from wl1251 driver
> > version included in the Maemo Fremantle kernel to allow
> > bt-coexistence mode configuration. This enables userspace
> > applications to set one of the modes WL1251_BT_COEX_OFF,
> > WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO. The
> > default mode is WL1251_BT_COEX_OFF.
> > It should be noted that this driver always enabled
> > bt-coexistence before and enabled bt-coexistence directly
> > affects the receiving performance, rendering it unusable in
> > some low-signal situations. Especially monitor mode is
> > affected very badly with bt-coexistence enabled.
>
> [...]
>
> This should be implemented consistently with other drivers:
>
> drivers/net/wireless/ath/ath9k/htc_drv_init.c:module_param_nam
> ed(btcoex_enable, ath9k_htc_btcoex_enable, int, 0444);
> drivers/net/wireless/ath/ath9k/init.c:module_param_named(btco
> ex_enable, ath9k_btcoex_enable, int, 0444);
> drivers/net/wireless/b43/main.c:module_param_named(btcoex,
> modparam_btcoex, int, 0444);
> drivers/net/wireless/ipw2x00/ipw2200.c:module_param(bt_coexis
> t, int, 0444);
> drivers/net/wireless/iwlegacy/common.c:module_param(bt_coex_a
> ctive, bool, S_IRUGO);
> drivers/net/wireless/iwlwifi/iwl-drv.c:module_param_named(bt_
> coex_active, iwlwifi_mod_params.bt_coex_active,
> drivers/net/wireless/ti/wlcore/sysfs.c:static
> DEVICE_ATTR(bt_coex_state, S_IRUGO | S_IWUSR,
>
> Oh, hmm, I see a problem here.
>
> Ben.

So where is consitency? Each driver doing this in different way:
btcoex_enable, btcoex, bt_coexist, bt_coex_active

Reason for this usage in wl1251 is to not break existing
userspace applications.

--
Pali Rohár
[email protected]

Attachments:

signature.asc (198.00 B)
This is a digitally signed message part.

2013-12-31 09:31:59

Hello, I'm sending wl1251 patches from linux-n900 tree [1] for comments. More
patches come from David's monitor & packet injection work. Patches are tested
with 3.12 rc5 kernel on Nokia N900.

Second version contains new patch for fixing NULL pointer dereference which
sometimes cause kernel panic and fixes code suggested by Pavel Machek.

[1] - https://gitorious.org/linux-n900/linux-n900

David Gnedt (12):
wl1251: fix scan behaviour while not associated
wl1251: add sysfs interface for bluetooth coexistence mode
configuration
wl1251: retry power save entry
wl1251: implement hardware ARP filtering
wl1251: split RX and TX data path initialisation
wl1251: configure hardware en-/decryption for monitor mode
wl1251: implement multicast address filtering
wl1251: disable power saving in monitor mode
wl1251: fix channel switching in monitor mode
wl1251: enable tx path in monitor mode if necessary for packet
injection
wl1251: disable retry and ACK policy for injected packets
wl1251: enforce changed hw encryption support on monitor state change

Pali Rohár (4):
wl1251: add nvs file name to module firmware list
wl1251: Add sysfs file tx_mgmt_frm_rate for setting rate
wl1251: Add sysfs file address for setting permanent mac address
wl1251: fix NULL pointer dereference

drivers/net/wireless/ti/wl1251/acx.c | 92 +++++-
drivers/net/wireless/ti/wl1251/acx.h | 34 ++-
drivers/net/wireless/ti/wl1251/boot.c | 3 +-
drivers/net/wireless/ti/wl1251/cmd.c | 59 +++-
drivers/net/wireless/ti/wl1251/cmd.h | 8 +-
drivers/net/wireless/ti/wl1251/event.c | 46 ++-
drivers/net/wireless/ti/wl1251/event.h | 7 +
drivers/net/wireless/ti/wl1251/init.c | 19 +-
drivers/net/wireless/ti/wl1251/main.c | 462 ++++++++++++++++++++++++++++++-
drivers/net/wireless/ti/wl1251/rx.c | 2 +-
drivers/net/wireless/ti/wl1251/tx.c | 35 ++-
drivers/net/wireless/ti/wl1251/wl1251.h | 14 +
12 files changed, 720 insertions(+), 61 deletions(-)

--
1.7.9.5

2013-12-10 17:52:21

On Tuesday 10 December 2013 16:41:04 Kalle Valo wrote:
> Pavel Machek <[email protected]> writes:
> > ssids can have \0s in them... and what is worse, they may
> > not be 0 terminated AFAICT.
> >
> > Potential solution is at
> > http://www.spinics.net/lists/linux-wireless/msg98640.html .
>
> I just use print_hex_dump_bytes() to print SSIDs.

Ok and has kernel printf modifier for size_t?

--
Pali Rohár
[email protected]

Attachments:

signature.asc (198.00 B)
This is a digitally signed message part.

2013-12-10 09:39:07

by Pavel Machek

[permalink] [raw]

Subject: Re: [PATCH v2 07/16] wl1251: implement multicast address filtering

On Sun 2013-12-08 10:25:05, Pali Roh?r wrote:
> From: David Gnedt <[email protected]>
>
> Port multicast address filtering from wl1271 driver.
> It sets up the hardware multicast address filter in configure_filter() with
> addresses supplied through prepare_multicast().
>
> Signed-off-by: David Gnedt <[email protected]>
> Signed-off-by: Pali Roh?r <[email protected]>

Reviewed-by: Pavel Machek <[email protected]>

Thanks,
Pavel
> ---
> drivers/net/wireless/ti/wl1251/acx.c | 9 ++---
> drivers/net/wireless/ti/wl1251/acx.h | 9 ++---
> drivers/net/wireless/ti/wl1251/init.c | 2 +-
> drivers/net/wireless/ti/wl1251/main.c | 57 +++++++++++++++++++++++++++++--
> drivers/net/wireless/ti/wl1251/wl1251.h | 1 +
> 5 files changed, 67 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wl1251/acx.c b/drivers/net/wireless/ti/wl1251/acx.c
> index 1ec98e9..f772e62 100644
> --- a/drivers/net/wireless/ti/wl1251/acx.c
> +++ b/drivers/net/wireless/ti/wl1251/acx.c
> @@ -408,7 +408,8 @@ out:
> return ret;
> }
>
> -int wl1251_acx_group_address_tbl(struct wl1251 *wl)
> +int wl1251_acx_group_address_tbl(struct wl1251 *wl, bool enable,
> + void *mc_list, u32 mc_list_len)
> {
> struct acx_dot11_grp_addr_tbl *acx;
> int ret;
> @@ -422,9 +423,9 @@ int wl1251_acx_group_address_tbl(struct wl1251 *wl)
> }
>
> /* MAC filtering */
> - acx->enabled = 0;
> - acx->num_groups = 0;
> - memset(acx->mac_table, 0, ADDRESS_GROUP_MAX_LEN);
> + acx->enabled = enable;
> + acx->num_groups = mc_list_len;
> + memcpy(acx->mac_table, mc_list, mc_list_len * ETH_ALEN);
>
> ret = wl1251_cmd_configure(wl, DOT11_GROUP_ADDRESS_TBL,
> acx, sizeof(*acx));
> diff --git a/drivers/net/wireless/ti/wl1251/acx.h b/drivers/net/wireless/ti/wl1251/acx.h
> index bea2e67..820573c 100644
> --- a/drivers/net/wireless/ti/wl1251/acx.h
> +++ b/drivers/net/wireless/ti/wl1251/acx.h
> @@ -350,8 +350,8 @@ struct acx_slot {
> } __packed;
>
>
> -#define ADDRESS_GROUP_MAX (8)
> -#define ADDRESS_GROUP_MAX_LEN (ETH_ALEN * ADDRESS_GROUP_MAX)
> +#define ACX_MC_ADDRESS_GROUP_MAX (8)
> +#define ACX_MC_ADDRESS_GROUP_MAX_LEN (ETH_ALEN * ACX_MC_ADDRESS_GROUP_MAX)
>
> struct acx_dot11_grp_addr_tbl {
> struct acx_header header;
> @@ -359,7 +359,7 @@ struct acx_dot11_grp_addr_tbl {
> u8 enabled;
> u8 num_groups;
> u8 pad[2];
> - u8 mac_table[ADDRESS_GROUP_MAX_LEN];
> + u8 mac_table[ACX_MC_ADDRESS_GROUP_MAX_LEN];
> } __packed;
>
>
> @@ -1464,7 +1464,8 @@ int wl1251_acx_rx_msdu_life_time(struct wl1251 *wl, u32 life_time);
> int wl1251_acx_rx_config(struct wl1251 *wl, u32 config, u32 filter);
> int wl1251_acx_pd_threshold(struct wl1251 *wl);
> int wl1251_acx_slot(struct wl1251 *wl, enum acx_slot_type slot_time);
> -int wl1251_acx_group_address_tbl(struct wl1251 *wl);
> +int wl1251_acx_group_address_tbl(struct wl1251 *wl, bool enable,
> + void *mc_list, u32 mc_list_len);
> int wl1251_acx_service_period_timeout(struct wl1251 *wl);
> int wl1251_acx_rts_threshold(struct wl1251 *wl, u16 rts_threshold);
> int wl1251_acx_beacon_filter_opt(struct wl1251 *wl, bool enable_filter);
> diff --git a/drivers/net/wireless/ti/wl1251/init.c b/drivers/net/wireless/ti/wl1251/init.c
> index 92de289..f8a2ea9 100644
> --- a/drivers/net/wireless/ti/wl1251/init.c
> +++ b/drivers/net/wireless/ti/wl1251/init.c
> @@ -127,7 +127,7 @@ int wl1251_hw_init_phy_config(struct wl1251 *wl)
> if (ret < 0)
> return ret;
>
> - ret = wl1251_acx_group_address_tbl(wl);
> + ret = wl1251_acx_group_address_tbl(wl, true, NULL, 0);
> if (ret < 0)
> return ret;
>
> diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c
> index 39a6105..ee318c8 100644
> --- a/drivers/net/wireless/ti/wl1251/main.c
> +++ b/drivers/net/wireless/ti/wl1251/main.c
> @@ -29,6 +29,7 @@
> #include <linux/vmalloc.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> +#include <linux/netdevice.h>
>
> #include "wl1251.h"
> #include "wl12xx_80211.h"
> @@ -678,6 +679,44 @@ out:
> return ret;
> }
>
> +struct wl1251_filter_params {
> + bool enabled;
> + int mc_list_length;
> + u8 mc_list[ACX_MC_ADDRESS_GROUP_MAX][ETH_ALEN];
> +};
> +
> +static u64 wl1251_op_prepare_multicast(struct ieee80211_hw *hw,
> + struct netdev_hw_addr_list *mc_list)
> +{
> + struct wl1251_filter_params *fp;
> + struct netdev_hw_addr *ha;
> + struct wl1251 *wl = hw->priv;
> +
> + if (unlikely(wl->state == WL1251_STATE_OFF))
> + return 0;
> +
> + fp = kzalloc(sizeof(*fp), GFP_ATOMIC);
> + if (!fp) {
> + wl1251_error("Out of memory setting filters.");
> + return 0;
> + }
> +
> + /* update multicast filtering parameters */
> + fp->mc_list_length = 0;
> + if (netdev_hw_addr_list_count(mc_list) > ACX_MC_ADDRESS_GROUP_MAX) {
> + fp->enabled = false;
> + } else {
> + fp->enabled = true;
> + netdev_hw_addr_list_for_each(ha, mc_list) {
> + memcpy(fp->mc_list[fp->mc_list_length],
> + ha->addr, ETH_ALEN);
> + fp->mc_list_length++;
> + }
> + }
> +
> + return (u64)(unsigned long)fp;
> +}
> +
> #define WL1251_SUPPORTED_FILTERS (FIF_PROMISC_IN_BSS | \
> FIF_ALLMULTI | \
> FIF_FCSFAIL | \
> @@ -688,8 +727,9 @@ out:
>
> static void wl1251_op_configure_filter(struct ieee80211_hw *hw,
> unsigned int changed,
> - unsigned int *total,u64 multicast)
> + unsigned int *total, u64 multicast)
> {
> + struct wl1251_filter_params *fp = (void *)(unsigned long)multicast;
> struct wl1251 *wl = hw->priv;
> int ret;
>
> @@ -698,9 +738,11 @@ static void wl1251_op_configure_filter(struct ieee80211_hw *hw,
> *total &= WL1251_SUPPORTED_FILTERS;
> changed &= WL1251_SUPPORTED_FILTERS;
>
> - if (changed == 0)
> + if (changed == 0) {
> /* no filters which we support changed */
> + kfree(fp);
> return;
> + }
>
> mutex_lock(&wl->mutex);
>
> @@ -737,6 +779,15 @@ static void wl1251_op_configure_filter(struct ieee80211_hw *hw,
> if (ret < 0)
> goto out;
>
> + if (*total & FIF_ALLMULTI || *total & FIF_PROMISC_IN_BSS)
> + ret = wl1251_acx_group_address_tbl(wl, false, NULL, 0);
> + else if (fp)
> + ret = wl1251_acx_group_address_tbl(wl, fp->enabled,
> + fp->mc_list,
> + fp->mc_list_length);
> + if (ret < 0)
> + goto out;
> +
> /* send filters to firmware */
> wl1251_acx_rx_config(wl, wl->rx_config, wl->rx_filter);
>
> @@ -744,6 +795,7 @@ static void wl1251_op_configure_filter(struct ieee80211_hw *hw,
>
> out:
> mutex_unlock(&wl->mutex);
> + kfree(fp);
> }
>
> /* HW encryption */
> @@ -1283,6 +1335,7 @@ static const struct ieee80211_ops wl1251_ops = {
> .add_interface = wl1251_op_add_interface,
> .remove_interface = wl1251_op_remove_interface,
> .config = wl1251_op_config,
> + .prepare_multicast = wl1251_op_prepare_multicast,
> .configure_filter = wl1251_op_configure_filter,
> .tx = wl1251_op_tx,
> .set_key = wl1251_op_set_key,
> diff --git a/drivers/net/wireless/ti/wl1251/wl1251.h b/drivers/net/wireless/ti/wl1251/wl1251.h
> index 45df03a..93c18d2 100644
> --- a/drivers/net/wireless/ti/wl1251/wl1251.h
> +++ b/drivers/net/wireless/ti/wl1251/wl1251.h
> @@ -93,6 +93,7 @@ enum {
> } while (0)
>
> #define WL1251_DEFAULT_RX_CONFIG (CFG_UNI_FILTER_EN | \
> + CFG_MC_FILTER_EN | \
> CFG_BSSID_FILTER_EN)
>
> #define WL1251_DEFAULT_RX_FILTER (CFG_RX_PRSP_EN | \

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2013-12-11 21:17:40

by Ben Hutchings

[permalink] [raw]

Subject: Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote:
> On Tuesday 10 December 2013 18:49:22 Dan Williams wrote:
> > On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote:
> > > On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote:
> > > > On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote:
> > > > > Pali Rohár <[email protected]> writes:
> > > > > > Driver wl1251 generating mac address randomly at
> > > > > > startup and there is no way to set permanent mac
> > > > > > address via SET_IEEE80211_PERM_ADDR. This patch
> > > > > > export sysfs file which can set permanent mac address
> > > > > > by userspace helper program. Patch is needed for
> > > > > > devices which do not store mac address in internal
> > > > > > wl1251 eeprom.
> > > > > >
> > > > > > Signed-off-by: Pali Rohár <[email protected]>
> > > > >
> > > > > We have ioctl() command for setting the mac address.
> > > >
> > > > Really? Is there ioctl for setting permanent mac address?
> > > > Can you show me it?
> > >
> > > Now I looked at it again and I did not found any ioctl for
> > > it. There is only ioctl cmd for getting address, not
> > > setting it.
> > >
> > > #define SIOCETHTOOL 0x8946
> > >
> > > /* Get permanent hardware address */
> > > #define ETHTOOL_GPERMADDR 0x00000020
> >
> > Yeah, because it's supposed to be permanent and unchanging.
> > Which means if there was an ioctl for it, that would be
> > contrary to the purpose of a permanent MAC address.
> >
> > I realize the N900 stores the WiFi MAC address completely
> > differently than many other systems, and that's why this
> > sysfs file was created. I don't really have a great
> > converged solution for that, other than what you've currently
> > got, or perhaps adding SPERMADDR to ethtool. One thing I
> > *would* like though, is a restriction on the sysfs file such
> > that if the permanent MAC is already set, it cannot be set
> > again. Otherwise the permanent MAC address isn't permanent
> > at all.

I'm really uncomfortable with the idea of involving userland in
establishing the 'permanent' MAC address. (And from what I gather, the
Nokia software never did that but only used SIOCSIFHWADDR.) It ought to
be set before the interface is ever registered.

> > Dan
>
> Maybe another way could be to use request_firmware to load address
> from userspace... Or what do you think?

I think that's an even worse idea. This is not firmware and it already
exists in separate storage.

I think that rx51_init_wl1251() in
arch/arm/mach-omap2/board-rx51-peripherals.c should either copy the MAC
address out of NVRAM, or if it's too early to do that, then schedule a
function to run later and only then set up wl1251 platform data.

Ben.

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

2013-12-10 19:31:29

On Sunday 08 December 2013 10:24:58 Pali Rohár wrote:
> Hello, I'm sending wl1251 patches from linux-n900 tree [1] for
> comments. More patches come from David's monitor & packet
> injection work. Patches are tested with 3.12 rc5 kernel on
> Nokia N900.
>
> Second version contains new patch for fixing NULL pointer
> dereference which sometimes cause kernel panic and fixes code
> suggested by Pavel Machek.
>
> [1] - https://gitorious.org/linux-n900/linux-n900
>
> David Gnedt (12):
> wl1251: fix scan behaviour while not associated
> wl1251: add sysfs interface for bluetooth coexistence mode
> configuration
> wl1251: retry power save entry
> wl1251: implement hardware ARP filtering
> wl1251: split RX and TX data path initialisation
> wl1251: configure hardware en-/decryption for monitor mode
> wl1251: implement multicast address filtering
> wl1251: disable power saving in monitor mode
> wl1251: fix channel switching in monitor mode
> wl1251: enable tx path in monitor mode if necessary for
> packet injection
> wl1251: disable retry and ACK policy for injected packets
> wl1251: enforce changed hw encryption support on monitor
> state change
>
> Pali Rohár (4):
> wl1251: add nvs file name to module firmware list
> wl1251: Add sysfs file tx_mgmt_frm_rate for setting rate
> wl1251: Add sysfs file address for setting permanent mac
> address wl1251: fix NULL pointer dereference
>
> drivers/net/wireless/ti/wl1251/acx.c | 92 +++++-
> drivers/net/wireless/ti/wl1251/acx.h | 34 ++-
> drivers/net/wireless/ti/wl1251/boot.c | 3 +-
> drivers/net/wireless/ti/wl1251/cmd.c | 59 +++-
> drivers/net/wireless/ti/wl1251/cmd.h | 8 +-
> drivers/net/wireless/ti/wl1251/event.c | 46 ++-
> drivers/net/wireless/ti/wl1251/event.h | 7 +
> drivers/net/wireless/ti/wl1251/init.c | 19 +-
> drivers/net/wireless/ti/wl1251/main.c | 462
> ++++++++++++++++++++++++++++++-
> drivers/net/wireless/ti/wl1251/rx.c | 2 +-
> drivers/net/wireless/ti/wl1251/tx.c | 35 ++-
> drivers/net/wireless/ti/wl1251/wl1251.h | 14 +
> 12 files changed, 720 insertions(+), 61 deletions(-)

So far, there are no new comments for patches 01, 03-13 and 16.
Are there any other problems with that patches or can be accepted
for upstream?

--
Pali Rohár
[email protected]

Attachments:

signature.asc (198.00 B)
This is a digitally signed message part.

2013-12-10 16:10:55

Hi!

> > > Hello, I'm sending wl1251 patches from linux-n900 tree [1] for
> > > comments. More patches come from David's monitor & packet
> > > injection work. Patches are tested with 3.12 rc5 kernel on
> > > Nokia N900.
> > >
> > > Second version contains new patch for fixing NULL pointer
> > > dereference which sometimes cause kernel panic and fixes code
> > > suggested by Pavel Machek.
>
> > So far, there are no new comments for patches 01, 03-13 and 16.
> > Are there any other problems with that patches or can be accepted
> > for upstream?
>
> They are probably fine to merge now. Of course, I was still deleting
> wl12xx patches when they were originally posted, so I'll need someone
> to resend the patches to me...

I'll try to help with that (Pali has his development machine under
repairs), but I'll have to hunt it in archives, too...

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html