2018-04-18 02:47:42

by Scott Register

[permalink] [raw]
Subject: iwlwifi 4.18rc1 SYNC TIME_QUOTA_CMD with fw 31

Hello,

After upgrading to 4.18rc1 iwlwifi is printing a FW error. There was a
previous thread with a similar
issue but they seemed to resolve it with a ucode update. I think I'm
running a newer FW and
am still having an issue. 4.13 works--I haven't gone any higher so far.

iwlwifi 0000:02:00.0: Microcode SW error detected. Restarting 0x2000000.
iwlwifi 0000:02:00.0: Start IWL Error Log Dump:
iwlwifi 0000:02:00.0: Status: 0x00000100, count: 6
iwlwifi 0000:02:00.0: Loaded firmware version: 31.560484.0
iwlwifi 0000:02:00.0: 0x00000038 | BAD_COMMAND
iwlwifi 0000:02:00.0: 0x00A002F1 | trm_hw_status0
iwlwifi 0000:02:00.0: 0x00000000 | trm_hw_status1
iwlwifi 0000:02:00.0: 0x0002495C | branchlink2
iwlwifi 0000:02:00.0: 0x0003962E | interruptlink1
iwlwifi 0000:02:00.0: 0x00000000 | interruptlink2
iwlwifi 0000:02:00.0: 0x00000000 | data1
iwlwifi 0000:02:00.0: 0x00000032 | data2
iwlwifi 0000:02:00.0: 0x00000032 | data3
iwlwifi 0000:02:00.0: 0x003B15C2 | beacon time
iwlwifi 0000:02:00.0: 0x0004EA3C | tsf low
iwlwifi 0000:02:00.0: 0x00000000 | tsf hi
iwlwifi 0000:02:00.0: 0x00000000 | time gp1
iwlwifi 0000:02:00.0: 0x0004EA3D | time gp2
iwlwifi 0000:02:00.0: 0x00000001 | uCode revision type
iwlwifi 0000:02:00.0: 0x0000001F | uCode version major
iwlwifi 0000:02:00.0: 0x00088D64 | uCode version minor
iwlwifi 0000:02:00.0: 0x00000230 | hw version
iwlwifi 0000:02:00.0: 0x00489000 | board version
iwlwifi 0000:02:00.0: 0x00000000 | hcmd
iwlwifi 0000:02:00.0: 0x00122080 | isr0
iwlwifi 0000:02:00.0: 0x00000000 | isr1
iwlwifi 0000:02:00.0: 0x28201802 | isr2
iwlwifi 0000:02:00.0: 0x404001C0 | isr3
iwlwifi 0000:02:00.0: 0x00000000 | isr4
iwlwifi 0000:02:00.0: 0x802F0051 | last cmd Id
iwlwifi 0000:02:00.0: 0x00000000 | wait_event
iwlwifi 0000:02:00.0: 0x0000277E | l2p_control
iwlwifi 0000:02:00.0: 0x00000820 | l2p_duration
iwlwifi 0000:02:00.0: 0x00000000 | l2p_mhvalid
iwlwifi 0000:02:00.0: 0x00000000 | l2p_addr_match
iwlwifi 0000:02:00.0: 0x0000000D | lmpm_pmg_sel
iwlwifi 0000:02:00.0: 0x13091828 | timestamp
iwlwifi 0000:02:00.0: 0x00002838 | flow_handler
iwlwifi 0000:02:00.0: Start IWL Error Log Dump:
iwlwifi 0000:02:00.0: Status: 0x00000100, count: 7
iwlwifi 0000:02:00.0: 0x00000034 | NMI_INTERRUPT_WDG
iwlwifi 0000:02:00.0: 0x00000000 | umac branchlink1
iwlwifi 0000:02:00.0: 0xC0086950 | umac branchlink2
iwlwifi 0000:02:00.0: 0xC00842BC | umac interruptlink1
iwlwifi 0000:02:00.0: 0xC00840CC | umac interruptlink2
iwlwifi 0000:02:00.0: 0x00000400 | umac data1
iwlwifi 0000:02:00.0: 0xC00840CC | umac data2
iwlwifi 0000:02:00.0: 0xDEADBEEF | umac data3
iwlwifi 0000:02:00.0: 0x0000001F | umac major
iwlwifi 0000:02:00.0: 0x00088D64 | umac minor
iwlwifi 0000:02:00.0: 0xC08861DC | frame pointer
iwlwifi 0000:02:00.0: 0xC08861DC | stack pointer
iwlwifi 0000:02:00.0: 0x00000000 | last host cmd
iwlwifi 0000:02:00.0: 0x00004008 | isr status reg
ieee80211 phy0: Hardware restart was requested
ieee80211 phy0: Hardware restart was requested
iwlwifi 0000:02:00.0: FW Error notification: type 0x00000000 cmd_id 0x34
iwlwifi 0000:02:00.0: FW Error notification: seq 0x0070 service 0x00000034
iwlwifi 0000:02:00.0: FW Error notification: timestamp 0x D559
iwlwifi 0000:02:00.0: FW error in SYNC CMD TIME_QUOTA_CMD
CPU: 7 PID: 83 Comm: kworker/7:1 Tainted: G W
4.17.0-041700rc1-generic #201804152230
Hardware name: LENOVO 20KHCTO1WW/20KHCTO1WW, BIOS N23ET37W (1.12 ) 02/27/2018

ethtool & lspci:
driver: iwlwifi
version: 4.17.0-041700rc1-generic
firmware-version: 31.560484.0
expansion-rom-version:
bus-info: 0000:02:00.0
supports-statistics: yes
supports-test: no
supports-eeprom-access: no
supports-register-dump: no
supports-priv-flags: no
02:00.0 Network controller: Intel Corporation Wireless 8265 / 8275 (rev 78)

Any ideas?

Cheers,
Scott


2018-04-19 06:00:45

by Luca Coelho

[permalink] [raw]
Subject: Re: iwlwifi 4.18rc1 SYNC TIME_QUOTA_CMD with fw 31

On Thu, 2018-04-19 at 08:42 +0300, Luca Coelho wrote:
> On Wed, 2018-04-18 at 11:31 +0300, Emmanuel Grumbach wrote:
> > On Wed, Apr 18, 2018 at 5:47 AM, Scott Register <[email protected]>
> > wrote:
> > >
> > > Hello,
> > >
> > > After upgrading to 4.18rc1 iwlwifi is printing a FW error. There
> > > was a
> > > previous thread with a similar
> > > issue but they seemed to resolve it with a ucode update. I think
> > > I'm
> > > running a newer FW and
> > > am still having an issue. 4.13 works--I haven't gone any higher
> > > so
> > > far.
> >
> > Please download the firmware from
> > https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/linux-firmware
> > .g
> > it/plain/iwlwifi-8265-36.ucode
> > This should fix your problem.
>
> Yeah, it should work with FW 36. But if there really is something in
> 4.18 that breaks support on 31, we should either fix it or make sure
> we
> don't even try to load this old firmware.

Hmmm, you (and I) obviously meant 4.17-rc1. ;)

--
Cheers,
Luca.

2018-04-19 05:42:21

by Luca Coelho

[permalink] [raw]
Subject: Re: iwlwifi 4.18rc1 SYNC TIME_QUOTA_CMD with fw 31

On Wed, 2018-04-18 at 11:31 +0300, Emmanuel Grumbach wrote:
> On Wed, Apr 18, 2018 at 5:47 AM, Scott Register <[email protected]> wrote:
> >
> > Hello,
> >
> > After upgrading to 4.18rc1 iwlwifi is printing a FW error. There
> > was a
> > previous thread with a similar
> > issue but they seemed to resolve it with a ucode update. I think
> > I'm
> > running a newer FW and
> > am still having an issue. 4.13 works--I haven't gone any higher so
> > far.
>
> Please download the firmware from
> https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/linux-firmware.g
> it/plain/iwlwifi-8265-36.ucode
> This should fix your problem.

Yeah, it should work with FW 36. But if there really is something in
4.18 that breaks support on 31, we should either fix it or make sure we
don't even try to load this old firmware.

I'll take a closer look.

--
Cheers,
Luca.

2018-04-19 11:10:35

by Luca Coelho

[permalink] [raw]
Subject: Re: iwlwifi 4.18rc1 SYNC TIME_QUOTA_CMD with fw 31

On Thu, 2018-04-19 at 09:00 +0300, Luca Coelho wrote:
> On Thu, 2018-04-19 at 08:42 +0300, Luca Coelho wrote:
> > On Wed, 2018-04-18 at 11:31 +0300, Emmanuel Grumbach wrote:
> > > On Wed, Apr 18, 2018 at 5:47 AM, Scott Register <[email protected]>
> > > wrote:
> > > >
> > > > Hello,
> > > >
> > > > After upgrading to 4.18rc1 iwlwifi is printing a FW error.
> > > > There
> > > > was a
> > > > previous thread with a similar
> > > > issue but they seemed to resolve it with a ucode update. I
> > > > think
> > > > I'm
> > > > running a newer FW and
> > > > am still having an issue. 4.13 works--I haven't gone any higher
> > > > so
> > > > far.
> > >
> > > Please download the firmware from
> > > https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/linux-firmwa
> > > re
> > > .g
> > > it/plain/iwlwifi-8265-36.ucode
> > > This should fix your problem.
> >
> > Yeah, it should work with FW 36. But if there really is something
> > in
> > 4.18 that breaks support on 31, we should either fix it or make
> > sure
> > we
> > don't even try to load this old firmware.
>
> Hmmm, you (and I) obviously meant 4.17-rc1. ;)

Okay, so the reason was very simple. We are calculating the size of
the old version of the scan API incorrectly. This should solve it:

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/scan.h b/drivers/net/wireless/intel/iwlwifi/fw/api/scan.h
index 7af3a0f51b77..21695db51c8a 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/api/scan.h
+++ b/drivers/net/wireless/intel/iwlwifi/fw/api/scan.h
@@ -753,9 +753,7 @@ struct iwl_scan_req_umac {
4 * sizeof(u8))
#define IWL_SCAN_REQ_UMAC_SIZE_V6 (sizeof(struct iwl_scan_req_umac) - \
2 * sizeof(u8) - sizeof(__le16))
-#define IWL_SCAN_REQ_UMAC_SIZE_V1 (sizeof(struct iwl_scan_req_umac) - \
- 2 * sizeof(__le32) - 2 * sizeof(u8) - \
- sizeof(__le16))
+#define IWL_SCAN_REQ_UMAC_SIZE_V1 36


Can you try it?

In the beginning, making the size calculation based on the latest
version made some sense, but it became so complex that it made it very
prone to errors. So it's probably just better to hardcode the sizes
since they never change anyway...

--
Cheers,
Luca.

2018-04-18 08:31:42

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi 4.18rc1 SYNC TIME_QUOTA_CMD with fw 31

On Wed, Apr 18, 2018 at 5:47 AM, Scott Register <[email protected]> wrote:
>
> Hello,
>
> After upgrading to 4.18rc1 iwlwifi is printing a FW error. There was a
> previous thread with a similar
> issue but they seemed to resolve it with a ucode update. I think I'm
> running a newer FW and
> am still having an issue. 4.13 works--I haven't gone any higher so far.

Please download the firmware from
https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/linux-firmware.git/plain/iwlwifi-8265-36.ucode
This should fix your problem.

>
> iwlwifi 0000:02:00.0: Microcode SW error detected. Restarting 0x2000000.
> iwlwifi 0000:02:00.0: Start IWL Error Log Dump:
> iwlwifi 0000:02:00.0: Status: 0x00000100, count: 6
> iwlwifi 0000:02:00.0: Loaded firmware version: 31.560484.0
> iwlwifi 0000:02:00.0: 0x00000038 | BAD_COMMAND
> iwlwifi 0000:02:00.0: 0x00A002F1 | trm_hw_status0
> iwlwifi 0000:02:00.0: 0x00000000 | trm_hw_status1
> iwlwifi 0000:02:00.0: 0x0002495C | branchlink2
> iwlwifi 0000:02:00.0: 0x0003962E | interruptlink1
> iwlwifi 0000:02:00.0: 0x00000000 | interruptlink2
> iwlwifi 0000:02:00.0: 0x00000000 | data1
> iwlwifi 0000:02:00.0: 0x00000032 | data2
> iwlwifi 0000:02:00.0: 0x00000032 | data3
> iwlwifi 0000:02:00.0: 0x003B15C2 | beacon time
> iwlwifi 0000:02:00.0: 0x0004EA3C | tsf low
> iwlwifi 0000:02:00.0: 0x00000000 | tsf hi
> iwlwifi 0000:02:00.0: 0x00000000 | time gp1
> iwlwifi 0000:02:00.0: 0x0004EA3D | time gp2
> iwlwifi 0000:02:00.0: 0x00000001 | uCode revision type
> iwlwifi 0000:02:00.0: 0x0000001F | uCode version major
> iwlwifi 0000:02:00.0: 0x00088D64 | uCode version minor
> iwlwifi 0000:02:00.0: 0x00000230 | hw version
> iwlwifi 0000:02:00.0: 0x00489000 | board version
> iwlwifi 0000:02:00.0: 0x00000000 | hcmd
> iwlwifi 0000:02:00.0: 0x00122080 | isr0
> iwlwifi 0000:02:00.0: 0x00000000 | isr1
> iwlwifi 0000:02:00.0: 0x28201802 | isr2
> iwlwifi 0000:02:00.0: 0x404001C0 | isr3
> iwlwifi 0000:02:00.0: 0x00000000 | isr4
> iwlwifi 0000:02:00.0: 0x802F0051 | last cmd Id
> iwlwifi 0000:02:00.0: 0x00000000 | wait_event
> iwlwifi 0000:02:00.0: 0x0000277E | l2p_control
> iwlwifi 0000:02:00.0: 0x00000820 | l2p_duration
> iwlwifi 0000:02:00.0: 0x00000000 | l2p_mhvalid
> iwlwifi 0000:02:00.0: 0x00000000 | l2p_addr_match
> iwlwifi 0000:02:00.0: 0x0000000D | lmpm_pmg_sel
> iwlwifi 0000:02:00.0: 0x13091828 | timestamp
> iwlwifi 0000:02:00.0: 0x00002838 | flow_handler
> iwlwifi 0000:02:00.0: Start IWL Error Log Dump:
> iwlwifi 0000:02:00.0: Status: 0x00000100, count: 7
> iwlwifi 0000:02:00.0: 0x00000034 | NMI_INTERRUPT_WDG
> iwlwifi 0000:02:00.0: 0x00000000 | umac branchlink1
> iwlwifi 0000:02:00.0: 0xC0086950 | umac branchlink2
> iwlwifi 0000:02:00.0: 0xC00842BC | umac interruptlink1
> iwlwifi 0000:02:00.0: 0xC00840CC | umac interruptlink2
> iwlwifi 0000:02:00.0: 0x00000400 | umac data1
> iwlwifi 0000:02:00.0: 0xC00840CC | umac data2
> iwlwifi 0000:02:00.0: 0xDEADBEEF | umac data3
> iwlwifi 0000:02:00.0: 0x0000001F | umac major
> iwlwifi 0000:02:00.0: 0x00088D64 | umac minor
> iwlwifi 0000:02:00.0: 0xC08861DC | frame pointer
> iwlwifi 0000:02:00.0: 0xC08861DC | stack pointer
> iwlwifi 0000:02:00.0: 0x00000000 | last host cmd
> iwlwifi 0000:02:00.0: 0x00004008 | isr status reg
> ieee80211 phy0: Hardware restart was requested
> ieee80211 phy0: Hardware restart was requested
> iwlwifi 0000:02:00.0: FW Error notification: type 0x00000000 cmd_id 0x34
> iwlwifi 0000:02:00.0: FW Error notification: seq 0x0070 service 0x00000034
> iwlwifi 0000:02:00.0: FW Error notification: timestamp 0x D559
> iwlwifi 0000:02:00.0: FW error in SYNC CMD TIME_QUOTA_CMD
> CPU: 7 PID: 83 Comm: kworker/7:1 Tainted: G W
> 4.17.0-041700rc1-generic #201804152230
> Hardware name: LENOVO 20KHCTO1WW/20KHCTO1WW, BIOS N23ET37W (1.12 ) 02/27/2018
>
> ethtool & lspci:
> driver: iwlwifi
> version: 4.17.0-041700rc1-generic
> firmware-version: 31.560484.0
> expansion-rom-version:
> bus-info: 0000:02:00.0
> supports-statistics: yes
> supports-test: no
> supports-eeprom-access: no
> supports-register-dump: no
> supports-priv-flags: no
> 02:00.0 Network controller: Intel Corporation Wireless 8265 / 8275 (rev 78)
>
> Any ideas?
>
> Cheers,
> Scott